New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #2265, on October 4th, 2013, 04:29 PM »
rev 2265 -- the usual "pre-bigger-commit" bunch of small fixes/additions.
(10 files, 4kb)

* Making the footer JavaScript outputter available to hackers. It's needed for the next commit... (index.template.php)

! IE 10 supports flex value 'space-between', but it needs to be renamed to 'justify'. (Class-CSS.php)

! Static method call in a non-static class constructor? Oh well, at least it still worked... So, whatever. (Class-Skeleton.php)

! Always initialize the rtl variable (for @if tests), for clarity mainly. Although, I'll have to admit, I haven't tested RTL mode in quite a while... Also saved a few lines by replacing a list/each pair with a key/current pair. I'm like that. (Load.php)

! Wedge was leaving some blank lines in the HTML source after soft-merging posts. (Subs-Template.php)

! Topic list had too narrow a width in mobile skins. Hmm, I have a feeling that fix is in need of something more distinguished... (MessageIndex.template.php)

* Commenazi, and a reminder to self. (ManageMaintenance.php, Subs-Post.php, Subs-Members.php)

* Moved the JumpTo text from the basic HTML source to the script.js file, where at least it's cached. Only saves a few bytes per page, but why wouldn't I want to..? Plus, hey, it's a free fix for infinite scrolling... (index.template.php, script.js)
Re: New revs
« Reply #2266, on October 5th, 2013, 12:05 PM »
rev 2266 -- turns out I had many more minor changes to be applied separately from the infinite scrolling rewrites; it's better for readability to do them separately, really...
(10 files, 13kb)

! Fixed AeMe embeds not always correctly working in infinitely loaded posts. Oh, yes, they'll still fail on most mobile browsers... No se preocupe. (Aeva-Embed.php, Aeva-Subs-Vital.php)

! The recent mass-conversion of files to use UTF-8 (rev 2252) broke aeva_getEncryptedFilename(), so I rewrote it to use hex-encoded values, instead of plain characters. This should work better (and it better do, I wrote the conversion manually!), but honestly, maybe I should just not bother either, because it's all about Linux filenames, and I'm sure they support UTF-8.. Right? (Aeva-Subs-Vital.php)

* Sped up the Go up/Go down features; an animation looks nice, but I never really wanted to spend one second flying over a topic page. (topic.js)

* Moved QuickInTopicModeration to QuickMod.php -- makes more sense, to me. (index.php, QuickMod.php, Display.php)

* Harmonized hr separators to always show at the end of a topic page, instead relying on CSS to hide the last one. This is better for infinite scrolling, basically. And John asked for it. (Msg.template.php, sections.css)

! While forced linebreaks are generally okay in a fixed layout, I should really stop enforcing these in responsive layouts. (index.language.php)

! Prevent quick_edit buttons from being duplicated when using infinite scrolling. (topic.js)

- Reverted the actionbar hack in quick edit. It's best to get as much real estate as possible for the textarea, even if it doesn't look as good. There are worse things to deal with, really. (topic.js)

- Removed a few unused styles. I'm sure there are more in there, I just need to find them, or someone else to find them for me... (sections.css)

@ Note: added an 'edited' string to language files, too... This will be used in the next commit.
Re: New revs
« Reply #2267, on October 5th, 2013, 12:13 PM »
rev 2267 -- PHEW! And here it is... The infinite scrolling rewrite. Although, I think what's infinite here, is the rewrite, not the scrolling.
(6 files, 10kb)

* Changed the way 'Mark unread' works on topics. The original thinking was this (and it always confused the hell out of me): the unread position would be reset to what it was *before* the current topic page was loaded. Instead, I changed it to be reset to the page you're currently viewing. That is, if you've already read the topic, and you just want to sort of 'bookmark' a particular page, you can go to it, and press Mark unread. Next time you follow a 'new' link to the topic, you'll be taken to that page. I believe this is more natural. Another difference is with the last page. Previously, pressing Mark unread there would mark the entire topic as read. Now, doing it will simply mark this page as unread. If you need to mark the entire topic as unread, for some reason, you can just go back to page 1 and mark it unread there. (Display.php, Subs-Boards.php)

* Overhauled infinite scrolling to be closer to what one might except from it. Instead of requiring several mouse wheel rolls to load the next page and show it, Wedge will pre-fetch it in the background when you're getting close to the end of the page. It will then show it immediately as soon as you reach said end. The hardest part was to get 'mark read' to behave, and it should be good: an infinitely scrolled page is only marked as read when the next page is prefetched. On the last page, Wedge will not prefetch anything of course, but will send a Mark read request in the background if the page isn't already marked as read. (Display.php, subs-Boards, Display.template.php, index.css, topic.js)

* The Ajax version of topic pages (i.e. infinite scrolling) now return only what's needed, i.e. the posts themselves, and a new version of the page index. (Display.template.php, topic.js)

+ Added an 'edited' variable to topic post arrays. Basically, if set to true, it means "this post has been edited since the last time (last post) you read (in) this topic." Up till now, it wasn't possible to determine whether the first 'new' post in a topic was really an unread post, or a modified post. (Display.php, Msg.template.php, index.language.php)

* Side font size tweak. Needed wider testing, so I want it on wedge.org. (index.css)

@ The topic.js rewrite, despite all the additional improvements, saved about 300 bytes. Dunno how much when gzipped, though.

@ Note to self: need to support touch in infinite scrolling.
Re: New revs
« Reply #2268, on October 5th, 2013, 04:27 PM »
rev 2268 -- I'll get it right! I promise!!
(5 files, 3kb)

+ Doing the touch version of infinite scrolling. Well, it's just a try. The first one didn't work, so... Trying again. (topic.js)

* Trying to increase infinite scrolling performance.

  - Attempting to limit the number of events infinite scrolling is tied to to just one (scroll for desktop, touchmove for mobile.) (topic.js)
  - No need to load topic.js again; I'm in charge of that file, so I'm responsible for calling its functions manually as needed. (Display.template.php)
  * The Mime and Zoomedia plugins now add a 'processed' class, and refuse to handle further calls to items marked with that class. (script.js, zoomedia.js)
  * Same for InTopicModeration calls. (topic.js)

! The Mark read request on last pages was sent on each page scroll... Oops! (topic.js)

! Fixed wrong language entry. (Who.french.php)
Re: New revs
« Reply #2269, on October 8th, 2013, 03:02 PM »
rev 2269 -- back to some less headache-inducing commits, phew...
(3 files, 2kb)

+ Wess now allows for the use of wildcards instead of values in @remove operations. This can be useful, if you're not sure what the parent is doing at this point. (Class-CSS.php)

! Fixed error occurring on topics with no replies. (Display.php)

! Plugin language files should get their entities converted to UTF, just like regular language files. (Load.php)
Re: New revs
« Reply #2270, on October 9th, 2013, 10:58 AM »
rev 2270 -- minor admin stuff. I usually don't set foot in there, but I have to now, don't I...?
(7 files, 3kb)

* Some tweaks to the admin search... Don't cut off item descriptions (really, any reason to do that in the first place..?!), better French text, and improve the layout a bit. (Admin.php, Admin.template.php, mana.css, Admin.french.php)

! Typo in the reattribute feature. Seems that Pete liked spelling 'cannon' instead of 'cannot' (same in Simple/WedgeDesk), there may be a hidden meaning behind that, but I don't know what. (ManageMaintenance.php)

* Added a few separators in the reattribute feature, because it wasn't made very clear that the last option was for merging members, rather than merging a member and a guest. It's very different, I'd say. (ManageMaintenance.template.php)
Re: New revs
« Reply #2271, on October 9th, 2013, 07:17 PM »
rev 2271 -- small, but nice.
(2 files, 2kb)

+ Added ability for all skin tags to run on a specific URL. Use url-* for that, with * being your target $_GET variable, of course. <css url-action="profile" url-area="forumprofile">, for instance, will print CSS only on the ?action=profile;area=forumprofile page. That's a very, very good addition for themers. (Subs-Cache.php)

! Fixed broken layout on ViewQuery pages. (ViewQuery.php)
Re: New revs
« Reply #2272, on October 10th, 2013, 02:59 PM »
rev 2272
(58 files, 6kb)

- $keys and $disable_trans are params only used in non-MySQL situations, and as Wedge isn't coming back to PGSQL and SQLite any time soon, there's no reason to complicate insertion queries for nothing, uh? Also updated all 200+ inserts to reflect that. (Class-DB.php, and 57 other files.)
Re: New revs
« Reply #2273, on October 10th, 2013, 03:17 PM »
rev 2273 -- a small one.
(4 files +1-1, 3kb)

* Redid the Modify button icon; it was so long, it looked like a trident. Plus, the new version is twice smaller in size. (modify.png, modify.gif, index.css)

* Remove whitespace when linktrees are empty. (index.template.php, index.css)

! Don't prevent non-default events when middle-clicking an element to open the sidebar. In the real world, it means: if you middle-click a '+' button somewhere, the associated link will correctly open in a new tab. My only goal is to avoid that dreaded Windows 'auto-scroll' mode. Sorry, I hate that one so much, it's just unbelievable... (script.js)
Re: New revs
« Reply #2274, on October 15th, 2013, 04:41 PM »Last edited on October 15th, 2013, 10:53 PM
rev 2274
(3 files, 2kb)

* Rewrote message icon handler for clarity: split into multiple named methods, list is no longer a child of the body itself, body click handler is removed when list is closed, etc. It also saves a few bytes of JS and CSS, not many, but that's still a plus. (topic.js, index.member.css, sections.css)

! I'm not sure why I've been using $(document).find() instead of just $() in some code, as well as using .bind/.unbind when I switched to modern jQuery (and .on/.off) long ago, but... I guess it happens even to the best. (topic.js)

- Unused class no-flex. (sections.css)

:edit: ! Fixed code blocks in Firefox. Just like Chrome, Firefox doesn't like white-space: pre blocks when they only generate an horizontal scrollbar, but it doesn't cause the same glitch, and it can't be fixed the same way, so I'm disabling flex on these posts when such a situation occurs. It's very unlikely they'd benefit from flexbox anyway, as flex is mostly for very, very short posts. (topic.js)

(Sorry for forgetting to log the last one.)
Re: New revs
« Reply #2275, on October 15th, 2013, 05:32 PM »
rev 2275 -- mostly small stuff.
(12 files, 7kb)

* Overhauled credits page again, to make it easier to grasp. Will shorten it again later. Using CSS columns instead of the two-columns variation, as it will scale much better. (Credits.php, Who.template.php, sections.css, Who.language.php)

+ Added support for IE 11 in Wess and we::is. (Class-CSS.php, Class-System.php)

+ Improved CSS column support: break-* rules are now supported. (Class-CSS.php)

! Fixed CSS column support in IE 11. (Class-CSS.php)

@ Minor fixes:
  ! Fixed typo in getLegacyAttachmentFilename. Managed to track it down to a years-old revision by Pete. Interestingly, or not, I did the exact same work a few days ago on another file, and didn't notice it. And without the typo. (Subs.php)
  - Removed individual developers from SMF credits; refer to SMF itself for a list. It was only there because, back in 2010, I insisted that I'd been a SMF developer, even if was never given the proper badge for it. In 2013? I'm just glad I never was officially in that team.
  * Commenazi. (Subs-Boards.php, Subscriptions-PayPal.php)
  * Centering a checkbox in the member list. (ManageMembers.php)
  * Simplified and harmonized a regex. By two bytes. Well worth the time spent on reading this, uh? (Aeva-Subs-Vital.php)
Re: New revs
« Reply #2276, on October 16th, 2013, 11:26 PM »
rev 2276
(8 files, 4kb)

+ Skin option parameter url-* (url-action, url-board, etc.) can now take a wildcard value. i.e. url-board="*" will run the option only if you're within a board, any board. (Subs-Cache.php)

+ Added new skin option parameter: board-type="blog|board" will run the option only if we're within a blog or board. This was required by the fact that it isn't possible to determine the board type just from looking at the URL, eh. (Subs-Cache.php)

* Homepage will now systematically show the info center in the sidebar if you're on a desktop. Really, there's enough space in it for that, and it makes sense. The only situation where it's a problem is when there isn't enough space to show the sidebar itself, but then you just need to middle-click, so... Whatever? (Home.php)

* Renamed JS string is_ff to is_firefox, as apparently they want to be called Fx, and is_fx is misleading IMO. Might as well just waste a couple of bytes and use the full name, eh..? (editor.js, script.js, sha1.js, topic.js)

* Trying a new method for middle-clicking to trigger sidebar. More precisely, I'm now dismissing clicks if they're done over an item that has any events associated to it. Should work, but I want to be cautious here. Needs more testing. (script.js)

- Removed unused strings. (Who.language.php)
Re: New revs
« Reply #2277, on October 17th, 2013, 12:25 AM »
rev 2277
(5 files, 6kb)

* The debug junk in the footer will now allow you to show either the block list or the SQL query log, or both. Just select 'no one' in the Debug admin area if you want to disable one of them. The reason I did it was after I realized that even after gzipping, the block list would still take 1 to 2KB of bandwidth when I never use it; I only want an easy link to the query log, and that only barely takes a few bytes to show. (ManageServer.php, Subs-Template.php, Admin.template.php, ManageSettings.language.php)

* Added a JS 'hint' that the db_show_debug checkbox is linked to the two dropdowns that follow it. (ManageServer.php)
Re: New revs
« Reply #2278, on October 19th, 2013, 10:38 PM »
rev 2278 -- while waiting for someone to comment on my newest privacy/contact list topic... :P
(5 files, 3kb)

* Refactored credits page's multi-column to a generic class; this should make it easier to re-use through other code, and plugins. (Who.template.php, index.css, sections.css)

! SSI pages would show header and footer twice if rendering through ssi_run(). (Subs-Template.php)

! Fixed an undefined variable if current page didn't specify a title (e.g. SSI-run page.) (Subs-Template.php)

! Non-global @removes in Wess didn't accept wildcards, due to a last-minute test. Doh. (Class-CSS.php)

* Give more visibility to some profile homepage links. (sections.css)

- Removed some unneeded styling on flexbox-enabled browsers. (sections.css)
Re: New revs
« Reply #2279, on October 22nd, 2013, 11:41 PM »
rev 2279 -- wait, it no longer works that way..... :P Well, until I figure out a clean way to add rev numbers, Reply numbers for this topic will stand for a rev number.
(1 file changed, 1 insertion(+), 1 deletion(-))

- Removed a reference to the old tag system.

@ First attempt at a git commit & push!
@ And it obviously worked... :)