handleMultiple is only partially implemented

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,667
handleMultiple is only partially implemented
« on June 16th, 2013, 02:37 AM »
handleMultiple is only partially implemented. Its only occurrence is now working.

Now, it gets passed several parameters which led to the assumption that it modifies emails. But it does nothing.

I suggest the following:

  • Do away with all parameters
  • Make it so it only determines whether of not to issue multiple notifications.
  • Don't affect emails.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: handleMultiple is only partially implemented
« Reply #1, on June 16th, 2013, 07:18 AM »Last edited on June 16th, 2013, 07:29 AM
If we do away with the parameters how would it update the existing notifications? The parameters are for modifying notifications and not e-mails, I never finished implementing e-mails. That is allowing something like "Likes" to say "live627 and 6 others like this notification".
The way it's meant to be

Farjo

  • "a valuable asset to the community"
  • Posts: 492

Nao

  • Dadman with a boy
  • Posts: 16,061
Re: handleMultiple is only partially implemented
« Reply #3, on November 16th, 2014, 01:45 PM »
This was written by Dragooon back then; his implementation (while it had the merit to exist) had many flaws, I fixed most of them but there are still many problems with it.
One of the problems is when you get multiple notifications for a specific topic, or whatever event -- like, several people liked a post of yours. It can get complicated to manage. If you'll notice, Facebook actually has (or had) similar problems. Recently, I noticed that they changed their system to handle multiple notifications in a single item per visit to the notification center, and then when you come back to it, new notifications are put into a new item. Or maybe it's on a daily basis, I don't know.
This isn't something I see myself working on in the foreseeable future, so right now you're stuck with Wedge's way of doing things, unless someone else wants to take the job of course.

Farjo

  • "a valuable asset to the community"
  • Posts: 492
Re: handleMultiple is only partially implemented
« Reply #4, on November 16th, 2014, 11:17 PM »
So it's to do with Notifications? I must ask - does it matter? How many times will it happen without happening another time alone?

Do you want it on the bug list?