Permissions UI does not honour illegal permissions properly

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Permissions UI does not honour illegal permissions properly
« on September 18th, 2012, 04:22 AM »
There is, in the depths of the permissions code a function to set which permissions should not ever be shown to guests.

But it does not honour own/any properly - so even when an _any permission is listed to be denied to guests, it still shows up in the admin panel, for example view_ip_address_any is in the deny-to-guests list but still shows in the guests permissions area.

I cannot confirm whether this is an SMF bug or not, all the cases in SMF itself only ever extend _own permissions to be denied to guests (because they can't have an _own)

But it needs fixing.

(Also, permissions + hooking are sort of borked, I really need to extend it in the plugin-info.xml file to fix other issues related to it but that's something else entirely.)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,078
Re: Permissions UI does not honour illegal permissions properly
« Reply #1, on September 18th, 2012, 04:02 PM »
I'd tend to say --- anything that's not 'obvious' may eventually be 'reported' in later stable releases, and fixed at that time.
I've lived long enough to know that there's something more important than taking one's time to release a flawless product -- it's taking one's time to release a product that most people see as flawless, but in a shorter time :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278