Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #15, on March 29th, 2012, 11:14 PM »
We do, but with any luck I can start getting back on them now I'm a lot more settled in and have no plans to go out for the next couple of days :)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #16, on March 29th, 2012, 11:19 PM »
I'll be busy tomorrow -- will be at the premiere for Saint Seiya Omega. :)
So I probably won't be available after 3pm until later in the night.
I'll try to work on some of the bugs tomorrow morning though.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #18, on April 4th, 2012, 11:34 AM »
I need to recheck, but after I did the move/move back, it was still wrong in certain places like categories. :/

Did you also apply the extra change regarding the category table?

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #19, on April 5th, 2012, 12:32 PM »
cat_order? Yep... (Long ago.)
Posted: April 4th, 2012, 12:06 PM

Bump?
(Oh there are so many posts I'm waiting for someone to answer really... :P)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #20, on April 6th, 2012, 04:32 PM »
It's still broken but I have no idea why - the category codepath uses the same codepath as the boards one but it's still out of order.

Also, I think there might be a problem if the category is collapsed but you still try going to the category page itself, you'll just get that category header on its own without any way to uncollapse it.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #21, on April 6th, 2012, 10:49 PM »
So that's a bug right...?

As for board order -- what exactly should be expected?
BTW, I updated the site to rev 1545.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #22, on April 6th, 2012, 10:53 PM »
Well, the problem is as my first post - if you look at the Public Area category's boards on the main board index, they're in a different order to when you view them in the category itself.

It's right everywhere *except* the category specific page.
Posted: April 6th, 2012, 10:51 PM

Btw, I've locally fixed the issue regarding categories being hidden and collapsed at the same time.

Nao

  • Dadman with a boy
  • Posts: 16,079

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #24, on April 6th, 2012, 11:50 PM »
Well, yes and no. The symptoms of misordering are indeed an SMF bug - and applying the changes fixes where they occur in SMF. But the category specific listing is not an SMF feature and that's the part that's broken.

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #25, on April 8th, 2012, 05:36 PM »
But isn't it using the same functions as the board index..?
I'm sure it's an easy fix?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #26, on April 8th, 2012, 06:13 PM »
It's running the exact same query with one difference - only the category gets an extra clause in the WHERE.

The 'obvious' answer would be to ORDER BY board_order but that will add an overhead that isn't needed (since it works naturally elsewhere)

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #27, on April 12th, 2012, 02:32 PM »
Considering that clicking on a category in the linktree (which is AFAIK the only way to access a category page) is not something people will do 70 times a day, I added the ordering to the category listing...

I'm not sure why it does the sorting naturally if b.id_board isn't tested against, but it doesn't really matter. It's not going to make the forum any slower anyway...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Board order issues
« Reply #28, on April 12th, 2012, 03:16 PM »
Other than using a filesort on that page >_< But it isn't likely to be MANY calls (other than search engines)

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: Board order issues
« Reply #29, on April 12th, 2012, 03:29 PM »
Not only that, but any given category is unlikely to have tons of boards in it.
So, a filesort on.... a dozen entries at best? It's not going to kill performance, is it...?