« Nice work
Quick moderation
Trying something a bit new »
Poll

What type of quick moderation do you use most?

What's quick moderation?
2 (8.7%)
Quick moderation as icons
2 (8.7%)
Quick moderation as checkboxes
19 (82.6%)
Total Members Voted: 20

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Quick moderation
« on February 12th, 2012, 01:41 AM »
Thinking about making some changes to this from the user perspective, would like to know what you think about it at present.

I have actually already said what I plan to do but would like some general feedback on it first.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Quick moderation
« Reply #1, on February 12th, 2012, 03:58 AM »
I think that the icons are clumsy. Checkboxes make more sense to me.
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Quick moderation
« Reply #2, on February 12th, 2012, 04:06 AM »
Well, I'm trying to find out how many people use them (and so far the poll is trending towards what I long suspected)

To be honest, I'm looking at doing what I already suggested (and I think Nao agreed with), which is to simply pull quick moderation as being an option, and make it hardwired in for those who can see it, so it's always visible.

Dr. Deejay

  • Happy new year all!
  • Posts: 118
Re: Quick moderation
« Reply #3, on February 12th, 2012, 09:44 AM »
I use checkboxes all the time. They're great for cleaning up spam, making multiple topics sticky/unsticky in a short time etc. I've used icons for a few days and I found them horrible looking. But I guess that's just because of the icons

Nao

  • Dadman with a boy
  • Posts: 16,082

Powerbob

  • Posts: 151
My Alpha test site; http://www.pplb.net/wedge/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Quick moderation
« Reply #6, on February 12th, 2012, 10:13 AM »
I'm thinking the option was added by request from a vocal minority of people at a time when the SMF guys wanted to please everyone. Just like Dragooon and I added plenty of options to Aeva and SMG that really shouldn't have been offered. I'll try to clean these up, too. Simplicity trumps extensivity. Most of the time.

MultiformeIngegno

  • Posts: 1,337

TE

  • Posts: 286
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Quick moderation
« Reply #9, on February 12th, 2012, 01:53 PM »
OK, the poll is definitely confirming my suspicions: that not only should quick moderation be just turned on and set to checkboxes, but that the very fact it wasn't turned on by default did confuse some people.

So yeah, time to get busy on the phasing out of stuff :D
Re: Quick moderation
« Reply #10, on February 12th, 2012, 02:29 PM »
As an aside, I found that the search handler does some queries based on this, as to whether the user has permission to do different things in each board.

Then I discovered, for each thing it's testing for, there's a query being made. There's 3 queries being run per search without quickmod, and 11 queries being run - per search - with quickmod enabled.

Needless to say, I'm changing how boardsAllowedTo works when confronted with an array, so that it can be made faster than one query per permission.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Quick moderation
« Reply #11, on February 12th, 2012, 02:31 PM »
Quote from Arantor on February 12th, 2012, 01:53 PM
OK, the poll is definitely confirming my suspicions: that not only should quick moderation be just turned on and set to checkboxes, but that the very fact it wasn't turned on by default did confuse some people.

So yeah, time to get busy on the phasing out of stuff :D
Quick mod is just a single checkbox, so it doesn't take space and even if I never really use it, it's still okay to have the checkbox in there...
Quote from Arantor on February 12th, 2012, 02:29 PM
Then I discovered, for each thing it's testing for, there's a query being made. There's 3 queries being run per search without quickmod, and 11 queries being run - per search - with quickmod enabled.

Needless to say, I'm changing how boardsAllowedTo works when confronted with an array, so that it can be made faster than one query per permission.
Yeah, that sounds quite odd to me.. Then again, if it's just for people with moderation powers, it's bearable...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Quick moderation
« Reply #12, on February 12th, 2012, 02:37 PM »
Quote
Quick mod is just a single checkbox, so it doesn't take space and even if I never really use it, it's still okay to have the checkbox in there...
Actually you'd be surprised in how many places that checkbox turns up, it's more than I realised (display, message index, search, unread/unreadreplies)
Quote
Yeah, that sounds quite odd to me.. Then again, if it's just for people with moderation powers, it's bearable...
That's the point, it isn't. Search is outside of boards, so stuff like lock/pin/etc aren't loaded, so there's no way to know (except for checking global moderator, perhaps) whether or not the user would have these powers, so the query has to be run either way.

The only saving grace is that, by default, the quick moderation is off, so only 3 queries get issued by default, not 11. But I've rewritten boardsAllowedTo by now so that if it receives a single string, it returns a simple array of boards, but if it gets an array, it returns an array (key = permission, value = array of boards where that permission is granted), and it looks like on searching the source that this won't be a problem to do it differently.
Re: Quick moderation
« Reply #13, on February 12th, 2012, 03:22 PM »
Anyway, for those who haven't seen the changelog, I've done it, and it all seems to work as expected :)

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: Quick moderation
« Reply #14, on February 12th, 2012, 06:26 PM »
Did it also run the extra queries even if the only option available in QMod is mark as read? That would be quite harsh since that could be all members, not just moderators.
« Nice work
Trying something a bit new »