Poll

Should we remove the spellchecker from Wedge?

YES!!!
30 (83.3%)
No, but replace pspell with support for enchant.
1 (2.8%)
No, my English-speaking community loves it.
3 (8.3%)
No, my non-English-speaking community loves it.
2 (5.6%)
Total Members Voted: 31

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Spell checker
« on October 8th, 2011, 03:49 PM »
Quick poll.

Who uses it? Any of your users use it?

What language(s) do you use it with? Does it work that well for you?


Just that I'm thinking about removing it given how most of the time it's built into browsers anyway now...
Posted: October 8th, 2011, 03:45 PM

Also, I suppose there's no real reason why it couldn't be supported through a plugin instead of being a core feature...
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

spoogs

  • Posts: 417
Re: Spell checker
« Reply #1, on October 8th, 2011, 04:07 PM »
I don't use it nor do my users AFAIK.

Plugin territory sounds about right (if there are requests for it). As stated before most if not all browsers have a spell checker anyway which I would think most people use over the forum's checker.
Stick a fork in it SMF

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Spell checker
« Reply #2, on October 8th, 2011, 04:52 PM »
My only user who needs it actually uses Word to type his posts and leverage spellchecking. I guess to each their own.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Spell checker
« Reply #3, on October 8th, 2011, 04:54 PM »
Quote from Nao on October 8th, 2011, 04:52 PM
My only user who needs it actually uses Word to type his posts and leverage spellchecking. I guess to each their own.
If he's doing that, he doesn't need Wedge's spellchecking anyway because he's using Word's, right?

That's not so weird, actually. I know someone who always uses OpenOffice to write big emails out before copy/pasting them into their web-based email. It's just easier for them, apparently, though I have no idea *why* that's the case given that they're also a LiveJournal user and have no problem blogging directly into LJ.

Dr. Deejay

  • Happy new year all!
  • Posts: 118
Re: Spell checker
« Reply #4, on October 8th, 2011, 04:55 PM »
I don't use it either. It's nice, but useless. I'd say ditch it. Discovered it somewhere in February 2011. Before: never missed it

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Spell checker
« Reply #5, on October 8th, 2011, 04:57 PM »
He said its easier for him is all. I don't know of anyone who uses it-- even though it's pretty cool. But not very practical. Should be unlined really. Inlined.

Dragooon

  • I can code! Really!
  • polygon.com has to be one of the best sites I've seen recently.
  • Posts: 1,841
Re: Spell checker
« Reply #6, on October 8th, 2011, 05:00 PM »
I use my browser's spell checking if I use one.
The way it's meant to be

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Spell checker
« Reply #7, on October 8th, 2011, 05:04 PM »
Well, it's theoretically cool but it has issues. Firstly, it's not that well supported - and in future it's going to have to be reworked as PHP is dropping pspell support in favour of something else that I can't remember right now.

There is one thing it does do, though, that's cute: if it's enabled it'll spell check when searching and offer possible suggestions, but that can be integrated through the plugin (and should be, since it's still a pspell dependence, and mostly people don't even notice when it doesn't do it)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Spell checker
« Reply #8, on October 8th, 2011, 07:29 PM »
Hmm yeah, looks like direct support for pspell was dropped in 5.3 in favor of enchant... Which wasn't core before 5.3. Uh, so that pretty much rules out the possibility of using it in Wedge without hacks and such. Sucks... Unless we simply disable the spellcheck feature for PHP < 5.3.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Spell checker
« Reply #9, on October 8th, 2011, 07:33 PM »
Well, either we provide support for both in the core and do some magic to test it, or we move it all out of the core and let a plugin deal with it.

The greatest benefit about using plugins is that for stuff like this is that you get to isolate the functions and enhance them on their own without having to worry about everything else, which sounds ideal for this.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Spell checker
« Reply #10, on October 8th, 2011, 10:30 PM »
Yup, agreed...

Well, now is the moment where everyone says, "if AeMe doesn't handle avatars and attachments then it's better off as a plugin", I know I know :P (Except it'll do it... One day. Uh. Let's pray.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Spell checker
« Reply #11, on October 8th, 2011, 10:38 PM »
Well, yes and no. There are quite a few limitations in the current attachment system, that can't be remedied without a significant amount of work - the quantity of which is probably not that far off what's needed to be able to use Aeva for attachments and avatars.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Spell checker
« Reply #12, on October 8th, 2011, 11:14 PM »
Which limitations? Apart from the one where you can't post attachments in PMs and they're 'stuck' to a post...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Spell checker
« Reply #13, on October 8th, 2011, 11:19 PM »
* No reasonable way to extend the system in any useful manner (e.g. the hurdles SD/WD have to do)
* Attachment folders are limited by size not number of files, and there's no automatic failover to a separate folder to prevent any given folder getting too big (in any case, the folder handling should not be based on linear progression, would be much better doing similar to what MediaWiki does, which encourages spreading files more equally by folder than simple progression does)
* Avatars are not in their own folder by default (frankly, I'm thinking about forcing them all to be in their own folder, and then ripping out the code that serves avatars through the system, there's really not a lot of reason to do so if avatars are tested against bad stuff up front)

TE

  • Posts: 286
Re: Spell checker
« Reply #14, on October 9th, 2011, 10:10 AM »
spellchecker is enabled (not because it's needed, just because I was possible to activate the checker  :eheh:) for all of my forums but IMO it's not used widely.. I'm fine with it beeing a plugin.

IMHO the more "core functions" are made a plugin the better.. There are several other features which could be made a plugin instead of a build-in core feature, e.g. the calendar, the wysiwyg editor, personal messages, polls...
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru