Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - live627
91
Other software / Re: SM.org compromised
« on August 20th, 2013, 08:25 AM »If you're okay being paranoid why shouldn't I be okay with that? :)
Analogy: I put security cameras in your house and you'll trust me to not share what I find. Trust goes out the window.
92
Other software / Re: SM.org compromised
« on August 17th, 2013, 11:14 AM »I trust this password manager. :-)
http://www.passpack.com/
93
Other software / Re: SM.org compromised
« on August 13th, 2013, 11:11 AM »1. Relevant xkcd : http://xkcd.com/936/
94
Archived fixes / Re: Just emptied the boards table and got an error
« on August 10th, 2013, 02:52 AM »
Just got around to testing this again. It works.
95
Archived fixes / Re: Flexbox, meet code
« on August 3rd, 2013, 01:56 PM »Please note that, very annoyingly, pressing Quick Edit on one of these posts and then Cancel, will restore the original bug. Well, I can't do much about that one, can I..?
96
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:52 PM »
Example: some of the get***() methods are present in both Notification and Notifier.
97
Off-topic / Re : 3D'ing
« on August 3rd, 2013, 01:30 PM »
"It's simple math, really" -- now I wonder who said that :lol:
98
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 01:27 PM »
Commit it and I will test it.Quote Oh, that's the easy part. What's confusing for me is the presence of same-name methods across multiple objects.
If you get that, you're already halfway through the system.
99
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 07:39 AM »
Ok, so I've been playing around some more. The biggest issue is that the email body is duplicated since it is HTML. II have yet to understand why.
The above error is because it is calling on the Notification object and wants the getEmail() method from a Notifier.
Code: [Select]
Let's save some memory! $valid_notifiers is only checked for existence, so why not use a bool instead of an object?
Code: [Select]
Objects shouldn't be this hard to understand. I think it's the duplication that's the problem. Perhaps Notification can go, and its leftovers merged with weNotif. Also, shouldn't Notifier be abstract?
The above error is because it is calling on the Notification object and wants the getEmail() method from a Notifier.
Index: I:/repos/wedge/trunk/Themes/default/Notifications.template.php
===================================================================
--- I:/repos/wedge/trunk/Themes/default/Notifications.template.php (revision 2194)
+++ I:/repos/wedge/trunk/Themes/default/Notifications.template.php (working copy)
@@ -116,9 +116,10 @@
$str .= "\n" . $title . "\n" . str_repeat('=', strlen($title)) . "\n";
foreach ($notifs as $n)
- $str .= $n->getEmail();
-
- $str .= "\n\n";
+ {
+ list (, $n) = $n->getNotifier()->getEmail($n, array());
+ $str .= $n . "\n\n";
+ }
}
return $str;
Let's save some memory! $valid_notifiers is only checked for existence, so why not use a bool instead of an object?
Index: I:/repos/wedge/trunk/Sources/Notifications.php
===================================================================
--- I:/repos/wedge/trunk/Sources/Notifications.php (revision 2194)
+++ I:/repos/wedge/trunk/Sources/Notifications.php (working copy)
@@ -609,7 +608,7 @@
{
$status = isset($data['email_notifiers'][$notifier->getName()]) ? $data['email_notifiers'][$notifier->getName()] : 0;
if ($status < 2 && (empty($data['disabled_notifiers']) || !in_array($notifier, $data['disabled_notifiers'])))
- $valid_notifiers[$notifier->getName()] = $notifier;
+ $valid_notifiers[$notifier->getName()] = true;
}
if (empty($valid_notifiers))Objects shouldn't be this hard to understand. I think it's the duplication that's the problem. Perhaps Notification can go, and its leftovers merged with weNotif. Also, shouldn't Notifier be abstract?
101
Bug reports / Re: Periodic notifications don't seem to work
« on August 3rd, 2013, 12:16 AM »
Is that someone else me? :P
I'm also finding it hard to understand. I've been doing my head in trying to make it work. The emails send, but the data isn't quite right. :^^;:
I'm also finding it hard to understand. I've been doing my head in trying to make it work. The emails send, but the data isn't quite right. :^^;:
102
Off-topic / Re: Thoughts from Jeff Atwood
« on August 3rd, 2013, 12:08 AM »That's 'cuz you' sma'ter than the 'est o' us 'ednecks! :lol:
103
Bug reports / Re: Periodic notifications don't seem to work
« on August 2nd, 2013, 07:06 AM »
Fatal error: Call to undefined method Notification::getEmail() in I:\www\wedge\trunk\Themes\default\Notifications.template.php on line 119
That's when trying to run the schd task.
That's when trying to run the schd task.
104
Off-topic / Re: Thoughts from Jeff Atwood
« on August 2nd, 2013, 02:47 AM »
Hard refresh to fix smileys.