Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - live627
136
Plugins / Re: Team List
« on June 21st, 2013, 03:46 AM »
I'm thinking of sports rosters, where teams are groups and can easily surpass 20 members each.
137
Archived fixes / Incorrect list styling in the notifications window
« on June 21st, 2013, 03:42 AM »
See attached figures. List items are supposed to have bullets and no frame. Untitled.png shows how a BBC list looks in the notif window.
138
Plugins / Re: Team List
« on June 21st, 2013, 03:29 AM »
Did not think of that but I should put in a link to show more members in large groups.
139
Off-topic / Re: YAQT (yet another quote thread)
« on June 21st, 2013, 03:24 AM »There is autocomplete for this...
141
The Pub / two-columns and Firefox on narrow windows
« on June 20th, 2013, 10:37 AM »
The two-columns elements are not expanding to fit the entire width if using Firefox or old IE (untested) and using a narrow window.
The following two selectors are being overriden
Code: [Select]
Making them !important fixes the problem.
The following two selectors are being overriden
// Two columns become one if viewed on a small screen.
@media all and (max-width: 800px)
.two-columns
width: 100%
margin: 0Making them !important fixes the problem.
142
Features / Re: Plugin revs
« on June 20th, 2013, 05:50 AM »
rev 88
(1 file, 1 KB)
! [Contact] Fix menu button positioning and icon
(1 file, 1 KB)
! [Contact] Fix menu button positioning and icon
143
Plugins / Popular topics
« on June 18th, 2013, 07:12 AM » |
Adds a block in the info center which will display the most replied to topics in a given period of time.
144
Off-topic / Re: What type of programmer are you?
« on June 16th, 2013, 09:08 AM »
hahaha
Obviously not. That's where two heads are better than one.
Obviously not. That's where two heads are better than one.
145
Off-topic / Re: What type of programmer are you?
« on June 16th, 2013, 08:37 AM »
Hallf-assed theoretical perfectionist.
146
Bug reports / Re: Periodic notifications don't seem to work
« on June 16th, 2013, 04:09 AM »
I actually meant here. I should be more clear. :P
@Nao> Please ensure the task has the right parameters in the DB. Also, the task itself must return true in order to not get disabled. :^^;:
Code: [Select]
@Dragooon> Why is this template so complicated? Ideally, the variables should be put into $context in the source file. I think templates/views should never do any logic work, only presentation.
@Nao> Please ensure the task has the right parameters in the DB. Also, the task itself must return true in order to not get disabled. :^^;:
Index: Sources/Notifications.php
===================================================================
--- Sources/Notifications.php (revision 2166)
+++ Sources/Notifications.php (working copy)
@@ -670,7 +765,7 @@
continue;
// Assemble the notifications into one huge text.
- $body = template_notification_email($m['notifications']);
+ $body = template_notification_email($m['notifications'], $m['id']);
$subject = sprintf($txt['notification_email_periodical_subject'], $m['name'], $m['unread']);
sendmail($m['email'], $subject, $body, null, null, true);
Index: Themes/default/Notifications.template.php
===================================================================
--- Themes/default/Notifications.template.php (revision 2166)
+++ Themes/default/Notifications.template.php (working copy)
@@ -64,46 +64,14 @@
}
-function template_notification_email($notifications)
+function template_notification_email($notifications, $member_id)
{
global $txt;
@@ -111,7 +79,7 @@
foreach ($notifications as $notifier => $notifs)
{
- list ($title) = weNotif::getNotifiers($notifier)->getProfile();
+ list ($title) = weNotif::getNotifiers($notifier)->getProfile($member_id);
$str .= '
<h3>' . $title . '</h3>
@Dragooon> Why is this template so complicated? Ideally, the variables should be put into $context in the source file. I think templates/views should never do any logic work, only presentation.
147
Bug reports / Periodic notifications don't seem to work
« on June 16th, 2013, 02:40 AM »
I've yet to find out why.
148
Bug reports / handleMultiple is only partially implemented
« on June 16th, 2013, 02:37 AM »
handleMultiple is only partially implemented. Its only occurrence is now working.
Now, it gets passed several parameters which led to the assumption that it modifies emails. But it does nothing.
I suggest the following:
Now, it gets passed several parameters which led to the assumption that it modifies emails. But it does nothing.
I suggest the following:
- Do away with all parameters
- Make it so it only determines whether of not to issue multiple notifications.
- Don't affect emails.
149
Archived fixes / Re: Undefinded function: sendemail()
« on June 16th, 2013, 02:21 AM »
That's part if it, I think.
If handleMultiple returns false then a new notification is not created but the current one's time is updated.
I just reviewed the code again. It is seriously broken, Sorry Dragooon. The bug found in the OP is only the icing on top of the cake.
Commencing spam.
If handleMultiple returns false then a new notification is not created but the current one's time is updated.
I just reviewed the code again. It is seriously broken, Sorry Dragooon. The bug found in the OP is only the icing on top of the cake.
Commencing spam.
150
Archived fixes / Re: Undefinded function: sendemail()
« on June 16th, 2013, 01:26 AM »
All periodical notifications are disabled here :P
public function handleMultiple(Notification $notification, array &$data, array &$emaiL_data)
{
return false;
}
That means "disable periodical notifications for this notification".
public function handleMultiple(Notification $notification, array &$data, array &$emaiL_data)
{
return false;
}
That means "disable periodical notifications for this notification".