Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - TE
92
Other software / Re: Wedge can give a bad impression on first sight
« on June 13th, 2011, 08:32 PM »
snoopy-virtual,
just a short note regarding the importer: 1.1.x to wedge is on my roadmap, and I'll start work once I've finished the SMF 2 importer.
just a short note regarding the importer: 1.1.x to wedge is on my roadmap, and I'll start work once I've finished the SMF 2 importer.
93
Features: Forward thinking / Re: Removing deprecated code
« on June 11th, 2011, 09:02 AM »TE, you made the jump to SimpleXML? I was carefully going to reuse Subs-Package.php to interpret XML in the package manager overhaul but if SXML is already used in one area, hell, let's reuse it properly!
The one thing I still miss in SimpleXML is proper error handling (broken XML files, e.g. unclosed tags etc) but that's already solved within the new importer engine (the one in the team board is totally outdated, I'll upload the new one tomorrow).
94
Features: Forward thinking / Re: Removing deprecated code
« on June 10th, 2011, 08:24 PM »5.2 would still be good. It has JSON and ZIP by default, as well as file upload progress. But 5.3 would be great.
95
Features: Forward thinking / Re: Removing deprecated code
« on June 10th, 2011, 06:39 PM »
the php version on oldest linux (debian etch) is 5.2.0-8 :huh:
96
Other software / Re: Wedge and SMF directions
« on June 7th, 2011, 08:46 PM »Of course, I've been totally missing Nao over there for some time.
97
Other software / Re: SMF 2.0 final THIS MONTH?
« on June 1st, 2011, 08:24 PM »
np, it's not very complicated. php has it's own build-in exception class for catching errors, which is IMO very useful, especially when using object oriented code. The class smfException extends this internal class with a simple function (error_handler_callback). This function creates an object every time an error is reached and throws the related error to the screen. Instead of using SMFs internal error handler I just replaced it with the new function.
PHPs internal exception class is somewhat more nitpicking than the normal error handler, thus the script aborted.
Example: the normal error_handler would allow this, simply because of the @ before $test. (int) would force an undefined variable (without the @ you'd get an undefined index error) to become 0. the exception class doesn't allow such "dirty" coding.
Code: [Select]
PHPs internal exception class is somewhat more nitpicking than the normal error handler, thus the script aborted.
Example: the normal error_handler would allow this, simply because of the @ before $test. (int) would force an undefined variable (without the @ you'd get an undefined index error) to become 0. the exception class doesn't allow such "dirty" coding.
<?php
$test = (int) @$test;
echo $test;
?>98
Other software / Re: SMF 2.0 final THIS MONTH?
« on June 1st, 2011, 06:10 PM »
the exception is thrown because of this line:
Code: [Select] $_SESSION['failed_login'] isn't set at this time, thus proper (cleaner) code should be:
Code: [Select]
$_SESSION['failed_login'] = @$_SESSION['failed_login'] + 1;$_SESSION['failed_login'] = isset($_SESSION['failed_login']) ? ($_SESSION['failed_login'] + 1) : 1;99
Other software / Re: SMF 2.0 final THIS MONTH?
« on June 1st, 2011, 05:24 PM »
I'll bet there are lots of other bugs.. just found another one..
how to reproduce: add this to index.php
Code: [Select] replace SMFs internal error handler with the above object oriented version:
Code: [Select] replace with:
Code: [Select]
then login to the forum and type a wrong password, the result is:
Code: [Select]
how to reproduce: add this to index.php
class smfException extends Exception
{
public static function error_handler_callback($code, $string, $file, $line, $context)
{
$e = new self($string, $code);
$e->line = $line;
$e->file = $file;
throw $e;
}
} set_error_handler('error_handler');set_error_handler(array("smfException", "error_handler_callback"), E_ALL);then login to the forum and type a wrong password, the result is:
Fatal error: Uncaught exception 'smfException' with message 'Undefined offset: 1' in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\svn\Sources\LogInOut.php:701 Stack trace: #0 C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\svn\Sources\LogInOut.php(701): smfException::error_handler_callback(8, 'Undefined offse...', 'C:\Program File...', 701, Array) #1 C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\svn\Sources\LogInOut.php(282): validatePasswordFlood('5', '') #2 [internal function]: Login2() #3 C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\svn\index.php(163): call_user_func('Login2') #4 {main} thrown in C:\Program Files\Apache Software Foundation\Apache2.2\htdocs\svn\Sources\LogInOut.php on line 701100
Other software / Re: SMF 2.0 final THIS MONTH?
« on June 1st, 2011, 03:56 PM »Yeah, it's the OpenID bug, but as I just pointed out... that ain't new, nor even a surprise - it's been broken since at least RC3 (with the same reason)
From a tactical view it was a big mistake. I would have released it as promised on the end of may, then fix all remaining bugs and release a 2.0.1 short time afterwards. At least the promised release date could have been observed.
Now the release is delayed AND there will still be some bugs.
101
Other software / avatar bug
« on May 30th, 2011, 09:16 PM »
there's a new bug over at SM.org (and possibly in 2.0), just upload an avatar and check the preview image.. it's broken.
102
Features: Upcoming / Re: Language tags
« on May 11th, 2011, 10:51 PM »@TE> fr and en tags are actually in use at wedge.org (since it's based off noisen), so use nobbc for them ;)
103
Features: Posts & Topics / Re: Automatic Quote splitter
« on May 11th, 2011, 10:46 PM »
Nao, you made my day :cool: great idea und quite useful feature.
104
Features: Upcoming / Re: Blogs!
« on May 11th, 2011, 04:37 PM »Did you get Pete's NDA?
Would be nice to get your mail addresses via personal message, so I could add these to my spamfilter's whitelist.
105
Features: Upcoming / Re: Language tags
« on May 11th, 2011, 04:30 PM »
I'd personally prefer [lang=en]text[/lang] instead of [en]text[/en].