Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Dragooon
61
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on June 3rd, 2013, 10:04 AM »
@Nao: Okay I can see you uploaded the mentions plugin but since it's not completely BSD anymore I can't merge the changes back to my GitHub repository, and I can't distribute it either. So...what happens now?
62
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 10:22 PM »
@Nao: Can you re-enable markReadForNotifier on this site? It's annoying to have pending notifications of stuff I've already seen :P
63
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 10:18 PM »
Quote from Arantor on June 2nd, 2013, 10:17 PM
I got no problem with that provided that the UI is usable :)
Yeah, of course. My notification system's aim was always to completely replace what was there, because I didn't want to be restricted by what's there because I didn't like it re-implementing the same things in different flavours.
64
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 10:11 PM »
Quote from Arantor on June 2nd, 2013, 10:11 PM
Why not just rewrite the current page that already covers existing subscriptions to boards/topics?
Because the existing stuff goes out the window :P
65
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 10:10 PM »
Quote from Arantor on June 2nd, 2013, 10:07 PM
Yeah, I figured about that much - but my concern is still there: how does the user see what they have subscribed to and optionally unsubscribe to those? That's what the old Profile > Notifications is for, giving you somewhere to review your subscriptions and to remove them - and right now we either have to figure out how to present the two separate notifications pages or fuse the list of things you're subscribed to into the notifications settings page...
Currently I'm adding a new page which lists all the current subscriptions (which works) subscriber wise. Considering this'll go in the core, we can do anything I guess. I can't do a screenshot since my localhost is messed up.
66
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 10:05 PM »
Quote from Arantor on June 2nd, 2013, 08:38 PM
So we have two notifications pages then?
No, I'm not being clear I guess. The subscription plugin just adds the ability for existing notifier to have the ability to be subscribed to. The current page/UI is still used for preferences as well as for the notifications. Basically, it just adds a layer on top of the current system so that a plugin or core feature can add the ability to subscribe to any object (board, topic etc) which's notification is pushed through the current system. It adds no new UI element (the topic subscription one just replaces the URL of the current Notify button).

Basically here's how it goes (topic subscription plugin is an arbitrary example)
A user clicks "Notify" button on a topic -> the request gets sent to the subscription core which registers the ID and type of the subscription.
Another random user posts a reply -> the topic subscription plugin has a new_post callback which calls the subscription core to issue notifications
The subscription core issues notifications passing the given data to every subscribed member -> The topic subscription notifier kicks in and delivers all the notifications

You can install and try, or I can finish the patch in a couple of days (already WIP) and post it to merge.
67
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 08:21 PM »
Quote from Arantor on June 2nd, 2013, 07:31 PM
I guess I need to install that to understand how it works... screenshots would have been nice :P
The UI is same, its all about the back end.
68
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 2nd, 2013, 07:24 PM »
Got kind of late, ran into a terrible viral yesterday. Anyway, this is what I meant. It's not a new notifier but an extension to notifications itself, which facilitates providing notifications without any direct link but rather through an opt-in mode, hence the whole subscriptions thing. It works on similar principals of Notifications, a notifier which wants to be able to be subscribed has to declare a new class and specify it's behaviour, and call the subscription's publish options. Then the core pushes notifications (via the same notifier) to all the subscribed members. It doesn't really add much to the UI except a profile page to view notifications, most of it is internal stuff so that one can modularly add subscription features. Here's an example (topic subscriptions) which works just fine. I believe this is what you meant?
69
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 08:40 PM »
But I already have it working :P, at least I think I do. I'll give a detailed post tomorrow.
70
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 08:35 PM »
So basically what SMF is already doing?
71
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 04:42 PM »
Quote from Arantor on May 31st, 2013, 04:34 PM
Yes, they're required to view notifications, however the notifications are pulled AJAXively, yes? In which case that would presume you only need to load it for the cases when a user is actually viewing them (i.e. as part of the AJAX service) rather than every page load.
Hm, that's a good point. It should be possible to load them on demand but I'll have to take a look at it. Since they don't really cause a lot of load it's not high on my priority atm.
72
Off-topic / Re: System Visitation: IPB 3.4.5
« on May 31st, 2013, 04:41 PM »
That was a pretty good read over a coffee, got to know some interesting stuff. I've always wondered, how's their community? i.e. third party development, support etc.
73
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 04:29 PM »
Quote from Arantor on May 31st, 2013, 04:15 PM
All in one page? Right now having two pages is confusing ;) I got no problems with AJAXifying stuff as needed.

Also, something I noticed... the notifications core plus all notifications that hook into it are all loaded every page load... do we need to load them every page load or only if we're actually going to send notifications (or do something else notification related)?
Ah, okay. I'll look into simplifying them. Yes, they're required to view the notifications as well.
74
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 04:12 PM »
Quote from Arantor on May 31st, 2013, 04:12 PM
I'm not so bothered by the core part of it, because I know it can handle it - it's the UI for the user, selecting what topics they want - and more importantly opting out of topics - that I'm a bit fuzzier on. Essentially we need to somehow splice the old thing into the shiny thing :P
Well I'm currently keeping the UI more or less the same, if you got any better ideas I'm all ears.
75
Plugins / [Plugin] Re: Notifications system (1.0)
« on May 31st, 2013, 03:53 PM »
I already got that covered, that's what the notification subscriptions core is all about (and the topic subscription automatically subscribes as well), I just need to make an up to date patch.
Quote
They allow for notifications being controlled by admin as to whether email or notification is sent, and whether the user has a choice in the matter.
I've always meant to improve email handling, so this is a pretty good idea.