Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Dragooon
46
Off-topic / Re: What type of programmer are you?
« on June 16th, 2013, 08:08 AM »
I'm half-assed most of the time :P, basically I do iterations of everything I do, improving and fixing things after quickly coding the first draft.
47
Archived fixes / MySQL version detection broken on installation
« on June 16th, 2013, 08:06 AM »
This caused me to uproot my localhost :lol:
Fix:
Code: [Select]
Fix:
Index: root/install.php
===================================================================
--- root/install.php (revision 2166)
+++ root/install.php (working copy)
@@ -772,7 +772,7 @@
}
// Do they meet the install requirements?
- if ((version_compare($db['required_client'], preg_replace('~^\D*|\-.+?$~', '', mysqli_get_client_info())) > 0) || (version_compare($db['required_server'], preg_replace('~^\D*|\-.+?$~', '', mysqli_get_server_info())) > 0))
+ if ((version_compare($db['required_client'], preg_replace('~^\D*|\-.+?$~', '', mysqli_get_client_info())) > 0) || (version_compare($db['required_server'], preg_replace('~^\D*|\-.+?$~', '', mysqli_get_server_info($db_connection))) > 0))
{
$incontext['error'] = sprintf($txt['error_db_too_low'], 'Server: ' . mysqli_get_server_info() . ' / Client: ' . mysqli_get_client_info());
return false;48
Archived fixes / Re: Undefinded function: sendemail()
« on June 16th, 2013, 07:30 AM »
handleMultiple doesn't affect periodical, it has nothing to do with it. Let us know of any issues you find.
49
Bug reports / Re: Periodic notifications don't seem to work
« on June 16th, 2013, 07:27 AM »
@live627: It isn't doing any logical work, I wouldn't count getting parameters from an object as logical work.
50
Bug reports / Re: handleMultiple is only partially implemented
« on June 16th, 2013, 07:18 AM »
If we do away with the parameters how would it update the existing notifications? The parameters are for modifying notifications and not e-mails, I never finished implementing e-mails. That is allowing something like "Likes" to say "live627 and 6 others like this notification".
51
Archived fixes / Re: Undefinded function: sendemail()
« on June 15th, 2013, 06:19 PM »Lulz... That explains a lot.
And nope, nothing in the error log... Which can only mean one thing: Wedge never even gets to that point, meaning there's another error left...
Dragooon is the champion of super-cool features that are totally, completely, utterly untested... :niark:
52
Archived fixes / Re: Undefinded function: sendemail()
« on June 15th, 2013, 10:59 AM »
Oops, should be sendmail. That line only handles e-mails when there's a notification bump, instant e-mail for new notification works, if you've set your notifications on periodical then I fixed that in my previous patch.
53
Plugins / Re: Hooking up data loading
« on June 15th, 2013, 10:22 AM »
Now I remember, it was for $_db_con, it's a protected property of wesql and some error handling (although that can easily be replaced). Otherwise the class was meant to be independent (I didn't want to rely on existing functions, even though it represents them in a lot of ways).
54
Plugins / Re: Hooking up data loading
« on June 15th, 2013, 06:54 AM »Even though it extends wesql, it it does its own queries instead of calling wesql for its needs. Sounds silly to me and should be changed.
55
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 6th, 2013, 02:39 PM »I have a solution for the whole local mailserver thing... it's called 'not worrying about it but making sure I have mail queue enabled'... because then I can see what entered the queue.
56
Features / Re: Culmination of Permissions Ruminations
« on June 6th, 2013, 08:32 AM »
This is feeling like an awfully familiar discussion, and I feel like I've said this before, but what about plugins? Every big plugin on SMF has had their own permission systems defined. That's not good, right?
But all in all roles is definitely a better route to go, and perhaps drop post-count based groups but instead have something like event-based groups? Where one can define events at which different groups can be assigned to a member, and that way one can hook into post counts, karma, likes etc.
But all in all roles is definitely a better route to go, and perhaps drop post-count based groups but instead have something like event-based groups? Where one can define events at which different groups can be assigned to a member, and that way one can hook into post counts, karma, likes etc.
57
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 6th, 2013, 08:11 AM »What do you mean, exactly..? :^^;:
Posted: June 6th, 2013, 08:10 AM
I've left a few notifications pending for a bit, partly to prove emailing them works and partly to see what happens when a user accrues a lot of notifications (11 unread so far), and the sense I'm getting is for a "mark all read" button.
Thoughts?
58
Plugins / [Plugin] Re: Notifications system (1.0)
« on June 5th, 2013, 06:42 PM »Dunno what's the point in keeping the member ID in the data field, though...! ;)
59
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on June 4th, 2013, 06:08 AM »
We handle spaces. So we're good there.
60
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on June 3rd, 2013, 03:03 PM »Well I did say I uploaded it to satisfy your curiosity. And if you want to improve it even more. You have svn access on plugins, don't you..?
May I ask what the point of putting it on github is? It can only be used in Wedge... ^^