Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Dragooon
226
Plugins / [Plugin] Re: Improved attachments upload
« on March 10th, 2013, 08:13 AM »
And fixed (lightly tested, didn't do a cross browser test), also merged the changes Nao did in Plugin repository
Quote from live627 on March 10th, 2013, 12:18 AM
Quote from Arantor on March 9th, 2013, 11:53 PM
Sure I remember that. I'm still convinced it's ultimately not a blocker for it being a core feature, but simply that the selector is not as selective as it should be about grabbing events.
If only drag events let us see if any files are being dragged, then such would be easier.
You can, actually (see my commit above), it's slightly more awkward since you can't directly access files object while the element is being dragged.
227
Archived fixes / Re: Flexbox, meet code
« on March 10th, 2013, 07:03 AM »
Seems fine to me on Chrome beta 26.0.1410.19
228
Plugins / [Plugin] Re: Improved attachments upload
« on March 10th, 2013, 06:57 AM »
Quote from live627 on March 9th, 2013, 11:47 PM
Remember the bug where a selected word in the posting box being dragged would trigger this plugin's event?  That's why it was removed from this site...

BTW, whatever became of the ambitious dream to replace attachments with media items?
That stupid ass bug isn't fixed yet? I swear I fixed it months ago...its a pretty simple fix.
229
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 10th, 2013, 06:11 AM »
I'll do some benchmarking on Monday or Tuesday, until then I'm leaving it as is. Its working fine atleast.
230
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 10th, 2013, 05:40 AM »
I thought of that but wouldn't it be slower? 6 LIKES vs 66 elements in an IN statement.
231
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 09:54 PM »
And I ran into even more issues, names with punctuations would work but what if someone does "@Nao: Would it work?", the colon would screw it up and it'll be an even bigger pain (and this happens fairly commonly in forums). So I decided to split the strings up even further, instead of splitting by spaces it now splits by everything that's not a alphanumeric character (regex \w boundary) and maks combinations like first part, first and second part, first, second and third part and so on. A stupid (and improbable) sentence like
Code: [Select]
@Admin: This is perhaps a crude test, but how would @Maxwel do for the later project? I'm not entire sure if this'll work like the way it's supposed to.
@Maxwel: What do you think of the project itself? Care to elaborate on your findings? Perhaps add another prospect given by @Trish to @Soxell?
What about @-Lük-? How would this really work? Would it work? Or would it not work? Does't it require a massive amount of overhead for bear that shouldn't be born?
generates 66 combinations in about 20ms, which is then queried against real_name in members table. It's definitely a hit on performance but shouldn't be by much.
232
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 06:11 PM »
Quote from Dragooon on March 9th, 2013, 02:27 PM
Actually mentions would fail absolutely miserably for usernames with a space, I gotta figure something out for this.
Okay, fixed this part. Had to make the whole name matching thing a bit slower and quite more complicated, but it's quite robust now. Since this only happens after a post is created, a bit of a performance hit shouldn't matter much (documented my algorithm on the function's docblock if anyone's interested).
233
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 02:27 PM »
Actually mentions would fail absolutely miserably for usernames with a space, I gotta figure something out for this.
234
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 02:16 PM »
Quote
\w+ shouldn't match the ", but if you're doing that on the client side it should be fine.

(It is more of an issue on the server side because all display names and usernames are all pushed through htmlspecialchars first)
No, I'm doing that on the server side. On the client side it's is from @ till the first whitespace.
Quote
Regarding core vs not core, I found through bad experience that 'core plugins' do not work that well from a user perspective. They embody everything that is wrong with Core Features: having to go to an unrelated page that was convenient for the developers to just grab everything together, and it is a proven cause of support requests. Not that there won't be support requests anyway but at least some people will use search and just straight up exploration to find it otherwise.

I'd rather either have it totally as a plugin, or fully core, I don't see that any intermediate measure suits anyone but us from a purely convenient point of view.

I would love to see both this and the notifications core being core features and completely integrated. Seems to me that might be faster?
Definitely wouldn't make much of a difference on speed, maybe through saving a bunch of call_hook hoops and perhaps one little query, but that's more or less about it (I've tried to keep the footprint as low as I can, so it doesn't leave me much scope either way). So it's merely a semantic choice. Plugin gives me the ability to independently work on it without having you to go through legal hoops (DCO, CLA etc.) for me and I get to maintain my GitHub repository (this is actually the only major factor stopping me). Perhaps a plugin distributed in core and enabled by default? That way it's a totally core plugin?
235
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 01:45 PM »
Quote from Arantor on March 9th, 2013, 01:40 PM
Ideally, yes. Probably even enabled by default if I'm honest. The feature is a big draw for some and given the "only triggers on @" there's not even a performance concern.

Interesting question, what would happen with the above sentence as typed?
Nothing, it'll search for " as an username on the server side (probably not even that since I don't think the regex will match it as a valid username[1]), find nothing and leave it alone. So will the JS interface (shouldn't even do a request since technically the username is less than three characters long).

If this goes in by default, so does the notification core. I don't mind it being in by default and enabled (i'd actually love that), as long as I can keep my GH repository. So if it gets a svn:external with a special status as a "core plugin" or something so that the UI can be simplified, I don't have a problem.
 1. currently I'm using /\@(\w+)/ (I'm not a regex expert, this'll probably fail on a few valid usernames)
236
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 01:36 PM »
Well fair enough, what do you suggest? Entirely including it in core?
237
Plugins / [Plugin] Re: Improved attachments upload
« on March 9th, 2013, 09:46 AM »
Quote from Plugin revs
Dragooon, I'm still waiting for your approval to change the author ID to Wedgeward
Nobody told me about this? I didn't even know there was an alternative copy of this plugin in Wedge's plugin repository :P. I don't mind the author ID change, but there has to be a better way to maintain the repository. Can't it be some sort of svn:external with the master in my GitHub account?
238
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 9th, 2013, 06:45 AM »
Pretty sure we can figure out a convenient way to include this in core. Just because its in core doesn't mean it has to be in sources folder, it can be a core plugin. IMO that gives the user more options which is a good thing.
239
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 8th, 2013, 10:06 PM »
Quote from Nao on March 8th, 2013, 09:59 PM
Interesting!

Are these all stable enough to be installed here, at least for 'testing'...?
Hopefully within a week, a couple of things are left in the core.
240
Plugins / [Plugin] Re: User Mentions v1.0 (9th March 2013)
« on March 8th, 2013, 09:55 PM »
Quote from Arantor on March 8th, 2013, 09:49 PM
Awesome :)
And thanks to you as well for the playground :)