Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Dragooon
151
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 07:54 PM »
@Dismal Shadow

Ah..it only works if I put a space after your name, the breaking might be a little off in the mentions plugin. Will have a look in a while.
152
Features / Re: Permissions UI, please help, everyone!
« on March 26th, 2013, 07:01 PM »
I know one thing, it's quite an elaborate mess to code with. You can't query against permissions directly like SMF.
153
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 07:00 PM »
Quote from Arantor on March 26th, 2013, 06:50 PM
There's another issue, actually. If I open 5 tabs, e.g. 5 new topics, only the first post has any notifications in the popup, the rest just have the 'view all' bit, though all 5 tabs have the right number of notifications.
It has to be cache juggling things up, same query can't return two different results...
154
Features / Re: Permissions UI, please help, everyone!
« on March 26th, 2013, 06:17 PM »
Quote from Arantor on March 26th, 2013, 04:54 PM
Inheriting can be problematic, it's why I deliberately went with copying for SimpleDesk.

   See, I'm trying to keep it simple - and inheriting, or copying for that matter, is not necessarily a simple way to do it.
Yeah, I realise that. I'm not sure how XF does it, it seems to follow SMF 1 style?
155
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 05:20 PM »
@Nao: Ugh...can it be related to caching? It's randomly juggling notifications for me and that's the only reasoning I can think of.

EDIT: Oh and how did you format the text the way you did?
156
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 05:15 PM »
I'm not throwing any blame but I've never seen it happen here or on my local code before, it's only doing that after recent updates. I'll take a look tomorrow and see if I can find the problem.
157
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 26th, 2013, 04:56 PM »
I have none :P. Something is wrong, my counter is not going down. I have no unread notifications but it's telling me I have two.
158
Features / Re: Permissions UI, please help, everyone!
« on March 26th, 2013, 04:49 PM »
Quote
Copying or inheriting? The two are subtly but very importantly different.
Inheriting, the changes would apply to all.
159
Features / Re: Permissions UI, please help, everyone!
« on March 26th, 2013, 07:08 AM »
How about something in middle? Revert back to the original SMF 1 type board permissions, but allow some boards to follow other board's permissions. Something like "Set same permissions as <insert board name here>", this becomes sort of like profiles without the actual profiles type thing.
160
Features / Re: X-Content-Security-Policy
« on March 26th, 2013, 05:37 AM »
Sorry about that, I'll try to be more careful. 
161
Features / Re: X-Content-Security-Policy
« on March 25th, 2013, 06:00 PM »
Quote from Arantor on March 25th, 2013, 05:47 PM
Can't really assume $data will be populated - assume it will likely be empty and not even unserialize properly as a result.
Yeah, sorry about that. I added checks for missing fields, but what about $data itself? Something like
Code: [Select]
$data = unserialize($row['data']);
$data = is_array($data) ? $data : array();
? Because either way, a crappy string will issue an E_NOTICE.
162
Features / Re: X-Content-Security-Policy
« on March 25th, 2013, 05:41 PM »
Oh crap, my mistake

Code: (Find) [Select]
$request = wesql::query('
SELECT disabled_notifiers, email_notifiers, email_address, id_member
FROM {db_prefix}members
WHERE id_member IN ({array_int:member})
LIMIT {int:limit}',
array(
'member' => $members,
'limit' => count($members),
)
);
$members = array();
while ($row = wesql::fetch_assoc($request))
{
$members[$row['id_member']] = array(
'id' => $row['id_member'],
'disabled_notifiers' => explode(',', $row['disabled_notifiers']),
'email_notifiers' => json_decode($row['email_notifiers'], true),
'email' => $row['email_address'],
);
}
Code: (Replace) [Select]
$request = wesql::query('
SELECT data, email_address, id_member
FROM {db_prefix}members
WHERE id_member IN ({array_int:member})
LIMIT {int:limit}',
array(
'member' => $members,
'limit' => count($members),
)
);
$members = array();
while ($row = wesql::fetch_assoc($request))
{
$data = unserialize($row['data']);

$members[$row['id_member']] = array(
'id' => $row['id_member'],
'disabled_notifiers' => !empty($data['disabled_notifiers']) ? $data['disabled_notifiers'] : array(),
'email_notifiers' => !empty($data['email_notifiers']) ? $data['email_notifiers'] : array(),
'email' => $row['email_address'],
);
}
163
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 22nd, 2013, 04:05 PM »
Have fun! :P
Posted: March 22nd, 2013, 04:03 PM

@Nao: This is slightly unrelated but IMO the suggestion box can use some spicing up with avatar and membergroup info perhaps?
164
Off-topic / Re: Test
« on March 22nd, 2013, 11:52 AM »
@Dismal Shadow You can't notify yourself :P. See, the space works? See? SEE!
165
Plugins / [Plugin] Re: Notifications system (1.0)
« on March 22nd, 2013, 11:42 AM »
Use pure javascript? IMO textarea keyup callbacks should really use that, it is a world of a difference when it comes to speed.