Wedge

No, they will show up for anyone who can see warnings or issue warnings. Which will be members who can see their own warning history. So member without any extra tests is appropriate.I managed to miss a *much* bigger thing in r2060 than that. I would have spotted it when I actually got to testing the places where the style will be applied, which right now isn't anywhere.

Next time I'll just wait until I'm completely done before committing, I guess, and I'll go through it again with a fine tooth comb to make sure it's perfect.And as I said, most of this stuff went over my head. In any case I haven't decided if this is the final code yet or not, it might change and I really don't see any point in worrying about optimising until it's actually done. Pre-emptive optimisation can actually make it very hard to get anything done.

I also said before I'm having a real hard time trying to keep all this straight in my head. Not including a comma at this point in time is a... minor omission.

(12 files, 4KB)

@ This is really just the stuff I can commit right now, just so I can brain-dump a little bit. There's so much more stuff outstanding and waiting to be committed, but this at least lets me focus on what's left without it seeming like quite so much of a Wall. (I still have 36 files + 4 additions to commit.)

Revision: 2060
Author: arantor
Date: 15 April 2013 19:04:03
Message:
! Use the nice notice feature for a menu in the gallery area. Only noticed it accidentally on wedge.org (Aeva-Gallery.php)

! A minor change that doesn't affect anything else: whether the 'warning status' is shown in the profile fields area as a 'disabled' field or not. It won't be controlled from there, so it's safe to remove it. (ManageMemberOptions.php)

! Style changes that the infractions system will use. Won't affect anything currently in play to my knowledge. (index.css, index.member.css)

! Don't cache the menu. (Subs.php)

! Don't need to decrement the warning count - we don't do it that way any more. No effect on wedge.org, there are no users with warnings at present. (ScheduledTasks.php)

! We don't need these old permissions any more. Again, since we're not using this on wedge.org, bye bye. The bits where these permissions are checked is pending because there's a bunch of related stuff in those files that needs fixing up. (ManagePermissions.php, ManagePermissions and Reports language files)

! (Forgot this in the actual changelog) Preset some variables for later. (Class-System.php)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css

Already removed ;)

It only even comes into effect on level 2 and to be honest the load of the menu is really not that big a deal.

I did not, no. It's definitely screwy. I'm willing to bet there's a locking condition and/or caching.

What I'll do is extend the debug log to include where the call to loadLanguage was made from.

What I want to know is why there are two separate load requests to the index page. That's fairly clearly the problem: index is loaded, the injection applied, then it's loaded again overwriting the injection.

Now, I could find a later place in which to make the injection but I think what I'd rather do is expand the debugging to find out where the call is coming from.

Interesting. Sounds like a strange thing regarding caching. I've seen odd things with the caching lately.

(It's a plugin btw)