This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
916
Features / Re: jQuery Datepicker
« on April 25th, 2013, 11:08 PM »
Now I have a few more moments, there's a reason why the answer is no, and it's not what you think.
You can (quite legitimately) insert a date without a year into the birthday option. And both SMF and Wedge will quite happily accept it, so you can put in your birthday without having to give away your full age, perhaps so you can join in the birthday celebrations and appear on the calendar but keep your age private.
(Internally, they are converted to y-m-d with a year of 4, so leap year processing works too)
You can (quite legitimately) insert a date without a year into the birthday option. And both SMF and Wedge will quite happily accept it, so you can put in your birthday without having to give away your full age, perhaps so you can join in the birthday celebrations and appear on the calendar but keep your age private.
(Internally, they are converted to y-m-d with a year of 4, so leap year processing works too)
918
Features / Re: jQuery Datepicker
« on April 25th, 2013, 10:49 PM »
It's already in there.
jQuery UI is already implemented for the occasions it is needed and includes that.
jQuery UI is already implemented for the occasions it is needed and includes that.
919
Features / Re: New revs
« on April 25th, 2013, 08:48 PM »
(7 files, 7KB)
Revision: 2073
Author: arantor
Date: 25 April 2013 19:47:35
Message:
! Backend for saving and editing plugin language data. The caching part is in Load.php and as such I can't commit it just yet. (ManageLanguages.php)
! Who's Online should be a bit more consistent with the online list in terms of formatting. is-contact is still not rectified but that's a much larger battle anyway. (Who.template.php)
! Like action shouldn't actually be in the online log. (index.php)
! Clean up the current user's sanction state, simplifies checks later on. (Class-System.php)
! A few ban changes... namely moving a few things around for the admin search, but also to flush certain caches that will be updated in future. (ManageBans.php)
! Style changes. These are mostly likely to be final from my perspective, but could change. Not really worth optimising these *just* yet. Also reverts about 1/3 of r2072, namely all the changes that were conflicted in that file. (index.css, index.member.css)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/index.php
Revision: 2073
Author: arantor
Date: 25 April 2013 19:47:35
Message:
! Backend for saving and editing plugin language data. The caching part is in Load.php and as such I can't commit it just yet. (ManageLanguages.php)
! Who's Online should be a bit more consistent with the online list in terms of formatting. is-contact is still not rectified but that's a much larger battle anyway. (Who.template.php)
! Like action shouldn't actually be in the online log. (index.php)
! Clean up the current user's sanction state, simplifies checks later on. (Class-System.php)
! A few ban changes... namely moving a few things around for the admin search, but also to flush certain caches that will be updated in future. (ManageBans.php)
! Style changes. These are mostly likely to be final from my perspective, but could change. Not really worth optimising these *just* yet. Also reverts about 1/3 of r2072, namely all the changes that were conflicted in that file. (index.css, index.member.css)
----
Modified : /trunk/Sources/Class-System.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/index.php
920
Off-topic / Re: The hardships of being a perfectionist?
« on April 25th, 2013, 08:26 PM »But who am I telling this, your a qualified counceller.
Being a perfectionist doesn't make live easier.
I'm just going to take this opportunity to quote Robert Brown of Abney Park fame, he said this yesterday and it seems entirely true.
A beginning artist thinks, "I hope I can do this."
A novice artists thinks, "I hope I can find some one to look at/read/listen to my art."
A advanced artists think, "I hope I can do as good as my last piece, so people will keep looking at/reading/listening."
A very old artist thinks, "I hope I can (still) do this!"
921
The Pub / Re: Warning Message
« on April 25th, 2013, 08:23 PM »
OT: Yes, the new animation is fantastic. I haven't seen the code but I'm curious to know how the hell you pulled it off without a ton of code.
There's no real hurry on this part, I still need to build all the stuff to actually capture and save the data in the first place, it's purely a display thing, it'll be in $message['warning_msg'] for use in Msg.template.php.
There's no real hurry on this part, I still need to build all the stuff to actually capture and save the data in the first place, it's purely a display thing, it'll be in $message['warning_msg'] for use in Msg.template.php.
922
The Pub / Warning Message
« on April 25th, 2013, 05:52 PM »
@Nao, would *really* appreciate your insight on these.
Moderated messages get a warning at the top saying something to the effect of 'Hey, this message is moderated!' and some months back I added in a facility to (temporarily) display the reason for moderation underneath it. I've since made that more permanent, but that's not really what I want to talk about. I'm just giving context: we have somewhere to store metadata about a message.
I've attached a picture to show what this looks like. I'd note that there are two visual issues I've noticed that (AFAIK) aren't the result of what I have locally - .postbg.approve isn't exactly much different to straight .postbg (or .postbg2 as per the immediately preceding message) and there's not a gap between messages like there should be. (NB We pretty much inherited this one from what I remember.)
Now, I want to add something else to the mix: notice for a member being warned for a given message. XenForo has this and I think it'd be a useful facility to add.
My concern is where to put it or what it should look like. I've attached an example from XenForo. I want to do something similar but I don't know where to put it in the template exactly. Or what it should look like.
Moderated messages get a warning at the top saying something to the effect of 'Hey, this message is moderated!' and some months back I added in a facility to (temporarily) display the reason for moderation underneath it. I've since made that more permanent, but that's not really what I want to talk about. I'm just giving context: we have somewhere to store metadata about a message.
I've attached a picture to show what this looks like. I'd note that there are two visual issues I've noticed that (AFAIK) aren't the result of what I have locally - .postbg.approve isn't exactly much different to straight .postbg (or .postbg2 as per the immediately preceding message) and there's not a gap between messages like there should be. (NB We pretty much inherited this one from what I remember.)
Now, I want to add something else to the mix: notice for a member being warned for a given message. XenForo has this and I think it'd be a useful facility to add.
My concern is where to put it or what it should look like. I've attached an example from XenForo. I want to do something similar but I don't know where to put it in the template exactly. Or what it should look like.
923
Features / Re: New revs
« on April 25th, 2013, 05:07 PM »
(15 files, 7KB)
Revision: 2070
Author: arantor
Date: 25 April 2013 16:05:22
Message:
@ Things I can commit without breaking anything else. And for the first time since I started on this hellish journey into the infractions/warnings/post moderation/post ban overhaul, conflicts. Two of them!
! English-UK fixes. (Help.english-uk.php, ManageMedia.english-uk.php, ManageMembers.english-uk.php, Themes.english-uk.php)
! Some otherwise unrelated changes for the benefit of the admin search. Note that the magic underlying logic is elsewhere and cannot be committed at this time due to other changes in the same file. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageRegistration.php, ManageSearch.php, ManageSearchEngines.php, ManageSmileys.php, Admin.template.php)
! Use the we_ wrapper function for json_encode. (Admin.template.php)
! Language files with *just* new strings, for translation purposes. (ManageBoards.english.php, ManageMembers.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english-uk.php
Revision: 2070
Author: arantor
Date: 25 April 2013 16:05:22
Message:
@ Things I can commit without breaking anything else. And for the first time since I started on this hellish journey into the infractions/warnings/post moderation/post ban overhaul, conflicts. Two of them!
! English-UK fixes. (Help.english-uk.php, ManageMedia.english-uk.php, ManageMembers.english-uk.php, Themes.english-uk.php)
! Some otherwise unrelated changes for the benefit of the admin search. Note that the magic underlying logic is elsewhere and cannot be committed at this time due to other changes in the same file. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageRegistration.php, ManageSearch.php, ManageSearchEngines.php, ManageSmileys.php, Admin.template.php)
! Use the we_ wrapper function for json_encode. (Admin.template.php)
! Language files with *just* new strings, for translation purposes. (ManageBoards.english.php, ManageMembers.english.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english-uk.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english-uk.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/Themes.english-uk.php
924
Off-topic / Re: The harships of being a perfectionist?
« on April 25th, 2013, 04:43 PM »I don't see either in what way it's a clue as to your situation...
What matters is that it's caught, isn't it..? I was mainly thinking, that if it works it's only due to Wess being relatively cool with commas, but other than that I'm unsure whether you committed this as a last-minute change while documenting the changelog
or if you simply didn't catch it at dev time, and 'it worked', so you didn't have to bother...
But I'd draw a parallel to the one fixed in r2052 in Class-CSS.php, the main reason I even noticed is because you mentioned it on the forum. Everything you said to me about my missing a comma in the CSS files applies to that typo. Only I thought it simpler not to mention it (but would have fixed it in my next commit quietly)
Also, you know me better than that. 'Criticizing' is a bit of harsh to qualify my comments... No?
It does seem like a no-brainer to me... We both respect each other (at least I hope so, because that would be a huge waste of three years for one of us if it wasn't the case, right..?), and we work in different areas because we do what we're best at (and, for an unpaid job, what we enjoy the most really), and Wedge is a huge enough codebase to justify working on different areas, anyway... We can't do everything, or at least not everything right...
The stuff you do is great, and don't let me or anyone else try and tell you otherwise, but there is a certain mindset I'm noticing: developing in a sort of bubble.
For example, the repeated points about PURLs being broken - it's never been investigated because from your perspective it works just fine. But I'm only too aware that for a large number of installations it's going to be absolutely unusable - all because it doesn't work properly when in a subdirectory. I don't know the code well enough to explore it, but I just feel like at some point I'll have to.
I want to ensure that the last 3 years haven't been a colossal waste of both our time. And to me, I need to make sure that Wedge has the facilities it needs to compete. It needs to solve all the issues I've seen with SMF, and be the platform it was always destined to be: one of pure fucking awesome. More awesome than rainbow-coloured unicorn poop.
The problem is, I kind of feel that we're not entirely building that. I feel like you're building what makes you happy, which is a good thing, but that it's at a tangent to what Wedge needs sometimes. Diving down the rabbit hole with Wess or JSE, these are great things and make life easier in the long run, but to burn amazing amounts of time on things few people will ever really notice or use seems somewhat sad :(
There is a more important point, though. I actually don't like using Wess, I've realised. Things seem to change a little too often, meaning that what I should have been doing a few weeks ago is not how it should necessarily be done any more, and as I said you could explain it but I suspect it'd go over my head.
When I'm writing CSS stuff, it takes me typically twice as long as just using raw CSS for the simple reason that I write it, and it either doesn't work, or doesn't work as expected. I find it a chore to work with, but that's because I don't use it enough. Trouble is, every time I do use it, I write inefficient code so as I said, I might as well save us both the time and let you write it efficiently in the first place.
I don't remember that issue...
Sort of like so:
add_css('
.m_chess { float: left; width: 16px; height: 16px; padding: 0; background: url("' . $context['plugins_url']['Arantor:Chess'] . '/img/chess_small.png") no-repeat 0 0; margin:4px 2px 0 2px; }');Though that's probably wrong. But it illustrates a number of the issues in one line.
Firstly: the fact a mod has to do it at all using its *own* CSS, every page where it wants to do this (because there's no way to extend the dynamic function in question)
Secondly: there's nothing to hook on to style-wise. It's not like .m_chess will be able to extend a menu_items class in this context to have the float, size, background-repeat or margin preset for it.
Thirdly: if a menu decides to do *anything* with the main menu that is in any way different to this, the plugin will now be broken because it can't inherit from the parent properly. Weglas demonstrated this by having odd artefacts to the sides of the menu item. And a skin can't anticipate what menu items it's going to have to deal with.
Here's the kicker: all of this could be fudged in some fashion as a contrivance through the plugin manager (either manually or automatically) issuing a clear-CSS-cache and the dynamic function having some kind of hook, but honestly that's not the way I want to go here. A full on menu editor would be much more suitable.
If you want to be able to add them from plugin CSS, then I can certainly move my button classes to common.css so that they benefit from them, but it's not that big a deal really, as they can simply re-use the same CSS, I'd say..? They can even do dynamic functions, at least that's what it was built to do...
It's why even with all the changes I'd made so far to the calendar, I didn't even bother re-adding a menu icon for it.
So, yes, I've skipped a lot of topics, and I kept doing so, because you told me it was okay, and that you'd tell me whenever you'd need my opinion (by PM or whatever). Recently, we added notifications for that, but I'm not 'done' with them yet, and I'm not even used to checking it constantly... But I've planned to them to be a life-changer for me, regarding how it influences my way to follow the forum, I'd say...
Yes, you can blame me for expecting more of you in that respect than I'm doing myself. Why so..? Because to me, it seems like you're able to do so many different things at the same time, when I'm struggling to just keep up with balancing between real life, and Wedge life.
That and the fact that I have no real life to speak of outside of what I do in terms of code. I normally go out twice a week, once to see my mum (and visit my grandmother in the care home) and once to do my weekly shopping. If it weren't for those two things I wouldn't go outside the house. These days I'm frequently up till 5am coding. (It used to be 2am)
This is how I'm able to do it: because I have pro-grade multi-tasking skills and because I have no-one else in my life. This is not something to emulate. It doesn't help that yesterday while out at my mother's, I was reconfiguring their new router and discussing my sister's love life dramas >_< At the same time.
But where did I criticize your work in a way that came to upset you that much...?
If you're so uncomfortable with this, are you sure you ever want to go public..?
I'm uncomfortable because it's just seemed like lately if a commit isn't *perfect*, it doesn't just get reviewed, it gets jumped on. The last few features I've done have been that way a bit... even if I make a note in the commit note about something not being finished.
You did get your Zend certification, after all, something I'm not sure I'm even capable of getting (hence why I'm not even looking into trying)
In your particular case, I'd suggest if you did want to go for it, you'd need to pick up on Iterators and things like ArrayAccess. Probably 50% of what would be on the exam should be a no-brainer for you. It's only that bit between 50% and the pass grade, and really I do think you're up to it. It's hard, sure, but it wouldn't be worth anything if it wasn't.
You always have the last word, because you have things to bring to the table, and you know better.
And I'm just surprised to see that, in contrast with your immensely wider knowledge than any of us in here, you're still uncomfortable with details that people are giving you in response to your commits.
It's also a lot of frustration on my part for feeling like I should just be able to kick this out of the park and not break a sweat from it - I'm frustrated with my own perception of self-weakness.
To give you an image -- it's as if you'd started painting the Mona Lisa, were close to finishing it, and then suddenly decided to throw it away because your pigment assistant said he would have chosen a dark grey over your light black to represent this tree in the shadows.
From my perspective, it's more like I'd started painting the Mona Lisa and Salai[2] told me that I'd painted it wrong even though I'd muttered it was a word in progress and likely to change again shortly but that I'd done it something to work off for now. And I'm frustrated that Salai didn't hear me but I'm frustrated at myself even more for not having done it perfectly the first time, as well as being frustrated at myself for not having finished it already and being frustrated at myself because I have too much to do and I'm not sure I can cope with it all. Then I get cross at myself when I shout at Salai. And the circle continues.
No, Pete, I won't fight with you. If you want me to apologize for hurting your feelings, even if I don't understand where or when I hurt them, then I'll apologize. But it still won't stop me from making further comments in the future about your work, not because I'm dissatisfied with it, but simply because I'm eager to add a stone to your church, that's all.
We're unpaid, and we're hurting our health working like crazy on these things. There's definitely a small hint of pride in what we both do with our lives, I guess...
This was an unscheduled service interruption. Normal service will be resumed.
| 1. | It's ironic. I actually hold a qualification in counselling. You'd think I'd be better able to handle this sort of thing. But I can't actually go and see a counsellor because I know all the tricks, all the moves so to speak. The shields go up and the waves of small fighter craft just go splat, rather than firing off proton torpedoes. |
| 2. | Yes, I've been playing Assassin's Creed. Deal with it, or I'll send Ezio or maybe Connor round to... have a word. :P |
925
Bug reports / Re: Attachment Upload Bug
« on April 25th, 2013, 04:37 PM »
Hmm, that could be either a flaw in the underlying logic or in the multi-attach plugin on top (yes, *that*'s a plugin, and no, no files were harmed in the operation of that plugin)
926
Archived fixes / Re: 'Like' Disappears When Clicked
« on April 25th, 2013, 03:50 PM »
Yay for regression bugs, confirmed.
927
Bug reports / Re: Posting / New Posts
« on April 25th, 2013, 03:42 PM »
I dunno. MyISAM is full table locking. Given that it's not consistently occurring, means it's not permanently broken. So the code must be working some of the time. Both kinds of posting go through the same end code, so it's not that either.
Only thing I can think of is that it is down to locking at this stage. Try converting it on its own to InnoDB and see what happens.
Only thing I can think of is that it is down to locking at this stage. Try converting it on its own to InnoDB and see what happens.
928
Features / Re: Miscellaneous/WIP screenshots
« on April 25th, 2013, 05:36 AM »
Another minor enhancement, though this one requires slightly wider changes than what I've done so far in places, so it won't be everywhere at once.
Essentially when you do a search in the admin panel it will now give you the area title that a setting is in, if appropriate. The link still takes you directly to the setting, but this way you can actually find it and have some idea where it is in the scheme of things. This is useful because there are a few settings that have duplicates (legitimately, because they directly have consequences in two separate areas)
I have not shown any in this screenshot but I know of one for certain already and I'm likely to have a few more yet.
Essentially when you do a search in the admin panel it will now give you the area title that a setting is in, if appropriate. The link still takes you directly to the setting, but this way you can actually find it and have some idea where it is in the scheme of things. This is useful because there are a few settings that have duplicates (legitimately, because they directly have consequences in two separate areas)
I have not shown any in this screenshot but I know of one for certain already and I'm likely to have a few more yet.
929
Off-topic / Re : The harships of being a perfectionist?
« on April 25th, 2013, 04:26 AM »
I'd also add, the CSS file modifications that I made, do not waste time optimising them. I've already gutted them and replaced them with something else. I haven't benchmarked the bytes difference but I did move it out of index.css and into index.member.css for you.
Of course, I won't be committing until I'm done, wouldn't want to waste any of your time on WIP code now, would I?
Of course, I won't be committing until I'm done, wouldn't want to waste any of your time on WIP code now, would I?
930
Features / Re: Miscellaneous/WIP screenshots
« on April 24th, 2013, 10:19 PM »
Let's say, purely hypothetically of course, that you could put banned users into a group (and replace their primary group with this new group while banned)
Let's say, also purely hypothetically that you want to add some more formatting options to that group.
All purely hypothetical of course. Except for the attached which is not a mockup but actual proof of implementation. :niark:
(As in, you can create a Banned group, and use this to format it so you don't need 'Slashout Banned Members' if you want to do that.)
Actually, it's two mods on the list that aren't needed any more. Still hundreds to go though.[1]
Let's say, also purely hypothetically that you want to add some more formatting options to that group.
All purely hypothetical of course. Except for the attached which is not a mockup but actual proof of implementation. :niark:
* Arantor strikes another mod off the list that isn't needed any more.
Posted: April 24th, 2013, 10:14 PM
(As in, you can create a Banned group, and use this to format it so you don't need 'Slashout Banned Members' if you want to do that.)
Posted: April 24th, 2013, 10:16 PM
Actually, it's two mods on the list that aren't needed any more. Still hundreds to go though.[1]
| 1. | Yes, I have a list of every SMF mod, complete with the state of whether Wedge has it built in, whether Wedge should get a similar mod (or whether it's already been made), or not. There are still 297 'Yes', 526 'Maybe', 103 'to be core', 181 'already core'. Though I add my own todo as 'to be core' so it's not entirely accurate. |