Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8356
Features / Re: New revs
« on September 24th, 2010, 11:36 PM »
Quote
So, you're into my last modified fix? I thought you weren't
I don't recall ever discussing it but the idea makes a lot of sense :)
Quote
Oh, that BB scene was priceless.
The whole film's pretty good. Note the cameo from Steven Spielburg (himself) as the tax assessor guy right at the end.
8357
Off-topic / Re: Top funny source code comments
« on September 24th, 2010, 07:56 PM »
Yeah, I've seen The Oatmeal before. Blame Asgard for that.

In the meantime, http://innovatenotimitate.com/ if you want to read what else happens when I want to just rattle on a bit. ;)
8358
Features / Re: New revs
« on September 24th, 2010, 07:52 PM »
Quote
Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Awesome, thank you :)
Quote
Changed menu hover color. If you can spot a difference, you're holy.
Do you see the light?!

Jesus H. Christ, I see the light! The band, Elwood, the band!

(Actually no, I haven't looked yet, but if you're saying that, odds are I wouldn't be able to tell the difference)
8359
Off-topic / Re: Top funny source code comments
« on September 24th, 2010, 07:15 PM »
Pretty much everything on The Oatmeal is awesome :D
8360
Features / Re: New revs
« on September 24th, 2010, 12:17 PM »
OK, I'm going to keep this one short and sweet.

Part of the layout issues SMF has is because of tag soup - so many floated things, so many divs and so on, that you so much as breathe on some bits and it falls apart on you.

There isn't really a best solution as a result - only a collection of least-worst alternatives, and none of them are particularly compelling. What you've got there is probably the least worst of the least worst solutions, without doing something drastic like ripping it all out and using tables everywhere.
8361
Features / Re: New revs
« on September 23rd, 2010, 01:13 PM »
Well, I was curious to see what documentation he'd done.
Quote
string function smf_db_get_version()
      - get the version number.
No shit! Still one line of description is better than none.
Quote
void QuickInTopicModeration()
      - in-topic quick moderation.
Or not, maybe. Literally taking the function name and re-ordering it to make a different phrase sort of isn't the plan.

And when you have a load of functions in one file, generally it's best to document everything, or at least put placeholders in (not like Subs-Database.php where only the first function has a description)


The security change... hmm, why does that look familiar? I guess he listened to what I proposed :)
8362
Features / Re: New revs
« on September 23rd, 2010, 04:33 AM »
Quote
This is an incomplete report, and it's been fixed in an incomplete manner
Status normal, captain.
Quote
I never see more than one icon per header
That's because it never happens. Many headings don't even have one. That said I'm not sure off the top of my head if cat_bg that is collapsible with a left icon, might not use icon for the upshrink (if that makes sense)? Either way, those cases will be pretty few and far between, and can be fixed if we find them - I'd say you're completely good to clear yet more cruft.
Posted: September 22nd, 2010, 11:45 PM

Revision: 132
Author: arantor
Date: 23:32:18, 22 September 2010
Message:
! Fix for editor generating extra divs when using custom div mode. (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php

Posted: September 23rd, 2010, 12:33 AM

Revision: 133
Author: arantor
Date: 23:35:04, 22 September 2010
Message:
! Fix error in SQL installer, with forgotten parameter (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql


This one was stupid. I missed the 4th parameter in the insert query.
Posted: September 23rd, 2010, 12:35 AM

Revision: 134
Author: arantor
Date: 03:32:35, 23 September 2010
Message:
+ Code documentation (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php
8363
Features / Re: New revs
« on September 22nd, 2010, 10:08 PM »
Quote from Nao/Gilles on September 22nd, 2010, 10:05 PM
Indeed! At last, you found a place to express the caffeine-fuelled creativity of your talkativeness. :eheh:
Fixed that for you :P But yes, yes I did.
8364
Features / Re: New revs
« on September 22nd, 2010, 07:45 PM »
Quote
Norv has started documenting the files! Well, by "documenting", I mean "replacing the "// !!!" with single-line descriptions of the functions
I wouldn't really call that documentation. I would, however, call the awesomeness in Post.php documentation :P
8365
Features / Re: New revs
« on September 21st, 2010, 03:05 AM »
Revision: 124
Author: arantor
Date: 01:50:45, 21 September 2010
Message:
- Remove the help stuff:
 - Remove the action=help itself (index.php, Help.php)
 - Remove the menu item (Subs.php)
 - Remove the no-longer-used templates (Help.template.php)
 - Remove the no-longer-used text strings (Who.english.php, Manual.english.php removal entirely)
 - Remove semantic links to the page (index.template.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/index.template.php
Deleted : /trunk/Themes/default/languages/Manual.english.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php


Revision: 125
Author: arantor
Date: 01:53:19, 21 September 2010
Message:
! Revert commit of install.php, did not intend to commit local use changes.
----
Modified : /trunk/other/install.php



I didn't actually mean to commit install.php in r124, because that's my modified version to handle the UTF-8 changes... so I've reverted it. But really, it shouldn't be a problem (and you can see what I did in r124) - the sole idea was to bump the minimum MySQL version to 4.1.0 and just make it install without complaining such that if UTF-8 was ticked (and it was by default), that it would install it. (Right now, it really doesn't work properly, but it's a non issue for testing purposes)
Posted: September 21st, 2010, 02:55 AM

Revision: 126
Author: arantor
Date: 02:05:25, 21 September 2010
Message:
+ Added Yandex to the list of supported search engines (install_2-0.sql)
----
Modified : /trunk/other/install_2-0.sql
8366
Off-topic / Re: 1kb Grid
« on September 20th, 2010, 11:10 PM »
There is an argument for semanticising the layout, but it's not a strong one. This 'tableless' brouhaha is mostly that, because people apply the notion that tableless means not using tables when it's actually inappropriate to do so.

I'm of the school of 'whatever works'. And if themers want to go the whole tableless route, fine, but don't come crying when the core layout isn't totally tableless because that is actually insane.
8367
Off-topic / Re: Top funny source code comments
« on September 20th, 2010, 11:08 PM »
Jeez, I know I'm not a Hollywood actor but I'm sure my face isn't that funny :P

* Arantor is a self-proclaimed acolyte of the self-depreciating British witticism.
8368
Features / Re: New revs
« on September 20th, 2010, 11:06 PM »
Then as far as I'm concerned your solution is better and works more in a way that works for us :) Yay for diverging routes!
8369
Off-topic / Re: 1kb Grid
« on September 20th, 2010, 10:58 PM »
Interesting, thanks for sharing :)
8370
Features / Re: New revs
« on September 20th, 2010, 10:37 PM »
Revision: 123
Author: arantor
Date: 21:31:00, 20 September 2010
Message:
+ Code documentation and a half (Post.php)
----
Modified : /trunk/Sources/Post.php


This added 130 new lines of documentation, and replaced the 60 or so incomplete lines there anyway...


@ Nao, I looked at bug 4446, I'm not sure what was actually applied - but is there a better fix than they've discussed? (CSS is not my forte) Or at least, one that is better for us?