Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8341
Features / Re: New revs
« on September 28th, 2010, 11:44 AM »
Quote
That's probably because we don't take code for granted, even our own.
I try not to, because I try to be mindful of the consequences of changing things.
Quote
Err, from what you're saying, your fix was already in your mod, then?
You've lost me here...
I initially thought I missed it, then I edited to say I hadn't, because of the unset items - which were in the original mod too. I missed your edit, it seems.
Quote
So, in the end you're leaving the perms in, instead of using the ban perms?
Yes... I see I wasn't clear with what I meant. I set it up so that users who would have ban permissions, would also gain by default the view-all-IPs permission in the templates and in installation, since if you have the ability to ban it follows that you probably should have view all IPs too.

But I didn't want to make them tied together; I can think of cases where users might want to give out some but not the others.

There's a thought, actually... ban user does also use the IP in the ban dialogue. I don't think I hit that one.
Quote
It still implies that can_view_ip_own doesn't exist, and that no one but the admin can have can_view_ip_any...
I guess it's a WIP for now
Yeah, I think so. I've found being a programmer makes me very good at some things - breaking down tasks and so on, but lousy in others - trying to communicate a complex concept to non-technical users (like with the help string) will tend to break down.
8342
Features / Re: New revs
« on September 28th, 2010, 10:17 AM »
Quote
You mean the original mod had the hole
Sure did, and no-one ever called me out on it, either and the original mod was written back in December 2009...
Quote
Pwned! Didn't use insertQuoteFast
You can't use it to insert only parts of posts unless you modified it here...


I'll take care of the above momentarily.

:edit: Actually, I *did* take care of the permission checking for searching. Basically, the unset items are all to do with removing it from the list of things it knows about for searching/displaying within the manage area.
Posted: September 28th, 2010, 09:56 AM

Revision: 166
Author: arantor
Date: 09:16:59, 28 September 2010
Message:
! Ensure view-IP permissions are applied during install (install_2-0.sql)
! Add view-IP permissions to the internal templates (ManagePermissions.english.php)
& Move 'Logged' to Modlog (index.english.php, Modlog.english.php)
& Rephrase view-IP permission name and user help (ManagePermissions.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql
8343
Features / Re: New revs
« on September 28th, 2010, 09:50 AM »
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Quote
Lazy ass
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
The only original code I committed last night was moving the icon :P as well as spacing fixes. But yeah, the language strings could be improved.
Quote
Dunno what's best.
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Quote
$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
It could be moved to the modlog lang file?
Quote
Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess
Yes it is. Something I didn't remember in the original mod...
8344
Features / Re: New revs
« on September 28th, 2010, 09:41 AM »
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Quote
'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Quote
Is the view own IP permission set by default? I don't think it is?
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
8345
Features / Re: New revs
« on September 28th, 2010, 03:20 AM »
Revision: 163
Author: arantor
Date: 02:19:54, 28 September 2010
Message:
! Moved IP icon and made it tooltip of image (Display.template.php)
+ Made viewing own/any IP address a permission, and ensured it is managed in all the appropriate places (Display.php, ManageMembers.php, ManageMembers.template.php, ManagePermissions.php, ManagePermissions.english.php, Modlog.php, Profile-View.php, Who.php)
- Removed old help tooltip for admin IP viewing (Help.english.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
8346
Off-topic / Re: iHate Apple
« on September 28th, 2010, 03:05 AM »
The trouble is, the devs won't develop for it, because there's also little demand (even putting aside the technical issues), and there's no demand because there's no apps for it... yay for circular logic.

Apps should be relatively consistent on Android however, they all use a form of Java, so it should be fairly consistent, but it won't have the consistency and user experience of Apple iPhone.

(As much as I dislike their practices, I can't deny Apple are giving users what they want.)
8347
Features / Re: New revs
« on September 27th, 2010, 10:56 PM »
I saw that hack, I'm still not convinced it would actually work entirely as intended either.
Quote
For crying out loud.
Probably not the best line to say to a Meat Loaf fan...


Meat Loaf - For Crying Out Loud

"For crying out loud, you know I love you...."
8348
Features / Re: New revs
« on September 27th, 2010, 10:47 PM »
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41

It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
Quote
Yay! I thought we hardly had anything left to strip at that point......
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
8349
Features / Re: New revs
« on September 27th, 2010, 10:16 PM »
Revision: 160
Author: arantor
Date: 19:30:42, 27 September 2010
Message:
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
----
Modified : /trunk/Themes/default/scripts/editor.js


I'll take a look at revs 158 and 159 shortly, I just wanted to fix that outstanding issue because it was bugging me. Looking at the code in replacetext from whence I borrowed, IE 6 (and 7?) may not support the change, but IE 8 and Chrome do, and since it's labelled in replacetext as 'Mozilla', I'm assuming FF does, though I haven't tested.
Posted: September 27th, 2010, 08:32 PM

Revision: 161
Author: arantor
Date: 20:51:55, 27 September 2010
Message:
+ Code documentation (ManageRegistration.php)
----
Modified : /trunk/Sources/ManageRegistration.php

Posted: September 27th, 2010, 09:52 PM

Revision: 162
Author: arantor
Date: 21:15:53, 27 September 2010
Message:
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
----
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php
8350
Off-topic / Re: iHate Apple
« on September 27th, 2010, 04:19 PM »
* Arantor has ribbed Asgard more than once about love of fruity goodness :P

I'm impressed by the build quality of Apple gear, as a technologist, and I can't deny that for the bulk of their users, it works for them. I personally would feel stifled a little with the mentality they put into things, though I gather it's gotten a bit better over time (it is a long old IT joke that Microsoft asks you where you want to go today and Apple tells you where it wants you to go)

Of the Apple devices though the one I'm most interested in is the iPad. The only downsides for me are the price (seriously, I do not want to pay £429 for one when for that price I can get a powerful desktop or laptop) and the size; it just feels too small for me to use comfortably.

The other thing is that I'm not the traveller I used to be, I don't have a commute at the moment so I have no need of *mobile* devices.
8351
Features / Re: New revs
« on September 27th, 2010, 01:30 AM »
Revision: 155
Author: arantor
Date: 23:00:41, 26 September 2010
Message:
! Fixed up outstanding issue with smiley set (install_2-0.sql, Install.english.php)
- Removed remaining topic icon fluff (I think I got it all)
 - Class determination function (Subs.php)
 - Display in the topic view (Display.php, Display.template.php)
 - Fix for alignment of author/title without icon (index.css)
 - Cleaning up topic class in message index (MessageIndex.php, MessageIndex.template.php)
 - And unread/replies (Recent.php, Recent.template.php)
 - And search (Search.php)
 - And the admin panel (ManagePosts.php)
 - And all language strings (FixLanguage.php, Admin.english.php, Help.english.php, index.english.php)
 - And pruning the images that are no longer used (lots, there's still a couple actually used, but 45 gone bye-bye)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/FixLanguage.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Deleted : /trunk/Themes/default/images/topic/hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_sticky.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql


Yeah, this was an exciting commit ;)
Posted: September 27th, 2010, 12:01 AM

Revision: 156
Author: arantor
Date: 23:06:56, 26 September 2010
Message:
! Converted outstanding .icon1 and .icon2 to .icon (index.css, MessageIndex.template.php, Recent.template.php)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css

Posted: September 27th, 2010, 12:07 AM

Revision: 157
Author: arantor
Date: 00:27:57, 27 September 2010
Message:
! Misc typo fixes (smfinfo.php, Subs.php)
+ Error counter log (index.php, Errors.php, ManageErrors.php, Subs.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php
Modified : /trunk/other/tools/smfinfo.php


In case it's not clear what's going on (and it is a little convoluted, if I'm honest) - the logic behind it is that if an error occurs during execution, it adds to a counter, then if there were errors during runtime, save that in $modSettings at the end of runtime. It's far lighter to do that than it is to query it (or query then cache it) every page load, and really if we're honest, the idea is to encourage admins to resolve errors sooner rather than later.
8352
Features / Re: New revs
« on September 26th, 2010, 07:51 PM »
Revision: 152
Author: arantor
Date: 18:49:29, 26 September 2010
Message:
! Rearranging the order of Core Features - a feature whose title begins with A should be before something that begins with C. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php


...even if it was originally called 'Custom Profile Fields'... it's now called Advanced Profile Fields. And everything else is in... oh damn. I meant to move search engines too.
Posted: September 26th, 2010, 07:51 PM

Revision: 153
Author: arantor
Date: 18:51:41, 26 September 2010
Message:
! Also move search engines to be in the right alphabetic place (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
8353
Features / Re: New revs
« on September 26th, 2010, 06:03 PM »
Revision: 147
Author: arantor
Date: 05:03:01, 26 September 2010
Message:
+ First part of the naughty bot prevention code (plenty more to come though)
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php


This adds the whitelisting stuff. Note the use of a constant; this is for use later throughout in a way that can't be tampered with.
Posted: September 26th, 2010, 06:04 AM

Revision: 148
Author: arantor
Date: 14:04:47, 26 September 2010
Message:
! Fix user menu inability to relate to message id (use %msg% in the URL for menu items) (Display.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/scripts/topic.js

Posted: September 26th, 2010, 03:05 PM

Revision: 149
Author: arantor
Date: 15:00:07, 26 September 2010
Message:
! Remove 'send email' from user menu, added 'report to moderator' (Display.php)
- Removed unnecessary passing of current topic page into the send-report code, it wasn't being used for anything (Display.php, Display.template.php, SendTopic.php, SendTopic.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/SendTopic.template.php

Posted: September 26th, 2010, 04:00 PM

Revision: 150
Author: arantor
Date: 16:32:57, 26 September 2010
Message:
! Removed topic class icon column from message index, unread/replies page (MessageIndex.template.php, Recent.template.php)
! Added icon to the subject area (MessageIndex.template.php, Recent.template.php, index.css, 4 new images)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/icons/quick_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_my.gif

Just a few notes.

1. icon1 class has not been removed. I don't *think* it's in use anywhere else.
2. Had to add 4 new images since the lock/stick/both icon in the subject column is a background image. Still, we can if we choose, proceed to ditch some of the images in the topic folder now.
3. I haven't touched the message index footer yet, not sure what to do with that exactly.
4. Topic class is currently still being determined both in the message index and in the topic itself (it's the icon in the top left corner of the topic). Since we're not using it in the message index, we can remove that (I'll do that later if you want, I was just concerned about getting it implemented as-is), but not sure about removing it from the topic yet. Makes little odds to me, I don't even notice it most (any?) of the time.
Posted: September 26th, 2010, 05:36 PM

Revision: 151
Author: arantor
Date: 17:03:07, 26 September 2010
Message:
+ Added new permissions for editing website and signature (independently of any other profile settings) (ManagePermissions.english.php, ManagePermissions.php)
+ Added enforcement of permissions (Profile-Modify.php)
+ Added permissions to edit own website/own signature to regular members and global moderators by default (install_2-0.sql)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install_2-0.sql
8354
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on September 26th, 2010, 01:22 AM »
As mentioned above, the ability to select a bunch of text and have just that appear in the quote tag.

Multi-posting is fine - just I think that's slightly deviating from the route you've taken here?
8355
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on September 25th, 2010, 05:17 PM »
Bumpity.

Do we want to consider building in multi-quoting? It's popular enough on other forum packages, and if enhanced to the point it also covers partial quoting... it could be awesome.