Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8326
Features / Re: New revs
« on October 8th, 2010, 09:56 AM »
Modularity is awesome :)

Now, we could trivially have it so that the info centre can be disabled cleanly without resorting to putting changes in the template... but that's only the beginning.
8327
Features / Re: New revs
« on October 8th, 2010, 01:29 AM »
Revision: 185
Author: arantor
Date: 00:28:20, 08 October 2010
Message:
! Make $context['sub_template'] accept an array as a list of subtemplates to call (Subs.php)
! Separate the board index templates as they should have been originally (BoardIndex.php, BoardIndex.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
8328
Features / Re: New revs
« on October 6th, 2010, 09:47 PM »
There's a lot of fields that fall into the same category of being tinyint when they logically should be bool.

Trouble is, even on more modern MySQL I'm not sure it's any faster and in some cases it will be slower as it messes round fixing up part bytes (especially in fields with variable width columns that implicitly force everything else as bytes).

There's also a lot of fields whose use is never stated anywhere... yay for undocumented schemas.
Posted: October 6th, 2010, 08:45 PM

OK, took a look at script.js.

All the stuff with == null vs ! should work, and seems to.

There's only two things I'm wary of.

Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value = doForm.passwrd.value.replace(/./g, '*');

Surely that should be:
Code: [Select]
doForm.passwrd.value = is_ff != -1 ? '' : doForm.passwrd.value.replace(/./g, '*');


And also,
Code: [Select]
bInit = typeof(bInit) == 'undefined' ? false : true;

vs
Code: [Select]
bInit = bInit ? true : false;

Seems a bit redundant logically, not to mention inaccurate.

I'd suggest:
Code: [Select]
bInit = typeof(bInit) != 'undefined';
and just be done with it.
Posted: October 6th, 2010, 09:37 PM

Revision: 182
Author: arantor
Date: 20:46:32, 06 October 2010
Message:
! Missed a closedir that should have been removed before (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
8329
Off-topic / Re: Two minutes of warmth in this cruel world
« on October 6th, 2010, 08:41 PM »
Yes, that seems like good news to me :D Been waiting for that... now what's my Steam password again...
8330
Features / Re: New revs
« on October 6th, 2010, 08:28 PM »
Quote
Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
Are you planning to change all the other things that are similarly bools in nature? There is not a single bool amongst SMF's tables, never has been, and in the case of older MySQL versions it is neither smaller, nor faster to do so.

Will take a look at script.js shortly.
8331
Features / Re: New revs
« on October 3rd, 2010, 09:37 PM »
scandir was a smaller thing, since as you remarked yourself it was only used in a couple of dozen places; a quick search on opendir showed it wouldn't be a big thing to change - and as you can see from the changelog, it wasn't.


Revision: 180
Author: arantor
Date: 20:35:56, 03 October 2010
Message:
- Remove WAP, imode support (index.php, BoardIndex.php, Display.php, ManageBans.php, PersonalMessage.php, Profile.php, Subs-Auth.php, Subs.php, Wireless.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/index.php
8332
Features / Re: New revs
« on October 3rd, 2010, 07:51 PM »
Yeah, I did. Basically I knew my time would be fragmented today and so doing anything big probably wasn't worth the effort, so I figured I'd look at smaller stuff, and besides, it's more green on the tracker (and I like green) :)
8333
Features / Re: New revs
« on October 3rd, 2010, 06:30 PM »
Revision: 177
Author: arantor
Date: 14:35:55, 03 October 2010
Message:
+ Provide option for redirect boards opening in new window/tab
 + New column, redirect_newtab added to boards table (install_2-0.sql)
 + New admin option for setting it (ManageBoards.english.php, ManageBoards.php, ManageBoards.template.php, Subs-BoardIndex.php, Subs-Boards.php)
 + Displaying changes (BoardIndex.template.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install_2-0.sql

Posted: October 3rd, 2010, 03:37 PM

Revision: 178
Author: arantor
Date: 14:53:21, 03 October 2010
Message:
! Render the time in smaller font on WAP2 (cannot apply to iMode or WAP as neither supports variable height fonts) (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php

Posted: October 3rd, 2010, 03:53 PM

Revision: 179
Author: arantor
Date: 17:30:12, 03 October 2010
Message:
! Convert opendir/readdir/closedir to scandir as appropriate (upgrade.php, ManageAttachments.php, ManagePaid.php, ManageSearch.php, PackageGet.php, Packages.php, Post.php, Subs-Package.php, Subs-Post.php, Subs.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/upgrade.php
8334
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on October 3rd, 2010, 12:54 PM »
Quote
using JS to select the text?
Sure, there's functionality in the browsers to achieve this.
8335
Features / Re: New revs
« on October 2nd, 2010, 04:14 AM »
Well, AFAIK, doesn't YUI make use of things like Flash? Sure it's doable but I'd hate to make Flash an inherent dependency even for something just like uploading files.

I also wasn't aware that HTML5 contained anything that let you have access to anything useful like the file size, especially since the major browsers can't even agree what the value of a <input type="file"> should be - some browsers only return the basename of the file, some make the full path accessible.
Quote
Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:
:P I just wanted to get it committed, didn't feel up to making it work properly seeing how I cut the number of changes vs the SimpleDesk implementation in half and only made it basically a UI change as opposed to UI+logic change that it so nearly was.
Quote
Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.
It's the right term; trying to find that common theme for everyone is tricky.
8336
Features / Re: New revs
« on October 2nd, 2010, 12:52 AM »
I'll look at the new style when I'm finished with the attachments UI stuff I've been meaning to do (this ticket)
Posted: October 1st, 2010, 10:40 PM

Revision: 174
Author: arantor
Date: 23:47:48, 01 October 2010
Message:
+ Updated attachment UI. Sort of broken in IE right now though :( (Post.php, Post.template.php, Post.english.php, editor.js)
- Removed cleanFileInput function as no longer necessary (script.js)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/script.js


When I say it's broken in IE, the error condition isn't right. The <input type="file"> needs to be cleared in the event of an error, which is fine. Now, a type=file is read-only for security reasons but everyone except IE accepts an empty string to clear it.

IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element. This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.

It can be done, I just don't have the inclination right now to do so.


As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)
8337
Features / Re: New revs
« on September 29th, 2010, 03:53 PM »
Quote
Help text for IP: I didn't test, but should I assume that it only shows up if user HAS permission to see their own IP? If yes, then it's correctly phrased. Otherwise, it needs fixing.
Correct. If they can't see it, nothing shows at all.
Posted: September 29th, 2010, 03:27 PM

Revision: 169
Author: arantor
Date: 14:52:32, 29 September 2010
Message:
! Speculative fix for specifying PayPal language from subscriptions to checkout. Not overly happy about binding the list of known 'languages' into the core, but don't really see a better way at this time... short of including the language code into $txt in index.english.php (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Subscriptions-PayPal.php


Yeah, it occurred to me as I was writing up the note that we could include the PayPal language code in the language file itself but didn't want to set that precedent (since if we include other payment gateways in the future, something similar would be required)
8338
Features / Re: New revs
« on September 29th, 2010, 02:31 PM »
That's the thing... for me, seeing if ($some_array['value'] == ROLEPERM_ALLOW) is way more readable than if ($some_array['value'] == 1) - what does that 1 mean?

I also talked about magicalness; I have an idea for an easter egg out of it :D

Yeah, it will be one of the larger changes, but probably not the largest; some of the stuff I've suggested for group management is probably a touch larger.
8339
Features / Re: New revs
« on September 29th, 2010, 01:42 PM »
Quote
Yeah, array_flip() could be beneficial. And instead of isset(), we could use !empty(), so we could actually set perm values to something else than just on/off: numbers, for instance... Like in 'max number of PMs allowed in your box', things like that. I'm not a perm specialist, though.
I actually did something closer to this in SimpleDesk actually. Need to look at exactly what I did because I think I just had it store a value of 1, 0 or -1 depending on allow, disallow, deny (though they were constants instead so the code was clear)
8340
Features / Re: New revs
« on September 28th, 2010, 02:10 PM »
Quote
I'm not sure exactly, but checking perms is a fast process, isn't it? I think that once perms are loaded for someone, they're cached.
It is, but it's not the fastest it could be (though the difference is basically a micro-optimisation) - $user_info['permissions'] becomes an array of strings of the permission names, matched via in_array. The faster way would be to array_flip it at some point during loading and do isset($user_info['permission'][$perm_name]), though note that if a board's id is specified, it's a DB query - and uncached IIRC. This is pretty infrequent however.

I'm quite happy to change it - it just seemed logical to tie it up into its own permission rather than tie it into something else; that way you don't give out permissions unnecessarily.
Quote
Want me to look into all of the 'ip' occurrences in the code?
Only if you get really bored.