Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8311
Features / Re: New revs
« on October 12th, 2010, 01:16 PM »
Quote
I... I'm not sure I understand. I was just read through the log, saw something that I would sum up as "$a = 'hello'; echo $a;" and turned it into "echo 'a';"... Did I make a mistake? Feel free to revert, of course.
htmlspecialchars does one core job, converting key HTML items into entities, namely stuff like & to &. It also has options for handling quotes, ENT_COMPAT, ENT_NOQUOTES and ENT_QUOTES. ENT_COMPAT is the default, which converts " to ", ENT_NOQUOTES leaves both " and ' alone, and ENT_QUOTES does both " to " and ' to  according to php.net's page on it. (At least, it definitely turns ' into entities)

It's probably OK to do that, actually, but it may have unintended side effects. I'll revert it for now because I don't want to get extra unintended stuff breaking - the UTF-8 changes were huge, and may mean other stuff may fail in interesting ways yet, and I'd rather not change something like that just yet. (It is a good idea to simplify it down though, as I'm not entirely sure that it's needed outside the query parameterisation)
Posted: October 12th, 2010, 12:25 PM

Revision: 200
Author: arantor
Date: 11:40:49, 12 October 2010
Message:
! Expand installer strtolower version to match main source (install.php)
! Fix broken regexp for sanitising lists (Class-Editor.php)
! Quasi-revert htmlspecialchars change for now, but remove charset parameter (Load.php)
! Remove lang_character_set from the language editor options (ManageServer.php)
! Fix caller for recursive Unicode validation (Subs.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.php

Posted: October 12th, 2010, 12:41 PM

Revision: 201
Author: arantor
Date: 12:16:01, 12 October 2010
Message:
! Restructure download handler into its own file (Display.php, index.php, Download.php)
! Fix broken attachments (reverting previous optimisation) (Download.php)
----
Modified : /trunk/Sources/Display.php
Added : /trunk/Sources/Download.php
Modified : /trunk/index.php


This marks the start of breaking up the monolithic files in the core; there's really no need to have them like that, especially as it makes things slower in fact (Display being one of the most heavily used files, needs to be kept lighter!)
8312
Features / Re: New revs
« on October 12th, 2010, 10:49 AM »
Quote
As for myself, I copy what I type into the changelog, directly before posting it, because if a file is out of sync, it friggin' erases the log and doesn't let me copy it for my next attempt!
Never have that problem, even when it's out of sync. TortoiseSVN keeps all mine even if I hit cancel; above the changelog textbox there's a 'Recent Messages' button you can click... maybe you need a more recent version?
Quote
* Simplified htmlspecialchars(). (Load.php)
Interesting change... any particular reason? The one thing I'd note is that now every ' that comes in will be converted to an entity (which may have other consequences for the places where no override was given, where it will just use ENT_COMPAT, so only double quotes would be entitified before)
8313
Features / Re: New revs
« on October 12th, 2010, 10:09 AM »
Revision: 196
Author: nao
Date: 08:26:55, 12 October 2010
Message:
* Renamed content_section to content. (Various files)
----
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/other/readme_convert.html
Modified : /trunk/other/readme_install.html
Modified : /trunk/other/readme_update.html
Modified : /trunk/other/readme_upgrade.html


Revision: 197
Author: arantor
Date: 09:08:17, 12 October 2010
Message:
- Remove legacy CAPTCHA code using only premade images shown in a line (ManageSettings.php, ManageSettings.english.php, Register.php, Subs-Editor.php, Subs-Graphics.php, GenericControls.template.php)
- Remove all the premade image folders (Candice, Hootie, President)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Themes/default/GenericControls.template.php
Deleted : /trunk/Themes/default/fonts/Candice
Deleted : /trunk/Themes/default/fonts/Hootie
Deleted : /trunk/Themes/default/fonts/President
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
8314
The Pub / Re: Logo Madness (Was: New revs)
« on October 12th, 2010, 09:00 AM »
Yeah, I split it off :P
8315
Features / Re: New revs
« on October 12th, 2010, 08:57 AM »
It won't work, no, because I ripped out the DB fields too.

Yup, I use TortoiseSVN, all I do for my commit notices is go to the trunk root, right click, view the log then right click on my commit and copy to clipboard.
8316
Features / Re: New revs
« on October 12th, 2010, 05:05 AM »
Revision: 193
Author: arantor
Date: 02:45:10, 12 October 2010
Message:
! Make Wedge UTF-8 only. Note, there are still some legacy functions roaming around (notably the legacy attachment handler and the conversion functions to handle other-to-UTF-8 and entities-to-UTF-8-characters) which can remain for now until we get that sorted in the converters.
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/DbPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/Help.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Poll.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Printpage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/Themes/default/Xml.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/Sphinx/sphinx_config.php
Modified : /trunk/other/install.php
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/templates/UnitTest.template.php
Modified : /trunk/other/upgrade.php



I don't think I broke anything, either, and I think I got rid of most (if not all) of the language strings though I may have left some for the legacy conversion interface in there.
Posted: October 12th, 2010, 03:45 AM

Revision: 194
Author: arantor
Date: 03:23:23, 12 October 2010
Message:
! More anti-UTF-8 removals
 ! Fixing the language editor (ManageServer.php, Admin.template.php)
 ! Fixing language loaders (Load.php, ManageServer.php)
 ! Yet more language strings going bye-bye (Install.english.php, ManageSettings.english.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php


I yoinked out some more stuff in the admin panel. Nothing exciting.
Posted: October 12th, 2010, 04:24 AM

Revision: 195
Author: arantor
Date: 04:03:50, 12 October 2010
Message:
! Fix minimum version in web installer
+ Added check for GD2 plus the functions we need in the CAPTCHA and attachment handlers
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/webinstall.php


There's more to the GD stuff; now that's in, there's legacy stuff like the gif-to-png magic converter, plus the files in the fonts/ directory that are GIFs, and the CAPTCHA-without-GD code that can go too. Time for bed for me though, didn't have time to do them today.
8317
Features / Re: New revs
« on October 12th, 2010, 01:02 AM »
Revision: 192
Author: arantor
Date: 00:01:09, 12 October 2010
Message:
- Remove karma (lots of files, including removing from the installer, language strings, even the icon for it in Core Features)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/DbPackages.php
Deleted : /trunk/Sources/Karma.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/News.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Deleted : /trunk/Themes/default/images/admin/feature_k.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Stats.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/xml/detailed-version.js


Surprising how many places needed to be edited for what is really a minor feature.
8318
Features / Re: New revs
« on October 11th, 2010, 12:04 AM »
Quote
Hmm... Well...
I don't know.
To me, that Wedge icon was pretty much the symbol for our website, rather than our software. See what I mean...?
Just like SMF has their own favicon at simplemachines.org, but they don't include it in the package.
It's not really about the icon itself that I made the change; the icon just happened to be what I had to hand. The idea is to provide something out of the box for those users who would want it - I'm thinking about things we can do to minimise support requests generally, and having it set up like that will mean that people can just upload a new one and everything will just support it regardless of anything else.
8319
Features / Re: New revs
« on October 10th, 2010, 07:51 PM »
Quote
- From the beginning, I was very happy with the favico I made for wedgeforum.com, but unhappy with the logo itself. Now, I'm very happy with my current Wedge logo, but unhappy with the (unused) favico I made from it...
You can change it :P Just it was something to hand that was convenient.
Quote
- If admin has a favico for their site, they may erase it by thoughtlessly uploading the Wedge files to their website.
Sure, but how often do site admins have a favicon already in place for a top level domain and have nothing else there when adding a forum to the top level of the domain?
Quote
- If they're uploading to a subfolder, they may not like having a different favico than their main site, either.
Sure, but having it set up like this will mean they just copy theirs over the top of the provided one (we don't have to include it in upgrades).

It also means if they just want to customise it, they have a point of reference.
Quote
Well, sure can do that, yes.
I'm sorry I didn't think of doing that from the beginning.
No need to apologise; only reason I thought of it is because I've been doing a similarly styleable menu for my other project and one of the things was to make it as flexible as possible to style in pure CSS.
8320
Features / Re: New revs
« on October 10th, 2010, 06:25 PM »
Revision: 190
Author: arantor
Date: 17:24:43, 10 October 2010
Message:
+ Provide a default favicon.ico and have it called from the theme too (favicon.ico, index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Added : /trunk/favicon.ico
8321
Features / Re: New revs
« on October 10th, 2010, 05:25 PM »
The one thing about the icons is that they're hardcoded right now; would be hard for theme authors to set the icons themselves.

While this would be somewhat ugly, would it not be preferable to define classes in CSS for each icon (like how the sprite icons work in the thread view normally) and control it all through CSS so theme authors can override/ignore it as they see fit?
8322
Off-topic / Re: Post count fever
« on October 9th, 2010, 07:01 PM »
Talkative doesn't mean sociable. You can be quite anti-social by never shutting up! :P
8323
Off-topic / Re: Post count fever
« on October 9th, 2010, 12:03 PM »
What can I say, I'm a talkative person :P
8324
Off-topic / Re: Post count fever
« on October 9th, 2010, 11:08 AM »
If you're only 10% behind, that would put you at 35k :P

I was fairly consistent at 100-150 per day over there for a while.
8325
Features / Re: New revs
« on October 8th, 2010, 11:15 AM »
I like the idea of icons, haven't looked at the implementation yet.

It does add something and I know full well that icons can make or break a UI, but often if they're meaningful icons, they add to it :)

If it's anything like here, it works for me.