Wedge

She looks like she's not enjoying it...

You overtook me! WTF!

It's an illusion ;)

I think that'd work great, personally.

There's actually not a lot in it, I think, if you dig down to the underlying C code, since a string and an array are internally managed through pointers rather than the physical value being pushed; it's sort of by-reference-but-pretending-otherwise as opposed to really-by-reference. (This is most noticeable when calling C stuff from something like Visual Basic where you have to be explicit and strings, arrays etc are always ByRef even if the intent is not.)The current code seems to work, work quite well and achieves what the original intent was - putting everything that much closer to the end to get faster rendering and add <insert JS library here> if we wanted. So there are bigger fish to fry, so to speak.


Right now I'm trying to visualise exactly how drafts would play out - see my notes in http://tracker.wedge.org/?sa=ticket;ticket=51 for more of the issues that need to be tackled.

Revision: 304
Author: arantor
Date: 19:32:42, 27 November 2010
Message:
- Remove installed add-ons list seeing how we already have the same list in the Browse Add-ons page (Admin.php, Packages.php, PackageGet.php, Packages.template.php, Admin.english.php, Admin.french.php, Packages.english.php, Packages.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php


Revision: 305
Author: arantor
Date: 22:56:55, 27 November 2010
Message:
! More movement of actions to their own files (Search.php, Search2.php, Themes.php, Jsoption.php, index.php)
! Fix for broken info centre toggle (BoardIndex.php)
----
Modified : /trunk/Sources/BoardIndex.php
Added : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Search.php
Added : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/index.php

I did go and make a unified diff and reviewed that, which was much better - though still a lot to take in. The main stuff I see as different, really, is all the inline JS changes.

Yeah, I saw in hindsight about the whole thing of add_js being magical (though, as it happens, broken on pre 5.3, but I've already fixed that)

I'll comment more on the drafts stuff in the ticket, I think.

At about the same point I looked at the notes and realised that was the way to go, so I'm just staring at a major unified diff (per file, at least)

add_js is pretty neat, though I did get confused looking at the editor changes when seeing add_js, followed by several $context['footer_js'] changes immediately thereafter - mostly because until I saw what add_js was doing, it never occurred to me that it might be adding <script> (even though I'd already read that!)

In which case, it seems there's a bug in ManageMail which does use add_js to add bits in the middle of a function...

What we could do there, maybe, is provide a second parameter to add_js, whether to add <script>, true by default - but likely that would be a touch slower, and probably not that much more readable.


As for drafts, I got a bunch of things about that, e.g. localStorage, with option to force using AJAX (if you move between computers habitually, for example)