Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
8071
Features / Re: New revs
« on January 18th, 2011, 04:25 PM »
Revision: 490
Author: arantor
Date: 15:24:41, 18 January 2011
Message:
! Sync to SMF 10336
! The value of checkbox custom fields were displayed incorrectly on topic display. (Load.php, ManageSettings.php)
! Paid subscriptions scheduled taks should be disabled when paid subscriptions feature is disabled. (ManageSettings.php, install.sql)
& Unclear help strings for post unapproved replies and attachments permissions. (ManagePermissions.english.php)
& Outdated information in calendar help string. (Help.english.php)
! The check for empty body on personal message body failed in some cases. (PersonalMessage.php)
! Calendar maximum year was not adjusted on forums upgraded from older versions. (Updated from 2016 to 2020 in installer) (install.sql)
! Member approvals did not take account deletion requests into account when registration method is not set to member approval. (ManageMembers.php, Subs.php)
! News items now get HTML encoded as they should be. (ManageNews.php, Admin.english.php)
!! Not applying:
! rev 10328: WAP template being called from Post.php; we don't have the WAP template any more thus the code does not apply to us.
! revs 10333-10335: SSI permissions have been fixed in SMF, by checking a new variable and if not found, booting back to the login page. Interesting approach, if a little blunt... anyway we already did our own. There is a change to side padding in SSI examples in 10334 but I figured we'd redo that anyway...
! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql
(This was ALL done by Sinan last night. Guy's a legend it seems.)
Author: arantor
Date: 15:24:41, 18 January 2011
Message:
! Sync to SMF 10336
! The value of checkbox custom fields were displayed incorrectly on topic display. (Load.php, ManageSettings.php)
! Paid subscriptions scheduled taks should be disabled when paid subscriptions feature is disabled. (ManageSettings.php, install.sql)
& Unclear help strings for post unapproved replies and attachments permissions. (ManagePermissions.english.php)
& Outdated information in calendar help string. (Help.english.php)
! The check for empty body on personal message body failed in some cases. (PersonalMessage.php)
! Calendar maximum year was not adjusted on forums upgraded from older versions. (Updated from 2016 to 2020 in installer) (install.sql)
! Member approvals did not take account deletion requests into account when registration method is not set to member approval. (ManageMembers.php, Subs.php)
! News items now get HTML encoded as they should be. (ManageNews.php, Admin.english.php)
!! Not applying:
! rev 10328: WAP template being called from Post.php; we don't have the WAP template any more thus the code does not apply to us.
! revs 10333-10335: SSI permissions have been fixed in SMF, by checking a new variable and if not found, booting back to the login page. Interesting approach, if a little blunt... anyway we already did our own. There is a change to side padding in SSI examples in 10334 but I figured we'd redo that anyway...
! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql
(This was ALL done by Sinan last night. Guy's a legend it seems.)
8072
Features / Re: How about PMs being listed in Core Features?
« on January 18th, 2011, 04:05 PM »
That's the point, there's no way to disable it right now. You can hide it from regular users through permissions, but you can't ever hide it from admins, or disable it entirely.
8073
Features / How about PMs being listed in Core Features?
« on January 18th, 2011, 12:32 PM »
How about we list personal messages in the Core Features page?
I'm just thinking I've come across cases where the admin didn't want it to be available at all, and while it can be disabled for users through permissions, the tab is still visible to admins.
I'm just thinking I've come across cases where the admin didn't want it to be available at all, and while it can be disabled for users through permissions, the tab is still visible to admins.
8074
Features / Re: New revs
« on January 18th, 2011, 11:24 AM »
Revision: 488
Author: arantor
Date: 10:24:12, 18 January 2011
Message:
! PM unread indicator shouldn't be set twice (Subs.php)
+ Ability to mark PMs as read (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Author: arantor
Date: 10:24:12, 18 January 2011
Message:
! PM unread indicator shouldn't be set twice (Subs.php)
+ Ability to mark PMs as read (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
8075
Features / Re: New revs
« on January 17th, 2011, 02:13 PM »
Revision: 484
Author: arantor
Date: 13:13:23, 17 January 2011
Message:
! Sync to SMF rev 10323
! Prevent wildcard-only censoring (ManagePosts.php)
! Converted passwords not recognised when using double MD5 hashing (Login2.php)
! Removed <b> tags that shouldn't be there (Reminder.php, PersonalMessage.template.php)
& Wrong URL destination in 'birthday_email' help popup (Help.english.php)
! Extended maxlength for event titles, but see below (Calendar.template.php, Post.template.php)
!! Not applied:
* revs 10317 and 10318 to Subs.php for the hook functions since they were previously rewritten anyway and the changes don't really apply now.
* rev 10316 - the maxlength of event title's textbox was upped from 70 (Calendar) and 60 (Post) to 255 to match the expanded field size, except that the field is subject to htmlspecialchars which can mean cropped entities. I've moved both to 80 for us, and the fields are now correctly sized as 255 in the schema (I missed one of them before)
* rev 10318's "pedantry" to index.css to move the definition of .new_win earlier in the file and make it fit stylistically with all the other CSS declarations.
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/other/install.sql
Author: arantor
Date: 13:13:23, 17 January 2011
Message:
! Sync to SMF rev 10323
! Prevent wildcard-only censoring (ManagePosts.php)
! Converted passwords not recognised when using double MD5 hashing (Login2.php)
! Removed <b> tags that shouldn't be there (Reminder.php, PersonalMessage.template.php)
& Wrong URL destination in 'birthday_email' help popup (Help.english.php)
! Extended maxlength for event titles, but see below (Calendar.template.php, Post.template.php)
!! Not applied:
* revs 10317 and 10318 to Subs.php for the hook functions since they were previously rewritten anyway and the changes don't really apply now.
* rev 10316 - the maxlength of event title's textbox was upped from 70 (Calendar) and 60 (Post) to 255 to match the expanded field size, except that the field is subject to htmlspecialchars which can mean cropped entities. I've moved both to 80 for us, and the fields are now correctly sized as 255 in the schema (I missed one of them before)
* rev 10318's "pedantry" to index.css to move the definition of .new_win earlier in the file and make it fit stylistically with all the other CSS declarations.
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/other/install.sql
8076
Features / Re: New revs
« on January 17th, 2011, 08:34 AM »
Revision: 483
Author: arantor
Date: 07:33:54, 17 January 2011
Message:
! Recent posts was broken, oops (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Author: arantor
Date: 07:33:54, 17 January 2011
Message:
! Recent posts was broken, oops (Recent.php)
----
Modified : /trunk/Sources/Recent.php
8077
Features / Re: New revs
« on January 17th, 2011, 08:16 AM »
Revision: 482
Author: arantor
Date: 07:15:57, 17 January 2011
Message:
! Remove unread since last visit, so unread just triggers all unread now. (index.english.php, index.template.php, Unread.php, Unreadreplies.php, Recent.template.php)
----
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Author: arantor
Date: 07:15:57, 17 January 2011
Message:
! Remove unread since last visit, so unread just triggers all unread now. (index.english.php, index.template.php, Unread.php, Unreadreplies.php, Recent.template.php)
----
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
8078
Features / Re: New revs
« on January 16th, 2011, 06:46 PM »
Revision: 481
Author: arantor
Date: 17:46:04, 16 January 2011
Message:
+ Provide option whether moved topics can only be moved into areas the user could theoretically create a new topic in, or any board they can see. (ManagePosts.php, MoveTopic.php, Admin.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Author: arantor
Date: 17:46:04, 16 January 2011
Message:
+ Provide option whether moved topics can only be moved into areas the user could theoretically create a new topic in, or any board they can see. (ManagePosts.php, MoveTopic.php, Admin.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
8079
Features / Re: New revs
« on January 16th, 2011, 05:38 PM »
Revision: 480
Author: arantor
Date: 16:37:30, 16 January 2011
Message:
! Stray poll action cleaned up (index.php, Poll.php)
+ Imperative scheduled tasks now exist though UNTESTED (index.php, Load.php, Subs-Scheduled.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Poll.php
Added : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Of course, imperative scheduled tasks has a new table.
Author: arantor
Date: 16:37:30, 16 January 2011
Message:
! Stray poll action cleaned up (index.php, Poll.php)
+ Imperative scheduled tasks now exist though UNTESTED (index.php, Load.php, Subs-Scheduled.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Poll.php
Added : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Of course, imperative scheduled tasks has a new table.
8080
Features / Re: New revs
« on January 16th, 2011, 05:28 PM »
Revision: 479
Author: arantor
Date: 16:28:17, 16 January 2011
Message:
! If possible, save a query for getting last post's time for a thread (for whether it's old enough there should be a warning to user) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Author: arantor
Date: 16:28:17, 16 January 2011
Message:
! If possible, save a query for getting last post's time for a thread (for whether it's old enough there should be a warning to user) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
8081
Features / Re: Recycling board by default
« on January 16th, 2011, 04:41 PM »
If it were implemented as it is now, it would just be a regular board with the relevant permissions set. That's a tiny job, in fact :)
But I get the feeling something more complex and powerful is what's needed.
But I get the feeling something more complex and powerful is what's needed.
8082
Features / Re: Recycling board by default
« on January 14th, 2011, 11:57 AM »
This is what I did in SimpleDesk and in hindsight, I'm not sure it worked so well in practice actually. It was certainly an interesting way of solving the problem (to have the deleted items remain in the ticket in context, but be flagged as deleted) but the UI sucked, not to mention causing other issues with how the recycled messages get accessed.
It's not a *bad* solution but the UI would certainly need a makeover.
As for separating deleting individual posts vs deleting individual topics... again, we actually had that in SimpleDesk and internally it made more of a mess, at least in my head trying to get it working sensibly.
That said, floating topics are the perfect candidate for being deleted; you store the original board somewhere other than the place you normally use to access it, or otherwise set the 'parentage' to deleted in some form.
It's not a *bad* solution but the UI would certainly need a makeover.
As for separating deleting individual posts vs deleting individual topics... again, we actually had that in SimpleDesk and internally it made more of a mess, at least in my head trying to get it working sensibly.
That said, floating topics are the perfect candidate for being deleted; you store the original board somewhere other than the place you normally use to access it, or otherwise set the 'parentage' to deleted in some form.
8083
Features / Re: New revs
« on January 14th, 2011, 11:02 AM »
Revision: 472
Author: arantor
Date: 10:01:48, 14 January 2011
Message:
! Fixing an undefined index in $context (Unreadreplies.php)
----
Modified : /trunk/Sources/Unreadreplies.php
Author: arantor
Date: 10:01:48, 14 January 2011
Message:
! Fixing an undefined index in $context (Unreadreplies.php)
----
Modified : /trunk/Sources/Unreadreplies.php
8084
Features / Re: New revs
« on January 14th, 2011, 10:30 AM »
Revision: 471
Author: arantor
Date: 09:30:03, 14 January 2011
Message:
! Enforced 'allow guests to browse the forum' being disabled - guests have no access when that's off, so no permissions, no access to anything other than logging in.
! Enforce it for permissions, board access in SSI context and all SSI functions (SSI.php, Security.php)
! Hide guests group from all reports when access disabled (Reports.php)
! Hide guests option from board access (ManageBoards.php)
! Hide guests option from all permissions UIs (ManagePermissions.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Author: arantor
Date: 09:30:03, 14 January 2011
Message:
! Enforced 'allow guests to browse the forum' being disabled - guests have no access when that's off, so no permissions, no access to anything other than logging in.
! Enforce it for permissions, board access in SSI context and all SSI functions (SSI.php, Security.php)
! Hide guests group from all reports when access disabled (Reports.php)
! Hide guests option from board access (ManageBoards.php)
! Hide guests option from all permissions UIs (ManagePermissions.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
8085
Features / Re: New revs
« on January 14th, 2011, 10:15 AM »
Revision: 469
Author: arantor
Date: 09:11:32, 14 January 2011
Message:
+ New CAPTCHA: ledicons-animated (captcha-ledicons.php, captcha-ledicons_anim.php)
----
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-ledicons_anim.php
Revision: 470
Author: arantor
Date: 09:15:29, 14 January 2011
Message:
+ Optionally display flags on board indexes for board-specific languages (install.sql, BoardIndex.php, BoardIndex.template.php, MessageIndex.php, MessageIndex.template.php, Subs-BoardIndex.php, ManageBoards.php, ManageBoards.english.php, Help.english.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Author: arantor
Date: 09:11:32, 14 January 2011
Message:
+ New CAPTCHA: ledicons-animated (captcha-ledicons.php, captcha-ledicons_anim.php)
----
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-ledicons_anim.php
Posted: January 14th, 2011, 10:11 AM
Revision: 470
Author: arantor
Date: 09:15:29, 14 January 2011
Message:
+ Optionally display flags on board indexes for board-specific languages (install.sql, BoardIndex.php, BoardIndex.template.php, MessageIndex.php, MessageIndex.template.php, Subs-BoardIndex.php, ManageBoards.php, ManageBoards.english.php, Help.english.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql