Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
8011
Features / Re: Recycling board by default
« on February 15th, 2011, 10:56 AM »
Quote
that's a board you'll really never get to use at all, so you'll delete it (if you can/think of it), and it'll create a gap in the board list... (Less of a problem, though.)
Or you'll repurpose it.
Quote
Which I never use, hence my ignorance
Incidentally, I don't use it much either, even on forums I post moderate(d). The inline view is much more useful in that respect.
Quote
UI? Why is it a UI problem at all?
I think we should ask others what they think about this...
If I delete a post from a topic, I don't want it sat there with a different border, I want it out the topic - I deleted it for a reason, I didn't just 'unapprove' it. So if we then keep deleted posts inside the topic but have a different interface, we then have to figure out how to visually distinguish between actual moderated posts and what we have already deleted.

Have a play with what SimpleDesk does with respect to deleted posts and see how it feels. It looks and feels a lot like post moderation, and works basically the same way too - but it's a different thing altogether.
8012
Features / Re: Recycling board by default
« on February 15th, 2011, 09:34 AM »
Leaving it at 2 isn't *that* bad, IMO, but I can see why it should probably be moved.
Quote
Alternatively, we could rewrite the recycle bin stuff to leave deleted topics/posts in their place and just consider them as unapproved... Then we could simply have somewhere in the admin area an "unapproved posts/topics browser" or something. That would actually be my preferred solution.
There's already an unapproved posts/topics browser in the moderation centre. But honestly, I think that makes it too likely that stuff gets brought back into the ecosystem, not to mention the fact that in every way you slice it, the UI ends up sucking badly, whether you make it 'deleted' but left inline, or moderated for the purposes of deletion. (SimpleDesk moved from an SMF style to the whole inline thing, and it's one of the few things that while I wrote, I ended up really hating in practice)
8013
Features / Re: Recycling board by default
« on February 15th, 2011, 09:19 AM »
Quote
Then... What do we do?
Maybe this is a sign that we have to rethink how recycled topics need to be handled. Or we accept that having board 2 as-is isn't an entirely bad thing.
Quote
Okay. Anyone else? Would you rather have a 'styles' or 'stylings' folder?
FWIW, I'd rather have styles, it's shorter and easier to remember.
8014
Features / Re: New revs
« on February 15th, 2011, 02:48 AM »
Revision: 591
Author: arantor
Date: 01:47:47, 15 February 2011
Message:
! Kill 'enable sticky option', they're now wired on. (Surprisingly many files.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/other/install.sql
8015
Features / Re: Recycling board by default
« on February 15th, 2011, 12:03 AM »
Quote
simply add our id_board manually for each new board -- at worst it's only an extra query to do.
Hmm, I can just see that causing issues with forums where two admins are trying to add new boards at the same time.
Quote
(Which I'd recommend doing, if only because it's easier to manage for themers, as well as users who have plenty of stylings.) Any ideas on your side?
Styles or stylings works for me, it's certainly more accurate than css.
8016
Features / Re: Recycling board by default
« on February 14th, 2011, 11:23 PM »
Prior to creation, it reorders all the boards. Incidentally it's broken on PGSQL and InnoDB for this reason and is an occasional support query, the answer to which is to stop relying on MyISAM behaviour and order it properly (the side effect of the ordering the do is to ensure rows are physically in the table in the right order, so order by null still gets you the correct order)
8017
Features / Re: Recycling board by default
« on February 14th, 2011, 11:15 PM »
Oh FFS, I forgot about that. Boards runs a couple of reorder table ops when adding a new board, which likely nukes the increment counter.

:edit: My temper here is related to the fact that we change one thing and two others break in an unexpected fashion.
8018
Features / Re: Recycling board by default
« on February 14th, 2011, 10:53 PM »
Argh, so many things that interplay here :( Not sure what to suggest.
8019
Features / Re: Recycling board by default
« on February 14th, 2011, 10:41 PM »
Hmm, that's true. Maybe we should go with 65535 after all.
8020
Features / Re: Recycling board by default
« on February 14th, 2011, 10:28 PM »
We can use 0 provided we're careful. Note there'd have to be a call at the start of install to use that parameter.
8021
Features / Re: Recycling board by default
« on February 14th, 2011, 09:35 PM »
Ah, now I remember. The issue comes on insertion, on an auto increment column, using 0 normally makes it insert the next value. The flag disables that so passing NULL is the only way to do so.

We'd have to make sure that DB backup+restore took care of this, but that is the only time AFAIK.
8022
Features / Re: Recycling board by default
« on February 14th, 2011, 08:57 PM »
You were saying about getting warnings...?
8023
Features / Re: Recycling board by default
« on February 14th, 2011, 08:38 PM »
I'm not overly keen on having errors, so having 0 seems out, but if 65535 is still viable, then we can use that provided there's a suitable ALTER TABLE after it.
8024
Features / Re: Recycling board by default
« on February 14th, 2011, 07:38 PM »
Hmm, you're right about the recycle board 0 business.

Guess it might be time to consider something else?
8025
Features / Re: Recycling board by default
« on February 14th, 2011, 07:23 PM »
Yes, 65535 is the maximum value as it's an unsigned smallint column.

Maybe I should sit down and map the schema sometime so we can see where the column gets replicated to (off the top of my head, id_board is used as a foreign key in: messages, boards, members as a comma sep. value, board permissions)