Wedge

Revision: 612
Author: arantor
Date: 12:14:44, 22 February 2011
Message:
+ More bbcode icon (Class-Editor.php, sprite.png, Post.english.php)
! Fixed more bbcode to actually work, it's only just inside a topic it should be empty, all other cases it should be firing, not just when we're inside a board, like it should in feeds (install.sql, Subs-BBC.php)
+ Modified feed handler such that if we have a limit on feed length, check whether the more bbcode is present and is set within the space of that limit - if it's inside the limit, or not too far outside, use more bbc instead of auto cropping. (Feed.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Themes/default/images/bbc/sprite.png
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/other/install.sql


Revision: 613
Author: arantor
Date: 12:19:54, 22 February 2011
Message:
! Woops, forgot to put the query quite right. (install.sql)
----
Modified : /trunk/other/install.sql

Revision: 610
Author: arantor
Date: 02:20:38, 22 February 2011
Message:
! Make sure board type is available to the board loader (Load.php)
! Refactor the code for getting who is in a board/topic for display, reducing duplicate code (MessageIndex.php, Display.php, Subs-MembersOnline.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-MembersOnline.php

The one thing that hits me about each of the portals is how much *stuff* there is. I did look at all the portals a bit back, and it struck me how thorough some of the admin panels are for them, but too much *stuff* in one place and a sort of reliance on users figuring it out themselves.

PMX exemplifies that in my mind, both SP and TP have the same issue but at least they're easy enough to follow once you've been around a bit (as it were)

Neither PMX nor ezP focus on design too much, they come across as blocky and built by programmers almost for their own use rather than for others. (Perhaps I'm giving our friend too much credit here, don't know. At least, I *hope* that's the reason for ezP's design mentality.)

ADK Portal seems a bit much of a mish-mash, as though it doesn't really know what it's trying to do.

DP, I did some debugging in the run up to 1.0, and its drag and drop ideas were pretty nice, but it did feel a bit like it was trying to chase SP at times, and not for the right reasons.

Revision: 604
Author: arantor
Date: 11:54:58, 19 February 2011
Message:
! Sync to Bad Behavior 2.1.11
 ! Remove test for Google Wireless in anti-Google spoof as it is a special proxy not a search engine. (Security.php)
! Sync to SMF 10465
 ! (r10449) Cache bug in upgrader (upgrade.php)
 ! (r10466) Typo in forum profile loader, makes custom fields more internally consistent (Profile-Modify.php)
 ! (r10467) 64-bit created zip file decompression fix (Subs-Package.php)

Not implemented from SMF
 * r10447 Tweak of censored words UI (going to be rewritten anyway)
 * r10448 Shuffling of setlocale and time format in 2.1 branch, not convinced it is beneficial yet, and not convinced it doesn't have issues (it certianly has some issues in the hacky changes to Load.php if mb_* functions aren't available... like fatal errors)
 * r10450,10457-10459 Tagging 1.0.21, 1.1.13, 2.0 RC5, branching in 2.1/other
 * r10451 Pedantry and minor typo fix in converter (not applicable to us because the importer needs to be written from scratch anyway)
 * r10452 Conversions of substr($x, $y, 1) to $x[$y]... it makes it harder to follow and the speed factor is not hugely significant even if it is inside parse_bbc (it's *where* it's inside parse_bbc, in validate functions mostly)
 * r10453 Pedantry: removal of @ in front of ini_get/ini_set and ob_start calls
 * r10454 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10455 Removal of @ in front of set memory limit calls in converters
 * r10456 More == to === conversions
 * r10460 Yet more == to === in Post.php for 'testing commits'
 * r10461-3 Converting TYPE to ENGINE in upgrader scripts, then reverting it
 * r10464 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10465 Changing the 'clean attachment' to 'clear attachment' - we already revised the UI entirely
 * r10468 PostgreSQL specific fix in upgrader.
 * r10469 [2.1] "Replaced some strtr with str_replace and some strpos(strtolower()) with stripos() and some strtolower() == strtolower() with strcasecmp(). Just pedantic stuff."
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/other/upgrade.php

There are four states to be stored, not three: approved/not deleted, approved/deleted, not approved/not deleted, not approved/deleted.

I'd hate to restore something that was pending moderation and find it was auto approved in the process.

I'm seriously debating making post moderation permanently enabled rather than optional - I hear the concerns over performance but I have a feeling we can do something about that too. If it's handling deletion, it must be, basically.Had TV time, whereupon I was iPad-bound ;)They do. And they display a (!) on the front page alongside the different colour. I don't really have a problem with doing something similar for deleted topics - just wanted to be clear that's what we were doing.


And then fix up the hellspawn that is the moderation center (or should we gut that and do something better?)

Yeah, I'd like that. Not only does it keep consistency in pages, it also provides some consistency to the discussion, I don't know how many times I saw discussions that got altered because a post was removed, changing how the remaining posts were read.

NB there should still be a permadelete that actually deletes posts too...

That's what happens with posts from people you have on your ignore list. You get their name, no avatar, no poster info and the entire message is replaced with 'You are ignoring this person, click here to see what they said'.

Hence my concern because it looks pretty similar to inline deletion with what's been proposed.