Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
7951
Features / Re: Recycling board by default (PLEASE READ THE FEB. 15 POSTS EVERYONE!)
« on March 12th, 2011, 07:02 PM »
Well, there is favour for the inline-deleted style. My principle concern was the UI for it (though permissions are tricky, too) in which case if we mock up how the UI looks we can get a sense of whether that needs fixing or not.
7952
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on March 12th, 2011, 10:10 AM »
'SplitQuote'... is that a vB feature I've just never noticed before?
7953
Other software / Re: Well the deed is done
« on March 12th, 2011, 10:09 AM »The thing with the VB owners it seems that they forked out so much cash getting the software they don't seem to mind paying for good mods and themes.
So if you ever do feel going that way I would give you full access to my VB test site do do any development you would want.
7954
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on March 12th, 2011, 02:04 AM »
Certainly sounds heavy, am curious to see it thought.
Hang on, why aren't you in bed?! :P
Hang on, why aren't you in bed?! :P
7955
Other software / Re: Well the deed is done
« on March 11th, 2011, 03:59 PM »Well... Technically, AeMe2 is still available over there...
. I'm too busy on other things, and apparently you don't want to bother about it either
And the database templates, from what you described.
but there isn't a single de facto forum package
But don't ask me to support the software though. I'll leave it to others.
Wedge shall be the one -- the feature set of the paid competition, some extra features that no one has (it's really the only reason I'm getting lost in old-timer quotes...), and the best price of all.
7956
Other software / Re: Well the deed is done
« on March 11th, 2011, 03:35 PM »
It's better than the one paid offering on SMF *shrug*
vBulletin isn't inherently bad software, there is a reason it became the 'go to' forum of choice. It's just not what it could be.
vBulletin isn't inherently bad software, there is a reason it became the 'go to' forum of choice. It's just not what it could be.
7957
Features / Re: New revs
« on March 11th, 2011, 10:58 AM »
Revision: 650
Author: arantor
Date: 09:50:11, 11 March 2011
Message:
! Fix ordering to support topic starter/last poster name sorting. It's not pretty, but it's not a common case, and there isn't really a way to optimise it any better without nailing up queries that will have even more impact. (Display.php)
----
Modified : /trunk/Sources/Display.php
Revision: 651
Author: arantor
Date: 09:57:52, 11 March 2011
Message:
! Remove the ambiguous (and often unnecessary) join that should have been committed last time, oops. (Display.php)
----
Modified : /trunk/Sources/Display.php
Author: arantor
Date: 09:50:11, 11 March 2011
Message:
! Fix ordering to support topic starter/last poster name sorting. It's not pretty, but it's not a common case, and there isn't really a way to optimise it any better without nailing up queries that will have even more impact. (Display.php)
----
Modified : /trunk/Sources/Display.php
Posted: March 11th, 2011, 10:50 AM
Revision: 651
Author: arantor
Date: 09:57:52, 11 March 2011
Message:
! Remove the ambiguous (and often unnecessary) join that should have been committed last time, oops. (Display.php)
----
Modified : /trunk/Sources/Display.php
7958
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on March 10th, 2011, 11:14 AM »
It sort of depends how you approach it; from a display perspective, the issue of using paragraph tags with a left border solves all the display issues, but none of the editing issues.
It's not like it would be a problem to use a contentEditable frame; we're already doing that anyway in the WYSIWYG editor, but yeah I see where you're going.
Thing is, Thunderbird uses the left border gig in HTML emails which is where I got it from, as does other stuff, and everyone else uses >> for non HTML emails, so it's not like it is anything special. FWIW, they also do it as >> to indicate the start of a line and not bother to worry about how long the line is.
It's not like it would be a problem to use a contentEditable frame; we're already doing that anyway in the WYSIWYG editor, but yeah I see where you're going.
Thing is, Thunderbird uses the left border gig in HTML emails which is where I got it from, as does other stuff, and everyone else uses >> for non HTML emails, so it's not like it is anything special. FWIW, they also do it as >> to indicate the start of a line and not bother to worry about how long the line is.
7959
Features / Re: Another life-changing fantastic idea for quotes! (Bit silly, too.)
« on March 9th, 2011, 11:48 PM »
Hmm. OK, well, we already know what is newline delineated because we're given newlines by the editor and they're still present in the message body. So it's not like we're totally devoid of that meaning.
We can easily use that to define blocks of text that should be indicated with >>... but without using JS there's no way to display it. Part of me things we should just treat it as a single block of text, stick it in a paragraph tag and attach a coloured left border to it the way some email clients do. That way you essentially leave layout to the client to deal with ;)
But yeah, it's not pretty or clever to have to deal with this.
We can easily use that to define blocks of text that should be indicated with >>... but without using JS there's no way to display it. Part of me things we should just treat it as a single block of text, stick it in a paragraph tag and attach a coloured left border to it the way some email clients do. That way you essentially leave layout to the client to deal with ;)
But yeah, it's not pretty or clever to have to deal with this.
7960
Features / Re: New revs
« on March 6th, 2011, 03:48 AM »
Revision: 643
Author: arantor
Date: 02:43:21, 06 March 2011
Message:
! Attempt to fix ordering for prev/next topics (Display.php)
----
Modified : /trunk/Sources/Display.php
OK, this is a WIP fix. It deals with all the cases where we don't need the poster's name (first poster/last poster), I thought this was supplied by $topicinfo but it isn't.
The second problem is that invariably, the second query in the UNION sucks, and I mean *really* sucks. Right now I'm seeing 1.5s or more, but the reason is the way MySQL handles that selection on my 209k topic board; it's not using an index because it figures a table scan will be faster, but ultimately ends up filesorting the lot - here's the subselect on its own:
Code: [Select]
id select_type table type possible_keys key key_len ref rows Extra
1 SIMPLE t2 range PRIMARY,first_message,id_board,last_message_sticky... PRIMARY 3 NULL 209239 Using where; Using filesort
1 SIMPLE mf eq_ref PRIMARY PRIMARY 4 wedge.t2.id_first_msg 1 Using index
(t2 used in case MySQL was crapping itself between what t was, but it doesn't matter in this case, it makes no difference)
We gotta figure out a better way of handling this, it's not even using the primary key as a sorting criteria. :( But at least the ordering seems to be right now for the given criteria...
Author: arantor
Date: 02:43:21, 06 March 2011
Message:
! Attempt to fix ordering for prev/next topics (Display.php)
----
Modified : /trunk/Sources/Display.php
OK, this is a WIP fix. It deals with all the cases where we don't need the poster's name (first poster/last poster), I thought this was supplied by $topicinfo but it isn't.
The second problem is that invariably, the second query in the UNION sucks, and I mean *really* sucks. Right now I'm seeing 1.5s or more, but the reason is the way MySQL handles that selection on my 209k topic board; it's not using an index because it figures a table scan will be faster, but ultimately ends up filesorting the lot - here's the subselect on its own:
EXPLAIN SELECT t2.id_topic
FROM wedge_topics AS t2
INNER JOIN wedge_messages AS mf ON ( t2.id_first_msg = mf.id_msg )
WHERE t2.id_board =1
AND t2.id_topic <209240
ORDER BY t2.is_sticky DESC , t2.id_topic DESC
LIMIT 1id select_type table type possible_keys key key_len ref rows Extra
1 SIMPLE t2 range PRIMARY,first_message,id_board,last_message_sticky... PRIMARY 3 NULL 209239 Using where; Using filesort
1 SIMPLE mf eq_ref PRIMARY PRIMARY 4 wedge.t2.id_first_msg 1 Using index
(t2 used in case MySQL was crapping itself between what t was, but it doesn't matter in this case, it makes no difference)
We gotta figure out a better way of handling this, it's not even using the primary key as a sorting criteria. :( But at least the ordering seems to be right now for the given criteria...
7961
Features / Re: New revs
« on March 6th, 2011, 01:42 AM »
Revision: 642
Author: arantor
Date: 00:42:06, 06 March 2011
Message:
! Incorrect sprintf formatting in English string (index.english.php)
! Fixed board RSS feeds having Array instead of the board id (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Author: arantor
Date: 00:42:06, 06 March 2011
Message:
! Incorrect sprintf formatting in English string (index.english.php)
! Fixed board RSS feeds having Array instead of the board id (index.template.php)
----
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
7962
Features / Re: New revs
« on March 3rd, 2011, 05:13 PM »
Revision: 635
Author: arantor
Date: 16:12:57, 03 March 2011
Message:
! Fix counting of replies for multi-page non-forum topics, so we don't display "reply #x" when we shouldn't. (Display.php)
----
Modified : /trunk/Sources/Display.php
Author: arantor
Date: 16:12:57, 03 March 2011
Message:
! Fix counting of replies for multi-page non-forum topics, so we don't display "reply #x" when we shouldn't. (Display.php)
----
Modified : /trunk/Sources/Display.php
7963
Features / Re: New revs
« on March 3rd, 2011, 05:07 PM »
Revision: 634
Author: arantor
Date: 16:07:38, 03 March 2011
Message:
! Do not check for union or subselects in the query engine, we might use them. (Class-DB.php)
! Oops, forgot to bring $modSettings into scope (Display.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Themes/default/Display.template.php
Author: arantor
Date: 16:07:38, 03 March 2011
Message:
! Do not check for union or subselects in the query engine, we might use them. (Class-DB.php)
! Oops, forgot to bring $modSettings into scope (Display.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Themes/default/Display.template.php
7964
Features / Re: New revs
« on March 3rd, 2011, 11:35 AM »
Revision: 632
Author: arantor
Date: 10:33:49, 03 March 2011
Message:
! A bit of reorganisation of the display template, likely more to come (Display.template.php)
! Don't allow merging the first reply into the post unless we're actually in a board context (so no merging the first reply to a blog post, for example) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Author: arantor
Date: 10:33:49, 03 March 2011
Message:
! A bit of reorganisation of the display template, likely more to come (Display.template.php)
! Don't allow merging the first reply into the post unless we're actually in a board context (so no merging the first reply to a blog post, for example) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
7965
Features / Re: New revs
« on March 3rd, 2011, 01:28 AM »
Revision: 630
Author: arantor
Date: 00:28:32, 03 March 2011
Message:
! Get the correct posts with pagination, and ordering, based on whether this is a board or blog topic. (Display.php)
----
Modified : /trunk/Sources/Display.php
Author: arantor
Date: 00:28:32, 03 March 2011
Message:
! Get the correct posts with pagination, and ordering, based on whether this is a board or blog topic. (Display.php)
----
Modified : /trunk/Sources/Display.php