Wedge

Just before we wrestle this beast back on topic, let me explain why IPv6 support isn't done.

First up, bans. Since I figured as per our plans to be doing something different with bans, whatever is then done has to support IPv6 - I didn't go back and re-engineer IPv6 into the current ban system.

Other than that, there's a couple of niggly places where it doesn't push the IP address through the formatter. But it's mostly ready.

Yup, we're aware of the licence change (I see the BSD licence is firmly in place in the source files now), but we made the decision to reclose the licence of Wedge for the forseeable future, to explicitly prevent our work going back the other way, because of everything that's happened. Once the code is far enough along that it can't just be reused without serious work, we'll look at that again.

The people I am referring to have team badges and thus are specifically team members at this time.

I'd also note that our interests and path is different to SMF's, we firmly dropped the idea of "being just a forum", which is why blogging support is built in, AeMe has been integrated (and will become deeper integrated) and so on. To me, this seems logical, to provide features that people want - I have yet to figure out what SMF is even going to implement in 2.1 other than jQuery and IPv6 support, and dropping IE6.

I should have dropped out of sm.org a loooooong time ago, I've been generally happier since I stopped posting for the benefit of others and to pass the time waiting for SMF 2.0 to get released.

rev 798
(273 files, 304kb) (mainly because near enough every PHP file had to be touched)

This has taken me all day to do. (There were problems accessing the server recently...)

! Sync to SMF 10595
 ! r10547 The cookie shouldn't be reset. (Subs-Auth.php, Subs-Login.php) (In our case, we get to remove a chunk of code that they kept because we don't have to do PHP 4.3.2 specific tests...)

 ! r10548 Search strips so much it may end up with nothing! (Search2.php)

 ! r10549 Minor smiley misalignment fixed. (sections.css) [Bug 4727] (The img.smiley class may live better somewhere else, not sure.)

 ! r10553 "A few trivial fixes as per bug reports topics." (Profile.template.php, PersonalMessage.template.php)

 & r10557 Small clearer text. (Help.english.php)

 ! r10561 Updated [SiNaN]'s name as per SMF credits. (Credits.php)

 ! r10562 A necessary language file was not loaded when using read_tgz_data() function outside Packages area. (Subs-Package.php) [Bug 4732]

 ! r10564 Testing change for the wiki links and redirects. (Admin.php) (Plus I reinstated the change I broke from before.)

 ! r10565 Updates of readme files (readme_*.html) (We may want to keep these for the future, so I updated them with their new content and licence, but I left all the instances of SMF alone for now... I think I got everything.)

 ! r10566 This one didn't have a commit note but it ensures the board ordering for membergroup access is in the right order - it wasn't necessarily the case in either MySQL/InnoDB or PostgreSQL. (ManageMembergroups.php)

 ! r10569 I quote SVN: "Tweaked the install/upgrade/convert readme's for added grooviness." (readme_install.html, readme_update.html, readme_convert.html, readme_upgrade.html) (Not sure anyone even reads these though... the convert one was missed from the other changes, and the upgrade one was missed in this commit)

 ! r10570 Fixing the HTML5 validation link (index.template.php) [Bug 4740]

 ! r10571-2, r10574 Tweak how the URL is preprocessed to ensure it doesn't damage OpenID.

 ! r10573 Members only with manage membergroups permission could create groups that inherit from or based of off protected groups, and members having manage membergroups and moderate forum members could register members protected groups as their primary group. (ManageMembergroups.php, ManageRegistration.php, Subs-Members.php)

 ! r10576 Beginning the version bump saga. (index.php, install.php)

 ! r10580 All those headers changed in Sources/ and index/SSI/payment gateways (many files)

 ! r10582 Upgrader should now check for @version in index.php rather than the old file header (upgrader.php)

 ! r10583, r10585 Language files get version bumped, template files get version bumped, then they decided to add the new header... so two sets of big-ass commits. (Didn't version bump the language files new in Wedge)

 ! r10586 Make sure the right version is examined for 'view file versions' (Subs-Admin.php)

 ! r10588 Themes code should also be detecting the version format correctly too. (Themes.php)

 ! r10589 Templates don't have to be compared between their filename and their contents, we can use the version number listed inside now.

 ! r10591 More header cleanups, including a couple that I managed to miss. (Calendar.php, SplitTopics.php, Subs-Captcha.php, Subs-Graphics.php) (But still no Class-Graphics.php since I killed that.)

 ! r10593 Adding a missing die-if-not-declared test (Subs-MessageIndex.php, Subscriptions-*.php) (And they did some spacinazi changes, but I already fixed those anyway, plus I did it in all three payment gateways, rather than just the one.)

 ! r10595 Version bumps including for tests. (Search.php, Search2.php, SearchAPI-*.php, ssi_examples.php)

---

@ Not sync'd
 ! r10543 Tweak converter name (vbulletin 3)

 ! r10544 Copyright testing function changes, these had already been removed anyway and in any case functionality changed - they still figure out the version of SMF for SSI, we don't bother. (Oh, and removing $txt['am'] and $txt['pm'] again, probably due to unsync'd local copies)

 ! r10545 Fixing the previous break as well as adding ® to the trademark in the manual - which we don't have now.

 ! r10546 Credits updates that we're not keeping (non dev updates)

 ! r10550 Some minor style fixes that weren't relevant to us (mostly Core)

 ! r10551 Removal of the manage-copyright stuff, plus changing the footer - we've already done this to something we're happy with.

 ! r10552 PostgreSQL specific changes

 ! r10554-5 1.1 fixes and version bump, and patch

 ! r10556 Upgrader fixes for renaming old theme, and fixing known themes - but none of the code being changed even exists in our upgrade.sql, leads me to believe it's not relevant to us anyway.

 ! r10558 PostgreSQL specific changes to ManageSmileys.php

 ! r10559 Changing LLC to NPO in installer and upgrader scripts

 ! r10560 Mark Rose is also now credited as a consulting dev. Haven't seen a commit - but to be fair I have seen a fair amount of thoughts from him on improvement. Have not added to SMF cons. dev. yet but no objections to doing so.

 ! r10563 My name is already in our credits fully as opposed to just a pseudonym...

 ! r10567 PostgreSQL connections do allow spaces in usernames and passwords...

 ! r10575 Minor changes to news_readme.html that don't apply (version bump, moving the copyright)

 ! r10577 license.txt contains New BSD licence. Since we're not adopting that to start with...

 ! r10578 Spacinazi that we already did in a few files.

 ! r10579 Minor code cleanup in the converters only.

 ! r10581 Adding a space to their copyright in the installer footer... we already had it looking nice anyway.

 ! r10584 They changed the code I mentioned in r10544, so that SSI doesn't display a copyright at all as opposed to just using a versionless one like we do.

 ! r10587 We don't have to bump a ton of version numbers throughout the system to decache scripts and stylesheets.

 ! r10590 Changing the license.txt file in the theme directories to be BSD... but we never had those files in the first place.

 ! r10592 Tidy up the header in ssi_examples.php, but I already did that.

 ! r10594 Minor cleanup in headers (one file doesn't exist, the other was spacinazi I already fixed)

---

@ Did not add the new header to Wedge Media files, last time I played in there I broke things, so staying out of that for now.
 
@ Nao, please take a look at the change made in QueryString.php, urldecode not being called on URLs may have consequences for Pretty URLs I'm not currently aware of.

@ r10568 has not been included, and I'm not sure about including it. Basically it's the apparent "uberfix" for jumping edit boxes in IE, with the caveat that IE6/7 ends up with a funny width of some 600 odd px wide edit boxes. I don't think I can replicate it on Wedge so don't want to shove something like this in without good reason...

Which is what 2.1 should really be, ideally, fixing the bugs, adding the really important stuff (like IPv6 support), and clearing the legacy stuff, like the IE5 legacy code still lurking in SMF.

The difference is that 2.1 will be an SMF milestone but it's only part of the journey for us.

Right now it's a 2.1 alternative because most of what we want to do hasn't really been done yet... but it will.

The first step isn't writing sensible, understandable code, it's re-engineering the existing code to make more sense than it does now.

Yes, that's the one. It just seems a little incongruous...

Motoko isn't overly fond of me either, but what I will say is that he has an apparent dislike of drama whilst being more than dramatic himself most of the time.