Wedge

(6 modified, 1 new folder, 10KB)

Revision: 2103
Author: arantor
Date: 09 May 2013 22:12:33
Message:
! Likes were broken if for any reason you tried to immediately follow up on an (un)like with a reverse of it because the return value was not passed through the buffers, so return_raw() is out, but because return_text flushes buffers first, we have to start a new buffer, capture the content, then pass it to return_text(). Either that or rewrite the template to return values and then output from wherever it's called from. I'm satisfied with what I've done for now though. (Like.php)
+ Contact list is now shown in the PM area, allowing you to send a PM to/bcc your contacts. As I intimated I'm not overly happy with the JS I've done here, it feels fragile and ugly and yet more organised than before. Feel free to rewrite/refactor/ignite. (PersonalMessage.template.php, PersonalMessage.template.php, pm.js, index.member.css, PersonalMessage language file)
! As discussed, a new folder for notifiers to be put into for organisation. The folder needs to exist before SVN will accept the move. (notifiers)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/PersonalMessage.php
Added : /trunk/Sources/notifiers
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/scripts/pm.js
Modified : /trunk/Themes/default/skins/index.member.css

The comment made in that PM was made to me directly elsewhere, and I don't agree. I do not believe I would have had the same reprimand, verbal or otherwise, as xrunner had, had I done the same thing. Thing is, I've arguably done much worse and not had a single comment about it!

However, I am only too aware that a lot of this stuff is a matter of perception and that no-one's really that far in the right here :/

We all react to what we perceive - and he perceives an injustice. I perceive a sort of injustice too, but to a lesser degree. I also perceive that I didn't stay particularly involved in the thread in question because I knew ultimately where it would lead (exactly where it did). I also perceive there to be double standards above and beyond what would normally be expected on a forum, especially one that theoretically is supposed to be professional. I accept that double standards are inevitable, but that they should be curbed where possible.

I'm sorry, that is indeed somewhat misguided. I absolutely refuse to believe I would have been treated in the same way because of the number of times I have done similar things!

This comes up fairly often, so I have a proposal about this that would effectively solve all the issues around it (at least IMHO)

Have a flag attached to each PM to indicate 'saved' status. If a PM is 'saved', it cannot be deleted by the user unless they unsave it (feel free to change the word). This would allow users to delete in bulk without having to worry about accidentally deleting messages.

Then, the admin has the power to set a time on deleting messages that are not marked saved/locked/preserved/whatever you want to call it. The admin gets a control on cleaning up the database while users get the power to protect things they want saved that are important.

The lock feature would always be available to users regardless of anything else, while the deletion aspect would only occur if the admin turned it on and set a number of days - and that part would be off by default.

How does that sound to everyone?

The problem with the values is that it's only a requirement on the team's behalf. The team manual is also primarily for the team in terms of responding to users - thing is, neither xrunner nor I are team members.

Validity is fine :)

1) If you notice, he wasn't deciding whether it was a problem in SMF. He was trying to find out *why* it is a problem. Because, as quite rightly pointed out, spaces were added for a reason relating to readability. If there is a reason for not having the spaces for a given language, then it needs to be flagged up.

Since when did personal aesthetic preferences get flagged as bugs? I don't like the shade of blue in the header, is that a bug?

There IS a legitimate case of a rogue space that was a bug, but that was only a much later thing, the original topic did not have the unbalanced spaces in it.

2. This is why he was trying to get to the bottom of it. Is it a legitimate bug in SMF? Is it a personal preference? Is there a related bug?

The answers to which are no, yes, and yes. But blindly answering the guy's question would have seen them answers as yes, no and no, a very different picture.

A lot of the issue is that xrunner pushed it when others didn't - but if I hadn't realised what a stupid waste of time it would turn out to be, I'd have been pretty much the same. The question then becomes: would you guys have treated me any differently? The answer, of course, is yes. This is what it comes down to: one member is being hounded for being blunt with someone and others who have more standing in the community are not, even when objectively their attitude can be perceived to be worse.

I'd rather have a well thought out UI that doesn't use AJAX than a poor one which does.

I will reserve my comments about Joshua for another venue. (Suffice to say I consider him in much the same league as I do Labradoodle, that should tell you everything you need to know)

The biggest problem with sm.org is that the rules are unspoken and vague and not consistently employed as a result.

The 'mushy' 'we're all human' is true. We are all human, we do interpret different things in different ways, but having some guidance on what is appropriate behaviour and what is not would go a long way. It'd probably even curb my temper at times. The problem is that having rules is perceived as though it would curb creativity and people having their say, and that's historically been a huge problem with sm.org as a whole - and to me, it's one reason why things aren't working, consistently and thoroughly across the board.^^ This. You'll find the install and upgrade board is friendlier because the grumpier folks don't go there. It's mostly a conscious decision not to so that newbies aren't put off immediately ;)

There is an unspoken set of rules for each board. Some have a more explicit 'we'd like you to post xyz' but it never really works out.

And Runic is right, everyone's opinion IS valid. It may be based on incomplete or incorrect facts but it is a valid opinion nonetheless. The problem is that there are those who shout down valid opinions for apparent invalidity.

OK, I found a bug, I wanted to pull up the UI for something here, but something very strange happened.

Specifically, a warning for the post above mine here (at least, there was something random I wanted to check out), now there's an error regarding issue_warning_self, I'll fix that in a minute.

But here's the weird part. The above post generates the URL:

profile/?u=1;area=infractions;warn;for=post:288772

Not profile/Nao as would normally be generated, which makes it pull up *my* profile for some reason which upsets the infractions code by rightly telling me that I can't issue a warning to myself (or it would if I didn't flub the error message definition)

I'm guessing it's related to the fact I have a hokey parameter in the URL but I'm willing to amend the formatting if that's any help.

@Nao, I'm really not comfortable touching pretty URLs code, so I'd like you to take a look at it but if that means altering the format to post.id rather than post:id, that's fine.