Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
6871
Features / Re: New revs - Public comments
« on August 1st, 2011, 11:49 PM »
I think we should keep unapproved separate from deleted, not only for semantic reasons, but also because access to recycling is a different permission to access to (own/any) moderated posts.

Not only would you filter them differently, you'd probably have different UI for the different types of posts; if you delete something, you're indicating that you want it out of the way, as opposed to something not yet made live.

I'd also note that I don't particularly like the idea of unapproved posts/topics being used for future-dated/blog type posts, I'd rather keep them out of the loop (keeps the main table leaner which always helps in performance terms)
6872
Features / Re: New revs - Public comments
« on August 1st, 2011, 11:13 PM »
Quote
It's all handled logically if we use post statuses to delete them.
On a technical level we can solve it like that, but we need to handle the UI a little differently; to me, the concept of using unapproval to actually 'delete' doesn't seem to sit quite right with me.
6873
Features / Re: New revs - Public comments
« on August 1st, 2011, 10:38 PM »
Quote
The only point is to have only two strings for the day list, as opposed to a dozen
*facepalm* Yes, good plan.
Quote
Re: recycle bin, I thought we'd agreed (although it was long ago...) that we ccould simply do it like here: a Hide (Unapprove) button that would set posts to status!=1 or something...
That wasn't the plan from what I remember; we didn't really get into any conclusion as to what we wanted to do,   just getting rid of the existing bin setup for something cleaner.
6874
Features / Re: New revs - Public comments
« on August 1st, 2011, 10:16 PM »
Quote
* I thought it would be amusing if the redirection topic strings actually used number_context()... (index.language.php, MoveTopic.template.php)
I was in two minds about that. I basically stole the code from my own mod there for that part, didn't see too much point reinventing the wheel.
6875
Features / Re: New revs - Public comments
« on August 1st, 2011, 10:04 PM »
Yes, when we figure out how we're going to handle deleted-but-not-really-deleted posts.
6876
Features / Re: New revs
« on August 1st, 2011, 05:55 PM »
Revision: 902
Author: arantor
Date: 16:52:27, 01 August 2011
Message:
+ Provide the ability for people moving a topic to set how long the topic redirection notice stays in place for. (MoveTopic.php, MoveTopic.template.php, Subs-Scheduled.php, index.english.php)

! Miscellaneous layout bug in the move topic template, due to overwide dd forcing wrapping rather than floating. (sections.css)

! Miscellaneous bugs in the imperative scheduled system (Load.php, Subs-Scheduled.php)

! The recount-reports function is sometimes going to be run when permissions aren't loaded (namely during scheduled/imperative tasks), make sure the mod cache is loaded in that circumstance. (ModerationCenter.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css



@ This isn't really finished, it's just at a convenient stopping place. The default is 1 day simply because it's at the top of the list, not because it's set that way - but that's actually an improvement in usability terms to the previous version IME. I haven't decided about allowing admins to set a default yet.

@ See also the discussion about dealing with redirections automatically; the way I solved it in the redirection topics mod I originally wrote was a separate table. Given the minimal approach I wanted to SMF modding at the time, this was the closest I could get, and it would only clean up once per day rather than actually as needed, so the individual table was useful then.
6877
Features / Re: New revs - Public comments
« on August 1st, 2011, 05:39 PM »
We're already storing one of those for deleted posts. I guess we could make the inference that if it's got a previous board id and isn't in the recycle bin, it's a moved topic.

That makes sense until you realise you can move topics in and out of the recycle bin freely if you have the relevant permissions.
6878
Features / Re: New revs - Public comments
« on August 1st, 2011, 05:03 PM »
I never tested it that thoroughly either seeing as I had nothing to plug into it but I'm adding the guts of my redirection topics mod so that you can set moved notices to disappear automatically after a few days.

I haven't yet decided about making moved notices auto redirect, since that could get nasty if not done properly. (There is no actual reliable way to know if a topic is a moved notice. Yes it has an icon and a given subject but the icon is not checked during the post routine...)
6879
Features / Re: New revs - Public comments
« on August 1st, 2011, 04:34 PM »
No... the original code had an in_array to select only the regions of interest, and IIRC there was an isset for something else at the end before actually adding it to the loop but off hand I can't remember what.

Right now am dealing with the fact that the imperative scheduled system is completely broken (and in fact I'm dubious about how it ever worked when I tested it originally because it shouldn't have done), will commit that when I've fixed it and finished the feature that actually uses it.
6880
Features / Re: New revs - Public comments
« on August 1st, 2011, 04:28 PM »
Bah, I missed the array_flip, thinking you were just doing the isset check on it at the end and that it wouldn't work as expected then...
6881
Development blog / Re: Now with 97% more visuals!
« on August 1st, 2011, 03:41 PM »
Quote
Ah, color blindness... I never seem to be able to take that into consideration when doing my stuff.
Actually, none of your stuff seems to have contrast in the areas that typical colour blindness would have a problem with.
Quote
It's not really out of date,
I meant the UI document itself; it has all kinds of screenshots of very old institutions - it was last updated in 2003.
Quote
I understood from it that the only 'safe' colors to use are non-primary colors really...
Pretty much, yes.
Quote
Exactly -- we're building for the Western area. We can worry about the rest of the world later.
Good plan!
6882
Features / Re: New revs
« on August 1st, 2011, 02:49 PM »
Revision: 901
Author: arantor
Date: 13:49:16, 01 August 2011
Message:
! First part of handling timezones from user perspective, there's no interface for it yet but it works from the database. (install.sql, Load.php, ManageSettings.php)

! The title derived from the current URL should not have a leading space. (install.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
6883
Features / Re: New revs - Public comments
« on August 1st, 2011, 02:32 PM »
Quote
I've dealt with the existing _n plurals in rev 900, too. And added one that was in the index language file. Should be a good start
Looks good to me :) The other stuff that does need doing really is the rest of the message index and the display - these are the user visible stuff, the rest of the things that need doing aren't really user visible but admin stuff primarily.
6884
The Pub / [Archive] Re: Logo Madness
« on August 1st, 2011, 02:28 PM »
The one in reply 350 reminds me of a Nintendo Wii console, with the funny lower edge bracket it has.

As for the one in reply 352 I like it, more than I like r350's but I'd grown attached to the two-triangle logo rather than the one-triangle those use. It's still good looking, and I think it fits our colour scheme better like that than the earlier logos.

But that's just me.
6885
Features / Re: New revs - Public comments
« on August 1st, 2011, 11:06 AM »
Quote
Again, I didn't touch the timezone code. I only fixed the loop that retrieves them, to ensure it won't generate a warning on the list (,) code (since UTC doesn't have a comma and thus throws out an error when splitting it.)
Yeah, that's what I meant; I've fixed the loop myself separately, but I'll fix it when I commit what I do have.
Quote
I suppose we could have used it more, though
Yes, it can be used more, because it's not heavy in itself, it's only heavy if comma_format wasn't being used already, but the places that occurs are not common.
Quote
So, who's going to convert the rest of the plural thingies?
That one's on my todo list.