Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
676
Features / Re: New revs
« on May 14th, 2013, 06:24 PM »
(83 files, 7KB)

Revision: 2114
Author: arantor
Date: 14 May 2013 17:23:27
Message:
! Removing the << toggle from the areas with generic menus. (Admin.php, Subs-Menu.php, GenericMenu.template.php)
! Getting rid of an old friend from the moderation centre, related to the old warning system. (ModerationCenter.php)
! Getting rid of what look like some unused global variables. I haven't been able to get errors out of anything with this. (all files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/Mailer.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageLanguages.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Pin.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Captcha.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-List.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/Class-Media.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/GenericList.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/Sphinx/SearchAPI-Sphinx.php
Modified : /trunk/other/Sphinx/sphinx_config.php

(I have a feeling the Sphinx stuff will become a core feature at some point, just needs some updating and tweaking)
677
Off-topic / Re: I Can't Install SMF 2.1 Alpha
« on May 14th, 2013, 03:44 PM »
It's not a fix. All it means is everything up to the end of that operation was successful, that is the last thing that fails, so moving to the next number is what would have happened anyway.
678
Off-topic / Re: I Can't Install SMF 2.1 Alpha
« on May 14th, 2013, 02:37 AM »
Incidentally I know EXACTLY what caused this because I had to go poking around for something else.

And I have to say, it's sheer fucking incompetence. I left them a comment on Github as to what's wrong and why it's wrong. I don't see how he even tested it.

For those playing along at home, Lab added a feature whereby users can set the registration mode (no registration, immediate registration, member approval etc.) during registration. Except the genius managed to put the query into the code BEFORE THE SETTINGS TABLE IS EVEN MADE.

Now, he's already convinced I'm trolling him (cf. the comments on 2.1's repo from HappyTroglodyte which he thinks is me, when it's not) so I left the commentary here and left merely a factual report plus a suggestion *there*.

Now I've broken the installer in the past, but I wouldn't commit something I clearly couldn't have tested properly (or if I do, I leave a note to that effect)
679
The Pub / Re: I am asking my users for ideas
« on May 14th, 2013, 01:26 AM »
The half-assed solution would of course be to just lock the topic with a note that it will be reopened shortly, and just leave the tab open in your browser.

Smells like plugin material to me, but that's no big deal either.
680
Off-topic / Re: I Can't Install SMF 2.1 Alpha
« on May 13th, 2013, 07:48 PM »
I have only tried 2.1 once, some months ago. It worked fine then. I am one of the leading folks who knows about 2.0, but I would not say I have explored the code of 2.1, because I haven't. I have, however, questioned several of the things they introduced in 2.1.
Quote
Please can you tell me what am missing, according to the instruction, I am to create a Settings_bak.php which is not in the folder, copy the content of Settings.php ans paste it there. I don't know if I am missing any other thing?
The error suggests the database was not set up properly.
681
Off-topic / Re: I Can't Install SMF 2.1 Alpha
« on May 13th, 2013, 07:20 PM »
Nope. Not sure why we would know, either.
682
Off-topic / Re: Doctor Who
« on May 13th, 2013, 06:57 PM »
Are you talking about the first or second season of OUaT? I thought actually that the tying up of season one with Pinocchio was quite smoothly done actually.
683
The Pub / Re: Print Page
« on May 13th, 2013, 06:56 PM »
That's another change I made and forgot about then because when I first wrote it, it definitely was 'unknown'.

Wanchope is right: even if it is marked nofollow, Google will still view it, it just doesn't consider it for link juice following purposes, which isn't the same as noindexing.
684
The Pub / Re: Print Page
« on May 13th, 2013, 06:26 PM »
I don't really mind though my gut sort of says not to since PHP doesn't really behave that way (it's sort of an inheritance from Java's ideals concerning isomorphism). Just remember to update parse_bbc_inline with similar semantics.

As far as Google safeguards go, I'd argue it shouldn't even be indexed in the first place because it's not strictly duplicate content.
685
The Pub / Re: Print Page
« on May 13th, 2013, 03:59 PM »
Huh, forgot about the previous post as it was on the previous page.
Quote
- I'm okay with Print being a plugin; don't remember if I was before, but it just doesn't feel that important, after all... What could be improved, really, is giving the admin to ability to only print the current page's worth of posts, and/or only print the entire topic if it has less than X pages. With maybe a (single) page index inside the print page itself, to allow easy printing of multiple pages.
It wasn't a plugin before, but it strikes me how little it's really used so it might as well be a plugin. But being a plugin I can do all kinds of crazy with it. I've been thinking, for example, about making export-topic-to-PDF be an option though pagination gets tricky with that.
Quote
but suddenly it hit me that you can disable some tag types on some parse types, or hook a plugin into any type of parsing and just that one... The possibilities seem limitless.
That's the reason for being verbose in specifying all the different types.
686
Bug reports / Re: Infraction bugs
« on May 13th, 2013, 03:55 PM »
I'm really not that worried about language changes. Most of this stuff is Just My Opinion (tm) and if others have better suggestions I'm all for changing them.

As long as the language is consistent to users, I don't really mind.

All I'd say is that I started from the premise that a warning is just a warning, a message just to say 'don't do it again', and that infraction is 'don't do it again and because you've been naughty...' whereas sanction... here you only hear it on the news in context of the UN blocking aid/support to countries.

Punishment and penalty are somewhere around infraction on the scale of 'strength of terminology'. But seriously, if people prefer different terms, let's do it.
687
Features / Re: New revs - Public comments
« on May 13th, 2013, 03:51 PM »
Quote
And we could do the checking at save time in ModifyPostEditorSettings.
Sure we could. I'm just doing what I did before with the list of fonts, and that I seem to recall I borrowed from the old reserved names code.
Quote
Do you see any uses for disemvowel and scramble functions? Maybe just copying their single-line contents into the main codepath would be enough? I'm not worried about disemvowel(), but scramble() might conflict with other functions with the same name. You never know -- adding an encryption library, or something like that...?
I suspect there won't be any separate uses so yeah, they could go.
Quote
I find myself with having to determine a number of points to give... Why should I, when I can just select a list of pre-defined sanctions, such as hiding the signature...?
Technically it shouldn't be forcing you to pick some points but there are circumstances where for performance it just assumes 0 points = no current infractions on the account.
Quote
Or maybe it's admin-only and I should look at how it works for mods?
It sort of is. Admins have all the powers, but moderators may or may not depending on what they are given. If a member group is not given ad-hoc infraction powers, the only choices they have are the pre-set ones allocated to their account. The idea is that you set up pre-set ones which cover all the standard cases which makes issuing them little more than a few clicks.

You could always set up a pre-set infraction that doesn't have any points and just removes the signature - then you wouldn't even have to type up the warning text next time, it would be defined ready for you. At least, that's the theory ;)

But I'm more than happy to change it if we find better ways of doing things.
Quote
Done with the checks. Overall, great work!
Thanks :)
688
The Pub / Re: Print Page
« on May 13th, 2013, 03:25 PM »
Yeah, let me explain what happened. Initially, it was $type, then I remembered that $type was a variable used in the bowels of the system so I made the variable $parse_type but forgot to update the function reading the parameter.

If you want to move it, that's cool, I just didn't think of that. The alternative, of course, is to make post the default rather than 'unknown' and strip the parameter from any 'post' call since posts are the predominant use.

As far as owner ID goes, there's a certain logic to that. Partly because most places never had it in the first place, but secondly it's down to context. Right now owner ID is only relevant for scramble/disemvowel. But that essentially relies on $user_profile being populated with more than 'minimal' type, and without that it doesn't do anything. And of course, we need to consider whether it's appropriate - for example, I'm not sure that it would be appropriate to disemvowel or scramble posts in the Atom feed or the signature for that matter. I don't know.

I'm also cool with using 'user' rather than 'owner'.
689
Features / Re: New revs
« on May 13th, 2013, 02:49 AM »
(2 modified, 6KB)

Revision: 2112[1]
Author: arantor
Date: 13 May 2013 01:48:08
Message:
! Actually get the board index using the last report and last group request. I am aware the count is still wrong for requestable groups but that's mostly down to the current fundamental flaws in requestable groups. (ModerationCenter.php, Subs-BoardIndex.php)
! Don't show the group requests option in moderation centre if there aren't any requestable groups at present. (ModerationCenter.php)
----
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Subs-BoardIndex.php
 1. I want my life back, Jeff Minter! Llamatron stole too many hours from me as well as Revenge of the Mutant Camels!
690
Features / Re: New revs
« on May 13th, 2013, 01:02 AM »
(51 files, 34KB)

Revision: 2111
Author: arantor
Date: 13 May 2013 00:02:22
Message:
! New user sanction: scrambling the letters of each word except the first/last letter. (ManageInfractions.php, Subs-BBC.php, ManageInfractions.english.php)
! New admin page for configuring the bbc editor. The plan is to have a drag 'n' drop thing to move the buttons around too but I haven't gotten to that yet. Apologies, Nao, code is a shade ugly :( (Admin.php, Class-Editor.php, ManagePosts.php, editor-func.js, editor.js, Admin and ManagePosts language file)
! Refactored parse_bbc semantics, as documented in Subs-BBC.php. This new setup allows us to expand upon things like not parsing embeds for signatures into things like not parsing embeds for feeds too. Just a thought. I don't think I broke anything, I checked for syntax errors everywhere (automatically) and checked the list of parse_types, should be all good. (all the other files)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageInfractions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrintPage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Thoughts.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/UnreadReplies.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/media/Aeva-Embed.php
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/Aeva-ModCP.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/Media.template.php
Modified : /trunk/Themes/default/Thoughts.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageInfractions.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.english.php
Modified : /trunk/Themes/default/languages/ManagePosts.french.php
Modified : /trunk/Themes/default/scripts/editor-func.js
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/root/install.sql