Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
6046
Features / Re: New revs - Public comments
« on October 9th, 2011, 12:38 PM »
With the changes to user, I had to specify a parameter (error type is param 2, sprintf vars is parameter 3). Where the type was specified I was fairly sure I'd got it right and where it wasn't specified (and thus it would be logged as general), I changed it, at the time it seemed more logical to flag it as a user error rather than a general error. It's not a general error in processing, it's because the user has done something wrong - and that to me makes more sense to flag as a user error.
Yes, Core Features is buggy and has been for some time due to an extra hide class in the template but as Nao says I'm looking to do away with it in due course so it's not like I've been worried about fixing it.
And I thought I'd fixed all the brackets but I guess I missed a couple :(
Yes, Core Features is buggy and has been for some time due to an extra hide class in the template but as Nao says I'm looking to do away with it in due course so it's not like I've been worried about fixing it.
And I thought I'd fixed all the brackets but I guess I missed a couple :(
6047
Features / Re: New revs
« on October 9th, 2011, 03:04 AM »
Revision: 1076
Author: arantor
Date: 02:04:03, 09 October 2011
Message:
! Allow spoiler=content format to set the text displayed in the button itself. Quoting should be optional, bbc should not be parsed at all in the button's text (mostly because it's not supported by browsers anyway) (install.sql)
----
Modified : /trunk/other/install.sql
Author: arantor
Date: 02:04:03, 09 October 2011
Message:
! Allow spoiler=content format to set the text displayed in the button itself. Quoting should be optional, bbc should not be parsed at all in the button's text (mostly because it's not supported by browsers anyway) (install.sql)
----
Modified : /trunk/other/install.sql
6048
Features / Re: New revs
« on October 9th, 2011, 02:05 AM »
Revision: 1075
Author: arantor
Date: 01:04:43, 09 October 2011
Message:
! More cleanups of fatal_error to fatal_lang_error (including a few I broke last time in error) and cleaned up a language string or two, hopefully without getting the French translations totally wrong. Note that there's a couple of interesting fixes in there in the process. (Activate.php, Aeva-Gallery.php, Packages.php, Post2.php, Security.php, index and Post language files)
! Fix for strange error I made porting one of the last SMF patches. (Subs-Boards.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Author: arantor
Date: 01:04:43, 09 October 2011
Message:
! More cleanups of fatal_error to fatal_lang_error (including a few I broke last time in error) and cleaned up a language string or two, hopefully without getting the French translations totally wrong. Note that there's a couple of interesting fixes in there in the process. (Activate.php, Aeva-Gallery.php, Packages.php, Post2.php, Security.php, index and Post language files)
! Fix for strange error I made porting one of the last SMF patches. (Subs-Boards.php)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
6049
Features / Re: New revs
« on October 9th, 2011, 01:42 AM »
Revision: 1074
Author: arantor
Date: 00:35:55, 09 October 2011
Message:
! Fixing a long-standing, much irritating (to me) grammatical error. (Errors language file)
! Display what the user is doing in their profile, assuming who's online is enabled and you have permission to view it. (Profile-View.php, Profile.template.php, Profile language file)
! Some language cleanups, converting some fatal_error to fatal_lang_error calls, plus especially cleaning up some cases where strings were bolted together before being sent to fatal_error, with the side benefit that they're actually more translatable now as a result. (Activate.php, ManageMaintenance.php, ManageServer.php, Memberlist.php, ModerationCenter.php, Packages.php, Profile-Actions.php, Reminder.php, SplitTopics.php, Profile language file)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Author: arantor
Date: 00:35:55, 09 October 2011
Message:
! Fixing a long-standing, much irritating (to me) grammatical error. (Errors language file)
! Display what the user is doing in their profile, assuming who's online is enabled and you have permission to view it. (Profile-View.php, Profile.template.php, Profile language file)
! Some language cleanups, converting some fatal_error to fatal_lang_error calls, plus especially cleaning up some cases where strings were bolted together before being sent to fatal_error, with the side benefit that they're actually more translatable now as a result. (Activate.php, ManageMaintenance.php, ManageServer.php, Memberlist.php, ModerationCenter.php, Packages.php, Profile-Actions.php, Reminder.php, SplitTopics.php, Profile language file)
----
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
6050
Features / Re: New revs
« on October 9th, 2011, 01:36 AM »
(Oops meant to post this one earlier.)
Revision: 1073
Author: arantor
Date: 19:19:18, 08 October 2011
Message:
! Provide support for extending the visual verification system, including a hook for the relevant admin page. (ManagePlugins.php, ManageSettings.php, Subs-Editor.php, GenericControls.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Revision: 1073
Author: arantor
Date: 19:19:18, 08 October 2011
Message:
! Provide support for extending the visual verification system, including a hook for the relevant admin page. (ManagePlugins.php, ManageSettings.php, Subs-Editor.php, GenericControls.template.php)
----
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
6051
The Pub / [Archive] Re: Logo Madness
« on October 9th, 2011, 01:02 AM »
Logo primarily. I have to admit my eye is drawn far more to the logo than the font, but I do like the sturdier font of the comma and claw5 ;)
6052
The Pub / [Archive] Re: Logo Madness
« on October 9th, 2011, 12:51 AM »
For me it's a toss up between the first one you posted and claw5, but I think the first one wins by a whisker.
6053
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 9th, 2011, 12:50 AM »
Awesome, I've commented on a very limited number for now, there's a lot to take in there!
6054
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 8th, 2011, 11:35 PM »
Well, ideally yes, but there's no reason why it can't be done on topic subjects. The headache is performance, the standard solution is to create a separate table of topic subjects and perform a search on those using a fulltext index or something like Sphinx.
The headache, of course, is that such a table would have to be done manually (it always would, because it must be a MyISAM table with a fulltext index, a setup that will soon be going drastically out of fashion as MySQL 5.5 becomes more and more commonplace) or else some other solution devised.
Need more time to mull over the exact implementation of that one, so maybe will do edit history instead.
The headache, of course, is that such a table would have to be done manually (it always would, because it must be a MyISAM table with a fulltext index, a setup that will soon be going drastically out of fashion as MySQL 5.5 becomes more and more commonplace) or else some other solution devised.
Need more time to mull over the exact implementation of that one, so maybe will do edit history instead.
6055
The Pub / Re: Spell checker
« on October 8th, 2011, 11:19 PM »
* No reasonable way to extend the system in any useful manner (e.g. the hurdles SD/WD have to do)
* Attachment folders are limited by size not number of files, and there's no automatic failover to a separate folder to prevent any given folder getting too big (in any case, the folder handling should not be based on linear progression, would be much better doing similar to what MediaWiki does, which encourages spreading files more equally by folder than simple progression does)
* Avatars are not in their own folder by default (frankly, I'm thinking about forcing them all to be in their own folder, and then ripping out the code that serves avatars through the system, there's really not a lot of reason to do so if avatars are tested against bad stuff up front)
* Attachment folders are limited by size not number of files, and there's no automatic failover to a separate folder to prevent any given folder getting too big (in any case, the folder handling should not be based on linear progression, would be much better doing similar to what MediaWiki does, which encourages spreading files more equally by folder than simple progression does)
* Avatars are not in their own folder by default (frankly, I'm thinking about forcing them all to be in their own folder, and then ripping out the code that serves avatars through the system, there's really not a lot of reason to do so if avatars are tested against bad stuff up front)
6056
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 8th, 2011, 11:16 PM »
Sure :)
I was deciding between doing some kind of 'related topics' thing or some kind of 'storing post edit history' this evening. The former has some interesting quirks about it that make it a PITA to do, while the latter really depends on having the wesqlQuery stuff in place (though I have no reason not to get that integrated, really)
I was deciding between doing some kind of 'related topics' thing or some kind of 'storing post edit history' this evening. The former has some interesting quirks about it that make it a PITA to do, while the latter really depends on having the wesqlQuery stuff in place (though I have no reason not to get that integrated, really)
6057
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 8th, 2011, 10:40 PM »
I'm now contemplating what to tackle next, knowing full well that each plugin I'm writing at the moment, I'm almost certainly going to be introducing new hooks each time to support it because of the lack of hooks currently in the system.
6058
The Pub / Re: Spell checker
« on October 8th, 2011, 10:38 PM »
Well, yes and no. There are quite a few limitations in the current attachment system, that can't be remedied without a significant amount of work - the quantity of which is probably not that far off what's needed to be able to use Aeva for attachments and avatars.
6060
Plugins / Re: Personal plugin showcase (yes, I'm an attention grabbing git)
« on October 8th, 2011, 08:22 PM »
And now I've implemented the rest, and as far as I can tell, it seems to work as expected.
Screenshot from IE8 attached. I'm not proud of this one particularly, because reCAPTCHA makes certain expectations that I had to work round, namely none of the usual JS functions could be used, the script has to be injected into the template where you want it displayed, rather than using any of the delay functions. Which sucks, especially in the quick reply since it'll actually load prior to any of the Wedge stuff, but it IS using the reCAPTCHA-own URL, so it should be cached.
It's also translatable, which is cool, and the language file is set up to allow that. Just need to throw a readme together before I commit it to the repo.
In other news, yes, this is the quick reply dialogue. You can see one of the new CAPTCHA types in Wedge, an animated-fade-in style (designed and implemented by me), plus the ability to switch to the full editor in a snap.
I really need to make it styleable, though, I don't think I made it so either the plugin or the parent hooks actually are directly styleable (e.g. getting them centralised) but it's hardly a priority.
Screenshot from IE8 attached. I'm not proud of this one particularly, because reCAPTCHA makes certain expectations that I had to work round, namely none of the usual JS functions could be used, the script has to be injected into the template where you want it displayed, rather than using any of the delay functions. Which sucks, especially in the quick reply since it'll actually load prior to any of the Wedge stuff, but it IS using the reCAPTCHA-own URL, so it should be cached.
It's also translatable, which is cool, and the language file is set up to allow that. Just need to throw a readme together before I commit it to the repo.
Posted: October 8th, 2011, 08:11 PM
In other news, yes, this is the quick reply dialogue. You can see one of the new CAPTCHA types in Wedge, an animated-fade-in style (designed and implemented by me), plus the ability to switch to the full editor in a snap.
I really need to make it styleable, though, I don't think I made it so either the plugin or the parent hooks actually are directly styleable (e.g. getting them centralised) but it's hardly a priority.