Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
61
Archived fixes / [function.preg-replace-callback] Re: : Requires argument 2, 'wedit:format_time'
« on August 19th, 2013, 03:19 AM »
Hmm, that looks to me like it should read wedit::format_time (double colon, not a single one)

I still haven't caught up reviewing all the commits from while I was away.
62
Off-topic / This is why I complain about tracking hits
« on August 19th, 2013, 01:30 AM »
No-one seems to understand why I complain as much as I do about the fallacy of maintaining a hit count.

Well, here's a perfect example. We have 9 users online. 2 are real, 6 are already logged as bots, the last one is... shock horror... a bot too.

Yup, that means that 77% of the users online when I just looked at not actual users. I don't think I've seen it go below 50% in the last few weeks (whenever I've been able to look)

Since we can't always keep an eye out for bots, and can't always keep the list up to date, seriously can't we just stop counting the number of online people yet? Or at the very least stop counting the records? (I still don't even want them shown to admins, to be honest, I'd rather just not track them)
63
Features / Re: Soft merging of posts
« on August 19th, 2013, 01:20 AM »
Oh, I'm around but I was trying to figure out how to reply but since we're here... I love the idea. The implementation... not so much. But not for the obvious reason.

We still have the non-zebra striping issue (e.g. previous page, reply 20 has postbg, replies 21-22 are postbg2, reply 23 should logically be postbg but is postbg2, 24-25 are postbg, 26 is postbg as well)

I also don't see themers actually bothering to do anything creative with the templates when, to be blunt, this is going to make them fragile. This is the problem we're going to run into more and more; cool stuff gets implemented but it screws up on anything that isn't the exact structure we've set up.

Does it, for example, work in any other skin? (Haven't tested) And we only have a few skins here. What it will guarantee going forward is that virtually every skin just becomes a knock off of the defaults with slight colour variations because no-one will bother to customise them at all for fear of breaking anything.

Now, that's not unheard of - XenForo and IPB are largely in the same rut but they're not actually as deeply into it as we are, pretty much everything there is still customisable without too much pain but with us it's just going to get worse.

I don't know if that's a trade off you're willing to make, ultimately.

The only way it might work is if it's not really toggleable as such but that themes can override and disable it and just have it that way.


Thought: why are we doing the zebra striping in classes? Can't we just use :nth-child(odd) and :nth-child(even) to handle that? I can think of other places that would be nice (like the thoughts on the front page, it always feels weird when we do anything odd with it)

It also means that infinite scrolling never fights with these issues, and that my dream of AJAX quick reply never has to care either. And it's totally controlled by the style rather than wrangling with template code so the templates get smaller too! (since you don't need postbg, postbg2 alternation, you just declare postbg or even don't bother with that, and just control it straight from CSS)

In fact, the only modern browser that doesn't support it is IE 8 and we can just provide them a default for that without alternation which is fine by me.
64
Features / Re: Soft merging of posts
« on August 18th, 2013, 07:09 PM »
Scrolling up and down this page I can see issues too... e.g. the userboxes from reply 26 and 27 sometimes overlap when scrolling.

It's always one of those things, we can make it crazy powerful but there are going to be issues with people wanting to customise it. Perhaps it would be better to keep it simple?
65
Features / Re: Soft merging of posts
« on August 18th, 2013, 05:19 PM »
While I was replying to http://wedge.org/code/8240/login-info-local-storage/ I noticed this bug. Chrome 29.
66
Other software / Re: Arguments about the credits
« on August 16th, 2013, 05:30 PM »
That is something I've been meaning to do though ;)
67
Other software / Re: Arguments about the credits
« on August 16th, 2013, 05:21 PM »
The base distribution uses it for multiple attachment uploading, since we still haven't integrated your AJAX drag 'n' drop file uploading into the core.
68
Other software / Re: Arguments about the credits
« on August 16th, 2013, 05:07 PM »
Eh, I still think the contributors file is the way to go here... it's still a WIP but...

Code: [Select]
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMND8O$$$ZODNMMMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMN87???????????????7DMMMMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMN8$????????????????????????$NMMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMM87???????????????????????????????ZMMMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMM7??????????????????????????????????????OMMMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNDOZ7I??????????????????IOMMMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM8Z????????????????MMMMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMDZ7???????????$MMMMMMMMMM
MMMMMMMMMMMMMDO$7777777$$ZODNMMMMMMMMMMMMMMMMMMMMMMMZ?+?????????ZMMMMMMMMM
MMMMMMMMMNI=======================+?7O8NMMMMMMMMMMMMMMMNZI????????DMMMMMMM
MMMMMMMMN+===============================+7ZNMMMMMMMMMMMMM8I???????8MMMMMM
MMMMMMMZ=======================================IZNMMMMMMMMMMMD$?????MMMMMM
MMMMMN7=============================================ONMMMMMMMMMDI???$MMMMM
MMMMN?=================================================+7NMMMMMMMMZI?$MMMM
MMMM?===================++??I7$ZOOOO888OOZ$$7I?+++========+$NMMMMMMM7+ZMMM
MMMM===========I7Z8NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMNDO$?====?MMMMMMMONMM
MMMZ===++78NMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMN8??DMMMMMMMM
MMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM
(ASCII rendition courtesy GlassGiant.com)

Wedge is a modern forum system built in PHP and MySQL.

Wedge Developers: Nao 尚 (René-Gilles Deberdt)
Arantor (Peter Spicer)

Contributions: Dragooon (Shitiz Garg)
live627 (John Rayes)
TE (Thorsten Eurich)


Wedge contains code and elements from other products, in no particular order:

== Code ==

Simple Machines Forum 2.0.x
-- © Simple Machines and its contributors 2011, http://www.simplemachines.org/
-- used under the Modified BSD license.

Bad Behaviour 2.1.x
-- © Michael Hampton 2011, http://bad-behavior.ioerror.us/
-- used under the LGPL v3 license, http://www.gnu.org/licenses/lgpl.html under 4) as a Combined Work
-- 4a: notice here given.
-- 4b: a copy of the LGPL and GPL text is not bundled to discourage misrepresentation of overall license terms.
-- 4c: the credits page indicates Bad Behaviour's use.
-- 4d0: the Minimal Corresponding Source is available upon request however in isolation will be of little practical use due to intra-application dependencies.
-- 4e: not applicable.

WeNotif
-- © Shitiz Garg 2012, [url]https://github.com/Dragooon/WeNotif[/url]
-- used under the Modified BSD license.

Move Notifier
-- © John Reyes 2013
-- used under the Modified BSD license.

MultiAttach (multiple attachment selector)
-- © The-Stickman.com 2005, http://the-stickman.com/web-development/javascript/upload-multiple-files-with-a-single-file-element/
-- used under the MIT license, http://opensource.org/licenses/mit-license.php

jQuery nestedSortable
-- © Manuele J Sarfatti 2010-2013, [url]https://github.com/mjsarfatti/nestedSortable[/url]
-- used under the MIT license, http://opensource.org/licenses/mit-license.php

getID3 (media file information)
-- © James Heinrich 2013, http://getid3.org/
-- used under the MPLv2

Exifer (originally Exifixer; extracts EXIF information from digital photos)
-- © Jake Olefsky 2005, http://www.offsky.com/software/exif/index.php ; Zenphoto 2013, [url]https://github.com/zenphoto/zenphoto/blob/master/zp-core/exif/[/url]
-- used under the GPLv2

JW Player 4.4.157 (media playback)
-- © Long Tail Video 2013, http://www.longtailvideo.com/jw-player/
-- free version, suitable only for non-commercial sites - for commercial sites, contact LongTail Video, or disable use of video/audio in the media gallery.

Yahoo UI Uploader (Flash/AJAX mass uploader)
-- © Yahoo! Inc., 2006-2013, http://yuilibrary.com/
-- used under the Modified BSD license

FancyUpload (mass uploader progress bars)
-- © Harald Kirschner 2008-2009, http://digitarald.de/project/fancyupload/
-- used under the MIT license

== Images ==

FamFamFam Flags, FamFamFam Silk icons
-- © Mark James 2005, http://famfamfam.com/
-- Silk used under the Creative Commons Attribution 3.0 license, http://creativecommons.org/licenses/by/3.0/

Diagona, Fugue
-- © Yusuke Kamiyamane 2013, http://p.yusukekamiyamane.com/
-- used under the Creative Commons Attribution 3.0 license, http://creativecommons.org/licenses/by/3.0/

Crystal Clear
-- © Crystal Project 2001-2012, http://commons.wikimedia.org/wiki/Crystal_Clear
-- used under the LGPLv3, http://www.gnu.org/licenses/lgpl.html
-- no code linkage, some images renamed

It's not practical nor entirely reasonable for us as a separate project to list everyone who worked on SMF - but we do note that it had other contributors who weren't/aren't necessarily team (i.e. SMF "and its contributors")

* Arantor is aware we have a couple of licence issues to deal with still...
69
Other software / Re: Arguments about the credits
« on August 16th, 2013, 04:47 AM »
Quote
I think that we should list the developers who were in developer positions during the release cycle and then list all other, former developers and other code contributors as "contributors"... because while they did contribute, and should be recognized for it, they are no longer active developers on the project. (and this can include github contributors or we can separate them as they are
I sort of agree with that and I sort of don't. It is a much better representation of what happened, yes. On the other hand, there is an argument (though not a very good one) that it could downplay the relevance of contributions (e.g. original contributions vs minor changes)... but as I said it's a poor argument.

Siloing the team is a problem and has been a problem for some years. It was a problem back when I was on the team, that people have their place and their title dictates their role. This hasn't exactly changed.

Breaking down the siloing in the credits would encourage cross-specialism participation.

I'd be quite happy with the proposal as given.
70
Other software / Arguments about the credits
« on August 16th, 2013, 03:07 AM »
This is petty but I'm frustrated, having just been part of an argument about the SMF credits.

They're already messed up and in 2.1 they're actually likely to get worse. Right now, for example, the plan is to have the current team up first, followed by everyone else as 'Friends', followed by Github contributors and stuff like that.

Now, I think it's nice they're actually getting Github contributors. I also understand there are a number of people who don't want even the Github contributors credited. There's nothing better than that for 'we'll take your commits but fuck you for wanting some credit to them'.

But the bit that's getting me frustrated is the absolute inability of some people to understand why lumping all the Friends together is actually fucked up.

Let me put this straight, and I'll try to use small words so everyone understands me.

1. SMF is a software project. Without the developers developing it, there would be no SMF.
2. If there is no SMF, there is no need for support, customizers, translators etc.
3. The only conclusion I can then draw from this is that developers are actually necessary to the project in a way that other roles aren't.
4. Support, Customizers, Translators are all important. But they, by necessity, must come second to developers because without developers, there's nothing to support, nothing to customize, nothing to translate.

Assuming we agree on the above:
a) Developers' contributions do not stop being important just because they left the team. There are still bits of the original SMF 1.0 (and, while we're at it, elements from YaBB) still in 2.0 and even in 2.1.
b) The current developers, as fine a people as they are, did not write 95% of SMF's code, because of the above.
c) Why, then, are the current developers considered as rock stars compared to the 'Friends' who are no more important than anyone else despite the fact that some of the Friends actually wrote the damn software?

It seems very simple to me: anyone who actually contributed code to SMF, i.e. those who MADE SMF need a higher billing than the people who support it etc.

In case anyone thinks this is about my getting my name higher up... no. I never made the dev team for various reasons. My code contributions are small enough that I don't personally consider them important enough to be considered a developer. I have no qualms with, then, remaining in the Friends list, provided that the people who actually made SMF get a slightly higher billing - after all, they're the ones who made it, and if SMF hadn't been made, I wouldn't have had anything to contribute.

And yet this mindset is still rife in SMF, that developers are not any more important than anyone else. Yes, that's right... in a project based around a piece of software, the people who make the software are not particularly important.

Imagine if that applied to other industries. Imagine if we told book authors, that suddenly they have to credit the publisher as being as important in the book's making as themselves. Now, books have the author in big letters on the front, and the publisher's logo on there too but when was the last time you saw the publisher receiving equal prominence to the author? What about the typesetters? The proof readers? The author's best friend who proof-read an early script? The author's partner who gave them moral support? By SMF's definition, we should be giving all these people equal credit to the author, regardless of anything else.

Apparently I appear to be in the minority of people who understand this. It's sad really, especially in light of other recent events where for one brief shining moment I was considering helping with SMF core development.
71
Other software / Re: SM.org compromised
« on August 15th, 2013, 03:58 AM »
Using a password manager is only as secure as the password manager itself is. Having a single point of failure is not entirely smart.

However what I'd generally suggest is having the general sites being managed through such a system and then keeping only the really important ones managed in your head (e.g. banking)
72
Off-topic / Re: Doctor Who
« on August 13th, 2013, 11:17 PM »
Not exactly an Easter Egg... that's Earl's Court. When the DW Experience was at Olympia (which is next to Earl's Court), they had that there for promotional purposes. As for the business listing, I'm not sure that's an easter egg either but actually set up intentionally. Could be wrong though ;)
73
Off-topic / Re: Dial Up BBS
« on August 9th, 2013, 07:11 PM »
I once had a set of OS/2 Warp 3 floppies... yeah, those were the days.
74
Features / Improving search
« on August 9th, 2013, 07:40 AM »
So I've been thinking about searching and the way searching works and I've concluded a number of things.

1. I want Sphinx and ElasticSearch in the core
Both Sphinx and ElasticSearch are pretty mature. Both have live update features now, so there's no reason we can't support them both with a sort of push mechanism (rather than Sphinx's pull mentality, like the old API was geared for)... the API needs rewriting to support either anyway and I might as well do it all together.

2. I want to natively support other types of data than posts.
The current setup doesn't support anything other than posts and I want to natively offer support for other stuff - calendar, helpdesk etc. The backend can support these extra things with some work, and pushing these also allows nice support in both ES and Sphinx.

3. It adds some nice feature parity with other systems without adding a ton of headaches for support.
XenForo offers ES with a $60 plugin, though I'm not entirely sure why. IPB has Sphinx in the core. Neither appears to have a huge support overhead because of them. And for the most part once they're done, they're done from our point of view.

4. The most controversial aspect of this is what I want to propose last: ditching unindexed searching.
Right now, the default searching method in Wedge is as it is in SMF: no index. It's slow, and doesn't scale beyond a few tens of thousands at peak. In fact, where we are right now on wedge.org is probably about the limit of what we can do with an unindexed DB before performance starts to go nuts. (40k is really the upper limit)

Now, partly this is because we've never configured it to be anything else, and most people just wouldn't know to do so because they wouldn't know any better. Now that's fine, because we know that people don't generally touch the settings unless they're directed - but using the search index would deliver better search performance from about 1k posts and up (and largely a push in performance terms for where things are right now for fresh installs)

I see no reason why 'no index' ever needs to be a valid search type. I'd suggest dropping that entirely and using the 'no index' option to mean 'no searching'. And then leaving the other index types to be actual index types, which would simplify the search code as well (and properly allow for it all to be segregated back to the APIs, some of which has already occurred but plenty more still to do)

This would leave us with three working search types (standard - formally known as custom, ES, Sphinx), of which 'custom' would be set as default on installation and would be populating posts as they are created (rather than having to deal with a huge index creation at once)

ES and Sphinx are both VPS level options, but there's no reason we can't have people pushing content to these indexes while using the custom index - plus of course there are always options for rebuilding indexes.


Does any of this make sense? Any questions?
75
Features / Re: New revs
« on August 8th, 2013, 11:59 PM »
2 modified, 2KB

Revision: 2209
Author: arantor
Date: 08 August 2013 22:58:55
Message:
! Merge in some fixes from SMF 2.0.5 patch (other issues already fixed, or require larger changes than this one commit):
 ! (XSS) $_REQUEST['sa'] could be used unsanitised. Clean up if not valid, and remove some other code we don't need any more. (PersonalMessage.php)
 ! (XSS) Email addresses were not validated when accepted for newsletters. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/PersonalMessage.php