Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
5866
Features / Re: New revs - Public comments
« on October 16th, 2011, 12:59 PM »
I did see that, wasn't sure of the background in respect to fixing it or not, so I left it as is. As for the openid_uri column, I just forgot that.

Didn't touch detailed_version because it's quite a bit out of date and I figured we'd fix it closer to release.
5867
Features / Re: New revs
« on October 16th, 2011, 03:21 AM »
(removed 2, modified 42, 37KB)

Revision: 1113
Author: arantor
Date: 02:20:45, 16 October 2011
Message:
! Probably the most scary commit for me personally since working on Wedge: removing OpenID and all its tendrils into the system, because it's integrated into the login, registration, reminder etc. systems. I don't think I've broken anything, I've gone through and tested logging in and out, registration, reminders and changing password in profile and everything seems to be working as expected, even with throwing invalid passwords as it. It's being removed because it should really be a plugin but I'm not really planning on building a plugin out of this code, because it's OpenID 1.1 not 2.0, and honestly, there are number of implementation details that don't sit right anyway. (index.php, install.*, SSI.php, Class-UnitTest.php; Sources: Class-DBPackages, Load, Login2, Logout, ManageRegistration, Profile-Modify, Profile, QueryString, Register, Reminder, ScheduledTasks, Security, Subs-Login, Subs-Members, Subs-OpenID (removed); Templates: index, Login, Profile, Register, Wireless; CSS: index.guest, index.rtl, Wuthering/index.rtl; Languages: EmailTemplates, Errors, Help, index, Login, Profile, Who; also removed openid.gif)

! Random bug when changing the password in profile, if it had too few characters, the un-sprintf'd string was used. (Subs-Members.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Deleted : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reminder.template.php
Modified : /trunk/Themes/default/Wireless.template.php
Deleted : /trunk/Themes/default/images/openid.gif
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/Themes/default/skins/Wuthering/index.rtl.css
Modified : /trunk/Themes/default/skins/index.guest.css
Modified : /trunk/Themes/default/skins/index.rtl.css
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest.php
5868
Features / Re: Bot logging
« on October 16th, 2011, 01:29 AM »
Quote
But personally, I would certainly enable such an option. As long as one is aware that less hits doesn't translate to less visitors...
And by the same token, more hits doesn't mean more visitors either.
Quote
IIRC, when I used to use GA on noisen.com, my stats over there were MUCH lower, something like 5 times less than SMF's own account.
Yup, that's about right.
Quote
Separating spider hits from the rest would be suitable as long as we have an option to disable spider stat logging. But I wouldn't feel comfortable implementing that myself...
Wouldn't we put it into the spider options?
5869
Features / Re: These two bytes may not matter to you...
« on October 16th, 2011, 01:28 AM »
Can we rely or otherwise ensure that the file headers are sent correctly? If we can rely on the header being correct (like we set it ourselves, for example) then we can strip it from the file, at least in theory.
5870
Features / Re: Bot logging
« on October 16th, 2011, 12:45 AM »
It's not all right, however it has several interesting side effects.

Firstly, it would decrease queries on the server quite a margin (and queries that have complications, at that).

Secondly, for those folks who use Google Analytics, it would bring the number of hits reported much closer between SMF and GA, because spider hits aren't counted with GA.

What you could do is to record spider hits separately to visitor hits. You wouldn't get the saving of the first one, and the accuracy of the second would be preserved - and you'd be able to neutralise the effects of SMF users thinking they'd lost hits.
5871
Features / Re: New revs - Public comments
« on October 15th, 2011, 05:47 PM »
Yeah, that's a slightly odd thing to have done but it seemed the most logical way of proceeding to cope with storing IP addresses per post.
5872
Features / Re: New revs - Public comments
« on October 15th, 2011, 12:49 PM »
No it doesn't.

For places like that where there are likely a lot of duplicates, they were turned into pointers to the log_ips table. Even if we end up making it a 64 bit value (for 2^64 *unique addresses per site*) that's still a quarter of the space used.
5873
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 15th, 2011, 12:09 AM »
True enough. Still, hindsight tells me it's not necessarily the best route - give SD a try and see how you feel about it then.
5874
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 11:53 PM »
Well, my reticence on the matter is primarily because while it's practical, I find it aesthetically cluttering, because you go from this minimalist editor box that is just a box with a few buttons underneath, to this hulk of stuff - essentially the core post form has been squished to fit inside the main thread view. It ain't pretty.

Try it yourself in SimpleDesk, even here. Find a ticket, scroll down to the reply area, then hit Go Advanced.
5875
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 11:37 PM »
Quote from Nao on October 14th, 2011, 10:20 PM
We could have the options in qr. And have the post page used as topic starter or non-JavaScript fallback (eg open link in new tab).

Dunno.
Been there, done that. It makes life interesting. We did a lot of that in SimpleDesk, even down to putting attachments into the quick reply. I'm not entirely sure I'd want to do that again though.
5876
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 09:42 PM »
The single post page has all the options - attachments, the sticky/lock/notify me/send announcement - while QR doesn't.

You need single post to create a thread in the first place...


@TE That's kind of what I thought ;)
5877
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 08:41 PM »
Yup, the whole implementation is a shade sub-par. I'm tempted to just ditch it and rewrite it later if anyone wants it.

As far as the hooks go, I'd rather have separate post and QR hooks, with a hook actually in the QR block for extension (as opposed to adding a new block after)

I don't know how the code will cope if you create multiple editor components that all have the same form name and are implicitly inside another form (the quick moderation one)...
5878
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 07:37 PM »
Making the post form hook able will be awesome though, it allows me to write a great many neat plugins. It's just a big job I didn't want to tackle just yet, and I probably should do some of the plugin server stuff first (feedback wanted in the appropriate thread)
5879
Features / Re: Birthday, calendar, plugin, core [VOTE NOW!]
« on October 14th, 2011, 06:05 PM »
In other news, I'm really not looking forward to splitting the calendar up. Not only will that require splitting the insane post template up, it'll require rewriting a decent amount of post handling to support hooking... >_<

I'm almost tempted to go write a small mod - say, an arcade mod - before doing that :o
5880
Off-topic / Re: Oh Well Why Not
« on October 14th, 2011, 03:47 PM »
Quote from DirtRider on October 14th, 2011, 03:45 PM
I have been to the live show 3 times and each time I enjoy it just as much
It's still awesome. I have to say, though, the first time I went, I happened to bump into Richard O'Brien in the bar before the show started, and naturally bought him a drink. :)