This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
5491
Off-topic / Re: 11/11/11
« on November 11th, 2011, 02:20 AM »
No... it's the tick of the 11th full hour after the stroke of midnight, which would make it 11am.
It's principally the same argument as the whole 'there is no year 0' argument - except in reverse.
It's principally the same argument as the whole 'there is no year 0' argument - except in reverse.
5492
Off-topic / Re: 11/11/11
« on November 11th, 2011, 02:07 AM »
Hrm. I think it is largely a cultural thing, and because of the date it has more significance if it is the shortened form.
The Royal British Legion have really pushed out all the stops this year for advertising, because this year they're pushing for the 11th Hour of the 11th Day of the 11th Month of the 11th Year. 11-11-11-11, as it were.
The Royal British Legion have really pushed out all the stops this year for advertising, because this year they're pushing for the 11th Hour of the 11th Day of the 11th Month of the 11th Year. 11-11-11-11, as it were.
5493
The Pub / Re: Logo Madness
« on November 11th, 2011, 02:06 AM »Oh well, TB2 is 'easy listening' in comparison. But one thing that's worth listening to is TB2003, where Oldfield re-recorded the album with John Cleese as the instrument announcer. Works really well. But I'm a sucker for part 2 (side B) of TB1. I think it's more interesting, albeit less 'progressive'.
They shot all 3 movies before they released the first one... So HP1 wasn't first
Of recent memory, I loved Jane Austen's 'Persuasion', the 2007 version. Probably mentioned it around here...
Could you take a look at the black logo and try to color it the way you want...? Shouldn't be too hard...?
I'm still not convinced that the other attempt was any good. Too bright. Below is another attempt with darker colors and yet another font (the font was just for the fun of it.)
Heck, haven't been to the doctor in 10 years, even though my health is at a low and has been for some time...
But that says to me you need to take a break.
Really?
Heck, I'd rather work on SVG by hand or use PHP ahead of that...
5494
Features / Re: New revs
« on November 11th, 2011, 02:02 AM »
(2KB, 2 modified)
Revision: 1155
Author: arantor
Date: 01:01:49, 11 November 2011
Message:
! More language strings to be removed from the calendar. I don't think they're used anywhere else. (Errors language file)
----
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Revision: 1155
Author: arantor
Date: 01:01:49, 11 November 2011
Message:
! More language strings to be removed from the calendar. I don't think they're used anywhere else. (Errors language file)
----
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
5495
Off-topic / Re: 11/11/11
« on November 11th, 2011, 01:58 AM »
You're not telling me that the French *never* use the 2-digit shortened form... :ph34r:
5496
Features / Re: New revs
« on November 11th, 2011, 01:55 AM »
(38KB, modified 51, deleted 11)
Revision: 1154
Author: arantor
Date: 00:55:08, 11 November 2011
Message:
- Removed the calendar. (Many files, more than I really want to list, everything in this commit is related; every place that has hooks added should also have calendar code removed in its stead.)
+ New hooks (ManagePlugins.php, Security.php, RepairBoards.php, Settings.template.php, Subs-Boards.php, SplitTopics.php, Post.php)
@ Not every trace of the calendar is gone. Notably, the 'which day to start the calendar' is still in the profile area, because there's no sane way to hook it at this time (because the profile options needs an overhaul), there's a couple of strings with calendar_ prefixes that are used elsewhere to the calendar, there's one place in the quick moderation that needs a hook attached, and lastly the menu icon is still part of the icons sprite. That needs to be split off and made accessible to the menu loader. But pretty much everything is. Everything seems to work with the calendar removed, and it's unknown whether the calendar as a plugin works, but we'll see when we get there...
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Deleted : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Deleted : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Deleted : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Deleted : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Deleted : /trunk/Themes/default/images/admin/calendar.gif
Deleted : /trunk/Themes/default/images/admin/calendar.png
Deleted : /trunk/Themes/default/images/admin/calendar_off.png
Deleted : /trunk/Themes/default/images/admin/calendar_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.english.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/xml/detailed-version.php
Revision: 1154
Author: arantor
Date: 00:55:08, 11 November 2011
Message:
- Removed the calendar. (Many files, more than I really want to list, everything in this commit is related; every place that has hooks added should also have calendar code removed in its stead.)
+ New hooks (ManagePlugins.php, Security.php, RepairBoards.php, Settings.template.php, Subs-Boards.php, SplitTopics.php, Post.php)
@ Not every trace of the calendar is gone. Notably, the 'which day to start the calendar' is still in the profile area, because there's no sane way to hook it at this time (because the profile options needs an overhaul), there's a couple of strings with calendar_ prefixes that are used elsewhere to the calendar, there's one place in the quick moderation that needs a hook attached, and lastly the menu icon is still part of the icons sprite. That needs to be split off and made accessible to the menu loader. But pretty much everything is. Everything seems to work with the calendar removed, and it's unknown whether the calendar as a plugin works, but we'll see when we get there...
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Boards.php
Deleted : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Deleted : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Cache.php
Deleted : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Deleted : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Settings.template.php
Deleted : /trunk/Themes/default/images/admin/calendar.gif
Deleted : /trunk/Themes/default/images/admin/calendar.png
Deleted : /trunk/Themes/default/images/admin/calendar_off.png
Deleted : /trunk/Themes/default/images/admin/calendar_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.english.php
Deleted : /trunk/Themes/default/languages/ManageCalendar.french.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.english.php
Modified : /trunk/Themes/default/languages/ManageMaintenance.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/ssi_examples.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/xml/detailed-version.php
5497
Off-topic / Re: 11/11/11
« on November 11th, 2011, 12:56 AM »
Not yet it isn't... your clock is fast.
5498
Development blog / Re: Ticking away the moments that make up a dull day
« on November 11th, 2011, 12:51 AM »
OK, so here I am an hour later, still hacking away at this. I've been on this most of today trying to unwrap it from the core... it's insane how much effort went into integrating it when you really get up close and personal with it.
I'm not regretting it, only frustrated with it. I'm just working on the post form and discovering more and more things I never realised about its complexity beforehand, and more things that will have to be amended and made available to hooks. This sort of thing is scary-deceptive, and for anyone who follows in these footsteps, you have my blessing and my deepest sympathies.
OK, now I discover that this is ridiculous.
If you post an event with a topic, but there's something wrong with the calendar post part, the topic will *still be inserted* anyway. It doesn't reflow back to the posting page for you to fix it! (And, you can't fix and resubmit because there's a submit-once check that isn't always cleared either. Yay.)
I'm not regretting it, only frustrated with it. I'm just working on the post form and discovering more and more things I never realised about its complexity beforehand, and more things that will have to be amended and made available to hooks. This sort of thing is scary-deceptive, and for anyone who follows in these footsteps, you have my blessing and my deepest sympathies.
Posted: November 11th, 2011, 12:24 AM
OK, now I discover that this is ridiculous.
If you post an event with a topic, but there's something wrong with the calendar post part, the topic will *still be inserted* anyway. It doesn't reflow back to the posting page for you to fix it! (And, you can't fix and resubmit because there's a submit-once check that isn't always cleared either. Yay.)
5499
Development blog / Re: Ticking away the moments that make up a dull day
« on November 10th, 2011, 11:14 PM »
I already pretty much said that I was going to implement recurring events anyway, in the calendar plugin, but I'm seeing a more compelling reason to do so: to improve holidays support.
Right now it's implemented as a fun happy list inserted into a table, but really, that's not the way to do it, I feel. It sort of is a recurring event of sorts (at least, the exactly-annual ones are) but there's no reason why things can't be implemented a bit more nicely.
Or at least, some way of making it more sane to add/remove chunks of them. Perhaps give the mod many many dates and have it just only show the ones the admin is interested in. I can think of several ways that can be done performantly, too.
Right now it's implemented as a fun happy list inserted into a table, but really, that's not the way to do it, I feel. It sort of is a recurring event of sorts (at least, the exactly-annual ones are) but there's no reason why things can't be implemented a bit more nicely.
Posted: November 10th, 2011, 11:08 PM
Or at least, some way of making it more sane to add/remove chunks of them. Perhaps give the mod many many dates and have it just only show the ones the admin is interested in. I can think of several ways that can be done performantly, too.
5500
Development blog / Re: Ticking away the moments that make up a dull day
« on November 10th, 2011, 07:56 PM »
It will, once I finish ripping it out of the core.
5501
Development blog / Re: Ticking away the moments that make up a dull day
« on November 10th, 2011, 06:10 PM »
Also, the more I look at it, the more I realise the calendar has had little love in its life. The help text for 'cal_enabled' is a single item that lists everything on the page, is also a bit out of date :(
5502
Other software / Re: Once upon a time...
« on November 10th, 2011, 05:16 PM »How could I missed this post?Quote from tfs on October 31st, 2011, 06:13 PM It's been remade. Now with four ports.Quote from ~DS~ on October 31st, 2011, 06:10 PM But the Tardis had been destroyed...
SOLD!!
5503
Other software / Re: Once upon a time...
« on November 10th, 2011, 04:31 PM »
An interesting answer, yes. I'd forgotten about $user_profile, since you were talking about $user_info, I figured it was letting the user update their own settings rather than someone else's. (Though, intriguingly, virtually everything else stays the same; $user_profile just holds the same details for every user, $user_info holds a bunch of stuff for the current user, but all arguments about whether you reuse the information on the page hold true either way.)
On the whole, it's a pretty good answer from AngelinaBelle, there, the only thing that would have made it perfect is understanding what the cache level parameter is doing. Specifically, that ties into the cache level settings in the cache subsystem.
Level 0 is off, level 1 is the basic level of caching, and occurs on files if necessary or if a proper cache backend (XCache, APC, memcached) is specified. Level 2 and above physically require a proper cache backend, and don't really apply to file caching, and unless you have a really good reason you won't be using level 2+ anyway because you likely end up with more stale data than you really want, meaning that loadMemberData doesn't really ever fetch from cache for most users.
On the whole, it's a pretty good answer from AngelinaBelle, there, the only thing that would have made it perfect is understanding what the cache level parameter is doing. Specifically, that ties into the cache level settings in the cache subsystem.
Level 0 is off, level 1 is the basic level of caching, and occurs on files if necessary or if a proper cache backend (XCache, APC, memcached) is specified. Level 2 and above physically require a proper cache backend, and don't really apply to file caching, and unless you have a really good reason you won't be using level 2+ anyway because you likely end up with more stale data than you really want, meaning that loadMemberData doesn't really ever fetch from cache for most users.
5504
Development blog / Re: Ticking away the moments that make up a dull day
« on November 10th, 2011, 03:50 PM »
Scary is not the word I would use for it. The word I *would* use is not for polite company, as it contains f***.
It doesn't help that I don't really know the calendar, this is the first time I've ever really looked at it but I'm amazed at how many tendrils it has everywhere, especially since anything that so much as breathes on topics pushes the calendar items to get uncached.
Also, it's prompted me to do something else: fix cache_quick_get.
It's one of those things that I always meant to do, because it still does a require with $sourcedir, rather than use loadSource but I never got round to actually making it use loadSource. Well, now I have to fix it, otherwise the calendar is going to break.
(Same deal as elsewhere, if $file is a string, loadSource() it, if it's an array, it's a plugin id + filename to load through loadPluginSource)
It doesn't help that I don't really know the calendar, this is the first time I've ever really looked at it but I'm amazed at how many tendrils it has everywhere, especially since anything that so much as breathes on topics pushes the calendar items to get uncached.
Posted: November 10th, 2011, 03:45 PM
Also, it's prompted me to do something else: fix cache_quick_get.
It's one of those things that I always meant to do, because it still does a require with $sourcedir, rather than use loadSource but I never got round to actually making it use loadSource. Well, now I have to fix it, otherwise the calendar is going to break.
(Same deal as elsewhere, if $file is a string, loadSource() it, if it's an array, it's a plugin id + filename to load through loadPluginSource)
5505
Development blog / Ticking away the moments that make up a dull day
« on November 10th, 2011, 03:32 PM »
OK, so what's been happening in the last month? It's been... pretty busy, actually. 71 commits since the last blog post, including:
* OpenID got removed
* some purging of $scripturl from the system in favour of a cleaner method of handling it
* links to profiles now get coloured by membergroup colour through the code (if the current user is not able to visit other profiles, the link is removed, saving bandwidth and preventing search engines from repeatedly trying links that won't go anywhere)
* improved replacement of fetch_web_data, that allows for using cURL on hosts that support it (which is cleaner), and for images on remote servers, attempt to only get as little information as possible for the image rather than the entire image itself, which is great for massive photos, for example
* quite a few new hooks
* Noisen-like thoughts system added
Not to mention various clean-up and overhauling of structures internally.
Today, though, I'm going to talk a little about what I've been working on... the calendar.
If you were to go back through the threads, you'd probably find the earliest discussions on it a year ago trying to find reasons to keep it or lose it, arguing both in favour of keeping it core and turning it into a plugin. At the time the conclusion was that we could keep it and see if we could find reasons to make it worth keeping.
But interestingly, a year later, I'm still having trouble finding reasons to keep it core, when I can make it a plugin and give it better treatment that way.
So, that's what I'm doing, and I'm actually more surprised than I thought I'd be when I realised how intertwined the calendar really was in SMF's core (and, thus by extension, Wedge's core)
If you're curious, just do a search for 'calendar' on the SMF 2.0 codebase, even before you get into all the places where it's just a cal_ prefix, it's hundreds. Far more than I certainly expected, but it's interesting to note that it's prompting new hooks and new ways to extend things that I'd never have thought of.
For example, SimpleDesk came with its own maintenance/find-repair routines. Had I been thinking about it, I'd probably have integrated that into the general find/repair routines, if there were a convenient way of doing so. Which there wasn't, but now there is, so that's good.
It does also suggest one thought to me; the SMF team have long since indicated that it is a desire of theirs to do much the same thing. The one lesson I would take from this, and it is quite important to understand this, is that doing it in the SMF methodology of file edits... this would be beyond a nightmare.
I haven't even gotten to the display or posting pages yet and I've still modified:
* index.php (to remove the calendar action)
* Admin.php (for the admin menu)
* Class-DBPackages.php (to remove the calendar tables from the list of reserved tables)
* ManageMaintenance.php (to remove the calendar tables from the list of tables considered by the old converter[1])
* MoveTopic.php (to remove functions that update calendar entries when moving topics plus adding a hook for the same)
* RemoveTopic.php (to remove the code called when deleting a topic, so that the calendar is updated at the same time)
* RepairBoards.php (to remove the code from find/repair for the calendar, and adding a hook for the same)
* Subs-Boards.php (to remove the code deleting calendar items when deleting a board, and adding a hook for the same)
* Who.php (to remove the entry regarding permission to view the calendar)
* various language files, notably Admin, Help, ManageMaintenance, Who
Naturally all the removed code is converted to hooked functions, and Calendar.php, Calendar.template.php, ManageCalendar.php, ManageCalendar.template.php and Subs-Calendar.php aren't in the trunk any more
That's also not all of it, either, there's plenty more. I still have 323 mentions of 'calendar' to clean up in the source, and some of those - just for fun - are calendar_month and calendar_day language strings that aren't calendar uses (paid subs, if you're wondering)
But that should indicate how big and complicated the calendar was, and if it's just converted to a mod, it's going to be pretty vile to maintain because of all the edits it necessarily has to make to make everything else work. Doing it without a proper plugin setup is just madness if support is to be a realistic goal, IMO.
I'm actively adding support for things as I go to make it possible to make the conversion, and I hope that if the SMF team are seriously considering it, that they either read this and do something about it, or more likely that they come up with their own game plan as to making extensions fundamentally cleaner to write, because allowing it to go on to be a classic mod is simply a very bad idea.
* OpenID got removed
* some purging of $scripturl from the system in favour of a cleaner method of handling it
* links to profiles now get coloured by membergroup colour through the code (if the current user is not able to visit other profiles, the link is removed, saving bandwidth and preventing search engines from repeatedly trying links that won't go anywhere)
* improved replacement of fetch_web_data, that allows for using cURL on hosts that support it (which is cleaner), and for images on remote servers, attempt to only get as little information as possible for the image rather than the entire image itself, which is great for massive photos, for example
* quite a few new hooks
* Noisen-like thoughts system added
Not to mention various clean-up and overhauling of structures internally.
Today, though, I'm going to talk a little about what I've been working on... the calendar.
If you were to go back through the threads, you'd probably find the earliest discussions on it a year ago trying to find reasons to keep it or lose it, arguing both in favour of keeping it core and turning it into a plugin. At the time the conclusion was that we could keep it and see if we could find reasons to make it worth keeping.
But interestingly, a year later, I'm still having trouble finding reasons to keep it core, when I can make it a plugin and give it better treatment that way.
So, that's what I'm doing, and I'm actually more surprised than I thought I'd be when I realised how intertwined the calendar really was in SMF's core (and, thus by extension, Wedge's core)
If you're curious, just do a search for 'calendar' on the SMF 2.0 codebase, even before you get into all the places where it's just a cal_ prefix, it's hundreds. Far more than I certainly expected, but it's interesting to note that it's prompting new hooks and new ways to extend things that I'd never have thought of.
For example, SimpleDesk came with its own maintenance/find-repair routines. Had I been thinking about it, I'd probably have integrated that into the general find/repair routines, if there were a convenient way of doing so. Which there wasn't, but now there is, so that's good.
It does also suggest one thought to me; the SMF team have long since indicated that it is a desire of theirs to do much the same thing. The one lesson I would take from this, and it is quite important to understand this, is that doing it in the SMF methodology of file edits... this would be beyond a nightmare.
I haven't even gotten to the display or posting pages yet and I've still modified:
* index.php (to remove the calendar action)
* Admin.php (for the admin menu)
* Class-DBPackages.php (to remove the calendar tables from the list of reserved tables)
* ManageMaintenance.php (to remove the calendar tables from the list of tables considered by the old converter[1])
* MoveTopic.php (to remove functions that update calendar entries when moving topics plus adding a hook for the same)
* RemoveTopic.php (to remove the code called when deleting a topic, so that the calendar is updated at the same time)
* RepairBoards.php (to remove the code from find/repair for the calendar, and adding a hook for the same)
* Subs-Boards.php (to remove the code deleting calendar items when deleting a board, and adding a hook for the same)
* Who.php (to remove the entry regarding permission to view the calendar)
* various language files, notably Admin, Help, ManageMaintenance, Who
Naturally all the removed code is converted to hooked functions, and Calendar.php, Calendar.template.php, ManageCalendar.php, ManageCalendar.template.php and Subs-Calendar.php aren't in the trunk any more
That's also not all of it, either, there's plenty more. I still have 323 mentions of 'calendar' to clean up in the source, and some of those - just for fun - are calendar_month and calendar_day language strings that aren't calendar uses (paid subs, if you're wondering)
But that should indicate how big and complicated the calendar was, and if it's just converted to a mod, it's going to be pretty vile to maintain because of all the edits it necessarily has to make to make everything else work. Doing it without a proper plugin setup is just madness if support is to be a realistic goal, IMO.
I'm actively adding support for things as I go to make it possible to make the conversion, and I hope that if the SMF team are seriously considering it, that they either read this and do something about it, or more likely that they come up with their own game plan as to making extensions fundamentally cleaner to write, because allowing it to go on to be a classic mod is simply a very bad idea.
| 1. | That whole function is probably obsolete now, though. |