Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
5071
Features / Re: New revs - Public comments
« on January 15th, 2012, 02:39 AM »
That's the point, it tells me nothing.

All of the $_SERVER['HTTP_*'] items are directly injected into $_SERVER from the request headers. That means either something is *removing it* from $_SERVER when it shouldn't be, or it's not being passed down through the chain between browser and PHP (i.e. either the browser isn't sending it, or it's not being passed onwards properly between Apache and PHP)

The chain is broken. I can't diagnose the end of the chain without seeing more of it...
5072
Features / Re: Selectbox
« on January 14th, 2012, 11:54 PM »
Hmm, I remember the one time I had to fight with magic button replacements, it was ugly. In short, I needed something that would be the size I set in CSS, with the text auto-centered vertically.

Initially a regular input was fine but then I wanted to include a GIF in it and the GIF was supposed to follow the text, meaning it wasn't as if the CSS could be used to do it (seeing how the button was like 150x100 with one or two words in the middle), and I ended up using a div to fake it and got very very frustrated with IE7 and 8 misbehaving the way they inevitably do with it >_<

I don't know what's for the best here, sorry.
5073
Features / Re: New revs - Public comments
« on January 14th, 2012, 11:51 PM »
Quote from Lurker on January 14th, 2012, 04:36 PM
What page(s) is that being requested on?
I don't care so much *why* it's used. I want to know where you're calling where it isn't being logged.
5074
Features / Re: New revs - Public comments
« on January 14th, 2012, 04:36 PM »
Quote
$_SERVER['HTTP_HOST'] isn't even set at all...
What page(s) is that being requested on?

The only time that it shouldn't be being set is if the user is using HTTP/1.0 not 1.1 and you're using very specific configuration in the webserver itself so that you're using virtual management through IP address, not name based (and/or only have one site on the server so it doesn't matter what you do, you end up on the site anyway)
5075
I'm using DynDNS but only because before that I was using EveryDNS and DynDNS bought them out.
5076
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 04:01 PM »
Quote
Pete. Why would a hook be able to test for dupes more than a handler relying on a hook?
Because right now the hook itself exposes the entire credits list. It would be trivial for any hooked function to see what else is there.

But if there's a secondary handler, by definition the handler's the one handling the credits - so what the hook sees/gets/returns is only its own. So the handler would have to do the work of figuring out duplicates. (That is, assuming the handler is being set up to prevent abuse. If not, the handler becomes unnecessary because the entire variable just gets passed directly to the hook in the first place)
Quote
Remember that Smf's credit page is well hidden, hence why no one uses it...
Not only that, but it's actually impossible to cleanly add to the list and be reliable. There is no hook in SMF to attach to, so short of some other hack introducing a layer in Who.php, that manipulates $context['copyrights'] as an _above template so that it's applied before the main layer is called, you're reliant on standard editing.

The problem with standard editing is that it's fragile, because the entirety of its code is thus:
Code: [Select]
$context['copyrights'] = array(
'smf' => sprintf($forum_copyright, $forum_version),

/* Modification Authors:  You may add a copyright statement to this array for your mods.
Copyright statements should be in the form of a value only without a array key.  I.E.:
'Some Mod by Thantos &copy; 2010',
$txt['some_mod_copyright'],
*/
'mods' => array(
),
);

if (!$in_admin)
{
loadTemplate('Who');
$context['sub_template'] = 'credits';
$context['robot_no_index'] = true;
$context['page_title'] = $txt['credits'];
}

That's the end of the SMF credits function after that. So the only thing you can do is rely on not hitting something else that another mod has - because if you do, while it's possible that it'll still work, it's more likely that one, or other, or both of the mods will cease to be uninstallable thereafter.

Without actually having a hook for credits, the page becomes next to useless to have.

Oh, and note the fact that it's not indexed by search engines. I'm undecided whether that should change in Wedge - but there is good reason not to.
5077
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 03:49 PM »
Of the default 2.0 credits, the only things kept were the 2.0 dev people, those who had actually contributed to 2.0's dev in some material fashion.
Quote
Well that's the first time I've looked at / noticed the credits page! Will plugin writers be happy if their only mention is in an unused part of the site?
It's also linked to in the footer as stated, quite visibly under 'Website Credits'. At this point I don't really care if plugin writers will be happy or not.

Really, it comes down to this: if you want to list it on the official site, then that's the rule to play by. Don't like it? Run your own mod site, then you can distribute what you like.
Quote
How about plugins that create their own section e.g. a links directory - should they be allowed a copyright at the bottom of their pages?
As long as it's not in the master footer on every page, I don't really have a problem with this, though I'd still discourage it.
Quote
Assuming Wedge will have 'themes' will their creators be able to add their copyright? Some writers are very adamant on this!
I'd say no more than one line of copyright.


You see, here's the line that's drawn: too many mods shove their copyrights in the footer on every page unnecessarily. If it modifies that page actively (i.e. more than just a new menu item) then I can see the rationale, but too many mods just shove it in regardless of how much code of that mod runs on that page. Never mind the fact that the footer isn't big enough to put much in the way of ads into anyway (and now file edits aren't possible in the core plugin manager, so you have even less opportunity to shove it in)

As far as I'm concerned, mod authors gave up the right to have their footer copyright when it started to be abused a couple of years back for SMF, when little mods that weren't used on every page got a footer copyright (and all the problems attached with it, like copyrights being left in when the mod is uninstalled, and/or install problems because of them), so because of everyone peeing in the pool, NO-ONE has the right to do so.
5078
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 02:18 PM »
Quote from Nao on January 13th, 2012, 02:14 PM
Seriously though, I think a good guideline would be to simply say, "one line of credits"... Because Plugin credits are using a single column in the otherwise 2-column layout in this page, there's plenty enough place. And I suppose having 2 lines would be okay if justified -- we just don't want every single plugin to have several lines of credits or whatever.
If it uses an image pack or something similar, then I can understand 2 lines or so, one for the mod, one for the image pack. (WedgeDesk currently does this to credit the Fugue icons, as it is supposed to do)
Quote
Maybe we could give a helper function to add credits, instead of just a hook... (It would internally use the hook, of course.)
And/or maybe we could show plugin credits inline, instead of as an unordered list. Bit messy, that could be...
I've thought about that, actually, because right now the credits are something of a wilderness; a plugin can theoretically override or remove other plugins' credits. On the flip side, moving it to a helper function that receives from hooks - but doesn't allow direct access to other credits runs the risk of creating duplicates if two mods use the same image set. (E.g. two mods use Fugue, you don't need two copies of the Fugue attribution)
Quote
Aeva Media and its stupid advertisement for Wedge! :eheh:
Actually AM has always been pretty good about its footer, only activating when - you know - it's actually used on the page. Not what I was thinking of, and more importantly who refitted all the mods they acquired with stupid footer links that never used to be there.
5079
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 02:05 PM »
Quote from Nao on January 13th, 2012, 01:59 PM
Well, over 12 bytes they'd be tempted to add [url=][/url] to their credit... :niark:
Unless they own a 1 letter domain name in a 2 letter TLD (i.e. something like t.co), 16 bytes doesn't help enough ;)
Quote
Sure.
Especially because you know who the worst offender for footer copyrights is.
5080
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 01:49 PM »
Aw, you're a bit mean, I was going to allow at least 16 bytes per plugin :P

I'm all for developers being credited for their work, I just don't want them to take the piss as they're currently doing for SMF.
5081
Features / Re: Post moderation
« on January 13th, 2012, 01:02 PM »
OK, so I thought about this a bit more today, going to look at implementing some of it hopefully today as well.

The bit I thought about was the criteria tag. It occurred to me that you might not just want to moderate posts but blacklist some types of content too depending on other criteria.

Specifically turning it into something like:
<criteria for="moderate"> - if the criteria are met, moderate the post/topic

<criteria for="prevent"> - if the criteria are met, prevent the post from being made entirely

<criteria for="lock"> - automatically lock the topic if certain criteria are applied (e.g. post contains ^/lock AND user has permission to lock topic)

Just a thought, anyways.
5082
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 12:40 PM »
Should we have any kind of rules about what can or can't be in the credits page? I'd prefer to leave it a bit more unmoderated if possible, but I think it may require rules at some point >_<
5083
Plugins / Re: Plugins NOT modifying core files
« on January 13th, 2012, 12:39 PM »
It needs to be implemented first before it can be reallowed ;)

It would certainly keep things cleaner though it would force us to make sure everything can be touched from hooks of some description.
5084
Plugins / Re: Plugin copyrights in the footer
« on January 13th, 2012, 11:17 AM »
There is a credits page in place, there even is in SMF 2.0 but no-one uses SMF's, probably because on a technical level it's broken for mod purposes...
5085
The Pub / Re: Logo Madness
« on January 13th, 2012, 10:24 AM »
Anyway, back on track.

Seems to me that the current logo is the one people are happiest with and it's the most reflective of everything to date...