Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
4996
Features / Re: Likes
« on February 8th, 2012, 11:35 PM »
Ah yes, though jumpTo also manually sets up certain pretty filters :/

But yes, I can certainly look at that code and come up with something.
4997
Plugins / Re: Plugin copyrights in the footer
« on February 8th, 2012, 11:26 PM »
There are things I'm clear on and things I'm not. Footer copyrights are something I don't want to see - period. No rule I've seen will allow for reputable authors to get credit when it's due and not allow miscreants to abuse it, so either every plugin can, or no plugin can (subject to where I have any say in the matter)

On the other hand, I'm also aware that miscreants can and will abuse whatever provisions they are given. I can imagine plugins that could remove everyone else's attribution (accidentally or otherwise), so the fewer places a mod author can screw it up, even accidentally, the better. I know full well that the base copyright can be derived from what's in the manifest, should they choose to use it, but that removes the *choice* of the author to have one or not have one.

You see, I want to give mod authors the tools to do it properly, but I can't trust them not to abuse it.
4998
Features / Re: Likes
« on February 8th, 2012, 11:23 PM »
Then it pretty much has to go through the entire output buffer replace then.

Just trying to think, would that happen before or after any wrapping in an XML container?
4999
Plugins / Re: Plugin copyrights in the footer
« on February 8th, 2012, 11:20 PM »
I don't think that's a huge problem, actually. Especially since the *required* elements wouldn't be enough on their own - you'd need a year as well, which would make it a conscious action rather than a thing that 'just happens'.

The one thing I should point out is that there is actually nothing preventing mods from doing footer copyrights on a technical basis; all the tools for doing it are in Wedge just as they are in SMF (and they're better in Wedge, incidentally), and still without so much as a file change. So my view on it is just about preventing it as part of how things go as standard, but if third party sites want to do it, best of luck to them.

I'd rather make it much easier for people to build a mod that appropriately credits them.
5000
Features / Re: Moving options out of Current Theme
« on February 8th, 2012, 11:15 PM »
Bumpity for justice.

* Show recent posts on board index: It's a plugin.

* "Show who is viewing": Features and Options (with the other who's online options)

* Enable collapsible additional post options: general, post settings or something...: Now in Post options.


Everything else is mostly as-is with the following changes:

* Show who edited a post
- Given how many people ask about this, I'm tempted to make it a bit more smart. Right now, I seem to recall it doesn't display the name if the person editing was the author of the post. Now, my thoughts are making it multi-option (and general, not per-theme):
  - Never show who modified a post
  - Always show who modified a post
  - Never show who modified a post if it was the author
Maybe there's more options in there too?

* Group key
Well, it's now displayed in two places, the sidebar and the front page (i.e. both places the info center is), but I'm thinking the sidebar version is badly formatted (and that won't change much), while the front page version... it probably should go into a plugin really. Either that or it needs to be strongly upgraded in core, and I don't feel a burning need to do that.
5001
Plugins / Re: Exposing bbcode to the plugin manager
« on February 8th, 2012, 08:29 PM »
That said, I don't *have* to gut the existing logic (around what gets set in $disabled), I can make it work by figuring it out from other stuff, I guess.
5002
Features / Re: Likes
« on February 8th, 2012, 07:15 PM »
That's the thing, the choice is either doing it manually or pushing a small one line string through the entire buffer...

Mind you, I suppose if it is a profile link it does have to do the PURLs replaces...
5003
Plugins / Re: Plugin copyrights in the footer
« on February 8th, 2012, 07:11 PM »
Not necessarily noticeably, especially with caching. I'm just thinking of making it easier for mod authors to toe the line, and really it's probably not that different, it's still a file that will normally be loaded and parsed.

On the other hand, what you might find on the flip side is people shoving in credits into existing files which might make parsing slower.

Hard to say really.
5004
Features / Re: New revs
« on February 8th, 2012, 06:09 PM »
(8 modified, 9KB)

Revision: 1300
Author: arantor
Date: 08 February 2012 17:08:47
Message:
! Move the 'enable collapsable post options' to post options, rather than in theme options. (install.sql, ManagePosts.php, Post.template.php, Settings.template.php, Admin and Themes language files)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/install.sql
5005
Features / Re: New revs
« on February 8th, 2012, 05:42 PM »
(3 modified, 11KB)

Revision: 1298
Author: arantor
Date: 08 February 2012 16:41:27
Message:
! The 'show how many people are viewing this...' option is no longer a theme option but now a general option (since it should logically apply consistently to all themes) (Display.php, ManageSettings.php, MessageIndex.php, Subs.php, Display.template.php, MessageIndex.template.php, Settings.template.php, ManageSettings and Themes language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php

(For those wondering, it's in Features and Options with the other 'who's online' type options.)
5006
Features / Re: New revs
« on February 8th, 2012, 04:27 PM »
(2 modified, 1KB)

Revision: 1297
Author: arantor
Date: 08 February 2012 15:26:54
Message:
! Fix for broken bbcode change in the installer. Remember: if you want a literal \ in the table, you have to escape it in SQL, heh. (install.sql)

! Minor thing that always annoyed me: it shouldn't be possible, even accidentally, to give guests permission to send announcements or edit site-wide news. (ManageNews.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/other/install.sql
5007
Plugins / Re: Exposing bbcode to the plugin manager
« on February 8th, 2012, 04:10 PM »
XenForo's facilities in this department are functional but confusing and not that wonderful to work with, IMO. Trying to write a bbcode that has any callback is a PITA of the first water.

I've been thinking about this, though, and the much rumoured bbcode editor and thinking that I might have to up-end how things are done, especially if a user ever wants to edit a bbcode that a plugin has issued (because right now, enabling/disabling a plugin causes it to be added/removed directly from the table)

So I've been thinking about having an 'active' parameter in the table, and querying against that, which would allow removal of the existing 'big list of bbcode' tickboxes and allow for per-code disabling (potentially) but it would also require non-trivial changes to the bbc parser, and I'm not sure I'm up to that right now.
5008
Plugins / Re: Plugin copyrights in the footer
« on February 8th, 2012, 04:07 PM »
Another thought occurred to me. The plugin spec already allows for an author to specify a site for themselves, and one for the plugin itself (separately, too) - there's no reason why we couldn't pick that up automatically for the enabled plugins.

What we'd have to do is add a copyright date facility into the plugin spec, and some way to indicate libraries/icons used by a plugin, and we could do it all that way - without needing to issue a hook. Something similar can be done for themes, if needed.

The upside is that it's less prone to abuse, and it's actually one hook we can dispense with at that point because if it's not required by anything after that, and it's less likely to be forgotten about by authors, IMO.
5009
Features / Re: Likes
« on February 8th, 2012, 03:51 PM »
Hmm, still can't think of a good way to actually perform the colour substitution.

I think the obsessrewrite stuff needs changing slightly to move the colour separation into its own function so it can be called independently of the full buffer rewrite.
5010
Features / Re: New revs
« on February 8th, 2012, 03:24 PM »
My first in a while. Life is a bitch like that.

(2 added, 3 removed, 15 modified, 30KB)

Revision: 1296
Author: arantor
Date: 08 February 2012 14:22:29
Message:

& Typo that really irritated me in the search engines page. (Search language file)

! Remove file edits from the master copy of the plugin info specification. It isn't implemented currently and isn't going to be in future, so no need to document its format. (plugin-info.rng)

! Attempt to issue headers that cut back on the crap that gets sent out every page. May or may not make a huge difference depending on configuration but it can't hurt to do so. (QueryString.php)

+ Debug output now includes peak memory usage. Not a major thing but can be useful. (Subs-Template.php, index language file)

! Housekeeping of core features images we don't use any more (feature_ml.png, feature_sp.png, feature_w.png)

! Another item kicked off of Core Features and into its own page: Search Engines (now relabeled Search Engine Tracking to better fit with what it does). This resulted in a bit of fixing around how the pages themselves worked, and to make sure that spider_mode was checked, rather than checking any of the other parameters (which previously, Core Features would have done for us). (Admin.php, Load.php, ManageSearchEngines.php, ManageSettings.php, Subs-MembersOnline.php, Who.php, search_engines_*.png, language files: Admin, ManageSettings)

----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/Who.php
Deleted : /trunk/Themes/default/images/admin/feature_ml.png
Deleted : /trunk/Themes/default/images/admin/feature_sp.png
Deleted : /trunk/Themes/default/images/admin/feature_w.png
Added : /trunk/Themes/default/images/admin/search_engines_off.png
Added : /trunk/Themes/default/images/admin/search_engines_on.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/plugin-info.rng