Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
4951
Features / Re: New revs
« on February 12th, 2012, 03:02 PM »
(1 file, 1KB)

Revision: 1324
Author: arantor
Date: 12 February 2012 13:58:04
Message:
! Made the quick moderation handler also use the improved boardsAllowedTo code. (QuickMod.php)
----
Modified : /trunk/Sources/QuickMod.php
4952
Features / Re: New revs
« on February 12th, 2012, 02:56 PM »
(13 modified, missed the size)

Revision: 1323
Author: arantor
Date: 12 February 2012 13:55:09
Message:
! Fixed undefined 'forum_index' on the forum front page. (Welcome.php)

! Tweaked default for quick reply for guests on the forum (install.sql)

! Removed the quick moderation option; it's now checkboxes all the way, baby! (MessageIndex.php, MessageIndex.template.php, Search2.php, Display.template.php, Profile.template.php, Recent.template.php, Search.template.php, Settings.template.php, Profile language file)

! Rewrote boardsAllowedTo to better support situations where you need to make multiple permissions calls in the same context (e.g. as in Search2 where you make 11 permissions calls in one go) (Search2.php, Security.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Welcome.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/other/install.sql
4953
The Pub / Re: Quick moderation
« on February 12th, 2012, 02:37 PM »
Quote
Quick mod is just a single checkbox, so it doesn't take space and even if I never really use it, it's still okay to have the checkbox in there...
Actually you'd be surprised in how many places that checkbox turns up, it's more than I realised (display, message index, search, unread/unreadreplies)
Quote
Yeah, that sounds quite odd to me.. Then again, if it's just for people with moderation powers, it's bearable...
That's the point, it isn't. Search is outside of boards, so stuff like lock/pin/etc aren't loaded, so there's no way to know (except for checking global moderator, perhaps) whether or not the user would have these powers, so the query has to be run either way.

The only saving grace is that, by default, the quick moderation is off, so only 3 queries get issued by default, not 11. But I've rewritten boardsAllowedTo by now so that if it receives a single string, it returns a simple array of boards, but if it gets an array, it returns an array (key = permission, value = array of boards where that permission is granted), and it looks like on searching the source that this won't be a problem to do it differently.
4954
The Pub / Re: Quick moderation
« on February 12th, 2012, 02:29 PM »
As an aside, I found that the search handler does some queries based on this, as to whether the user has permission to do different things in each board.

Then I discovered, for each thing it's testing for, there's a query being made. There's 3 queries being run per search without quickmod, and 11 queries being run - per search - with quickmod enabled.

Needless to say, I'm changing how boardsAllowedTo works when confronted with an array, so that it can be made faster than one query per permission.
4955
The Pub / Re: Quick moderation
« on February 12th, 2012, 01:53 PM »
OK, the poll is definitely confirming my suspicions: that not only should quick moderation be just turned on and set to checkboxes, but that the very fact it wasn't turned on by default did confuse some people.

So yeah, time to get busy on the phasing out of stuff :D
4956
Features / Re: New revs
« on February 12th, 2012, 04:27 AM »
(2 files, 1KB)

Revision: 1321
Author: arantor
Date: 12 February 2012 03:26:32
Message:
! Removed ins and del from being supported by the inbuilt 'basic HTML' support. Most people don't realise these tags even exist, let alone use them, and if we end up using them in markup it could get complex otherwise. (Subs-BBC.php)
! Quick reply was actually supposed to be open by default, not shown but closed by default. (install.sql)
----
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/other/install.sql
4957
Features / Re: Board descriptions
« on February 12th, 2012, 04:07 AM »
Well, messageindex_buttons will do the job just admirably anyway, it's just badly named because it's a relic of the dark times. :P (Pull $board_info from global scope, grab the details, inject the new template into the list)
4958
The Pub / Re: Quick moderation
« on February 12th, 2012, 04:06 AM »
Well, I'm trying to find out how many people use them (and so far the poll is trending towards what I long suspected)

To be honest, I'm looking at doing what I already suggested (and I think Nao agreed with), which is to simply pull quick moderation as being an option, and make it hardwired in for those who can see it, so it's always visible.
4959
Features / Re: Profile tab on the main menu
« on February 12th, 2012, 03:51 AM »
Quote from live627 on February 12th, 2012, 03:48 AM
It's better than what I thought up (My Options)
Great minds think alike, eh? (See previous post)

Though I won't argue that there is some validity to My Options.

Don't know if you've used SimpleDesk 2.0 at any point, but there's the preferences page for the helpdesk. Well... in the midst of all that, there's a link on the main HD navigation to get there, and it was discussed what the item should say, and in the end we actually concluded that users would get less confused with 'Options' vs 'Preferences', and history seems to bear that out, actually. But I'm thinking that what works in a helpdesk probably doesn't work quite the same here.
4960
Features / Re: Profile tab on the main menu
« on February 12th, 2012, 03:44 AM »
On the Look & Layout vs My Preferences, I wanted to indicate that it is up to the user (hence the My part) and that if we already have 'My Profile', that's information about them, whereas L&L is things they can configure about the forum that aren't related to how they appear, but how the forum appears to them.

The only alternative is 'My Options', I think, which is even less desirable.
4961
Features / Re: Board descriptions
« on February 12th, 2012, 03:43 AM »
Quote
I think they make sense to keep. Sometimes people click their way into a sub-board, either from the index (with no description) or from another webpage (with varying degrees of context provided.) It makes sense to keep it as an option IMO.
Considering that it's a core SMF feature that's off by default (and is off by default for users), most people have never seen it, nor know what it looks like...

The thing is, I take the view that a description designed for the small confines of the board index (where it might be a 'line' or two there) isn't going to work so well when it has pride of place at the top of the board listing.
Quote
I'm not sure to be honest.
That relates to the above point.

Let's take this board, The Pub -> Features. According to the board listing in The Pub, this board's description is "This is the place to discuss upcoming features, existing features and brag about whatever we implemented in Wedge."

It's quite long on the board index, but it's barely a line wide when considered for the inside of the board.
Quote
Users should only really have access to options that matter much to them (seriously, even on simple devices, users manage to mess things up.) I say it does good as an admin preference.
That's my take on it too.
Quote
As for my personal opinion: I don't know, but I'm sure what you decide on will be a good solution.
That's what I'm hoping to achieve - and I'm thinking about the whole short/long description facility, which implicitly functions as an option for the admin to configure it how they want, and then remove the user option. If the admin wanted it, they'd use it.

Or, I could remove it from display, not bother with the extra, and turn it into a plugin like the 'Board Notice' mod for SMF or similar.
4962
Features / Profile tab on the main menu
« on February 12th, 2012, 02:12 AM »
This might be a bit controversial, but bear with me. It gets a topic of its own because it's that important in my mind.

I think we should rename the tab and some of the options inside it.

As a first off, I think we should rename the tab to be called 'Options' or 'My Options', rename 'Summary' to 'My Profile', and 'Look and Layout' to 'My Preferences'.

Everything after that's a bit more fuzzy, but I think these alone could make it more usable. I'm not averse to doing more complex and big restructure-like things to the profile area, though, but I have no idea in which direction it should really go.

Thoughts?
Posted: February 12th, 2012, 01:37 AM

Oh, and put 'My Preferences' into the main menu, too.
4963
Features / Board descriptions
« on February 12th, 2012, 01:49 AM »
Hmm, there are a few things that bug me about board descriptions at present, would love to know what you think.

1. Board descriptions being shown inside the board too. (Optionally or otherwise) Is this necessary? Given that we're talking the same description on the board index as we are inside the board, is that actually worth doing?

2. Would it not be better to have a main board description that's used on board indexes, and an optional bigger description that can be used inside the boards themselves?

3. Regardless of where the content comes from, is it really necessary that such a description should be a user preference rather than an admin one?

4. Right now the board description is used in favour of the board title for meta description. I'm not sure that's entirely a good idea, but it makes me think that 2 is a better option: supply boxes/storage for both a small description for the board index and a larger description for inside the board itself. That way you can also get a better description in place for SEO purposes etc.

Thoughts?
4964
The Pub / Quick moderation
« on February 12th, 2012, 01:41 AM »
Thinking about making some changes to this from the user perspective, would like to know what you think about it at present.

I have actually already said what I plan to do but would like some general feedback on it first.
4965
The Pub / Re: Wap is that?
« on February 11th, 2012, 06:33 PM »
I bought mine in 2002 and only retired it last year after hardware failure ;)