Wedge

(9 modified, 8KB)

Revision: 1387
Author: arantor
Date: 26 February 2012 16:44:26
Message:
+ Personal messages settings are now in their own page, under Members. I haven't yet pulled everything in, but the most important stuff is there - and it should also disable PMs throughout the system otherwise. It also doesn't clean up things like profile settings, or disabling them through the main permissions area, but we'll get there. (index.php, install.sql, Admin.php, Load.php, ManageSettings.php, Subs.php, Welcome.template.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Welcome.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql

There's an awful lot here >_> I'm actually at the point where I don't know where to start with compiling such a list.That's how I feel about working with Aeva's code a lot of the time, actually. But honestly, if it doesn't work for you, change it. That's the beauty of stuff like this - nothing's set in stone and as such it's fluid and can be adjusted and improved. I'm not convinced that it'll be perfect first time - and nor should it. If you never make mistakes, you never learn anything!In that case I wasn't clear on what you were suggesting, because I thought you meant the master admin tab in the main menu, rather than a sub menu.So... (I just find it easier to visualise it in a real hierarchy)

Configuration
   Features and Settings
      General
      Pretty URLs
      Anti-Spam
   Moderation
      Settings
      Moderation Filters
      Add a new filter rule

Hm. I'd rather bring anti-spam under the moderation menu, really. It's really closer to that than to general configuration. In which case we're really talking about:

Configuration
   Features and Settings
      General
      Pretty URLs
   Moderation
      Anti-Spam
      Warnings
      Settings
      Moderation Filters
      Add a new filter rule

It doesn't save us anything and has a byproduct of pushing things to side entries - I deliberately made Mod Filters a top level item, much as I would do if Post Moderation were its own item (and not configured through mod filters), simply because it's a task of configuration that needs to be prominent - it's forum wide and not subtle.When a topic is moderated, the first post is also moderated.I'm not seeing the problem? If you're validating topic access, the topic's approved state is all that matters - when the topic is approved, the first post is also updated.[1]

Oh. Wait a minute, now I do: it won't apply to messages after the first one.

Actually, though, that's still not a problem. When would you ever make a query against messages when you haven't already checked the topic in some fashion? Be that directly yourself or less directly by way of loadBoard()...It would make a difference, certainly. It's just a little housekeeping that's needed is all.I'll look into it, it's just a bit complicated, heh, and there are things I'd rather do first. That said, right now only you and I have seen this subsystem which means our opinions are a touch polarised on it. What I'd suggest is that we let people play with it and see what works for them.I'll look at it shortly, as part of a few other things I'm doing today.Hey, it was a useful thing to discover, I fixed up an otherwise broken UI because of it :)I'd suggest leaving it as is for now - there are people who aren't going to use moderation filters, no sense penalising them. As  far as tables go, there are plenty of times m isn't the table alias (message index is the one that really comes to mind) so it's not like we can directly make it easy that way, sadly.There isn't a *huge* risk from XSS, because it sort of implies weaknesses elsewhere that have to be compromised too, but in the case I'm thinking of, ' can be used instead of " for quoting attributes.Yes, that's a valid POV (and no, drafts can't be accessed by anyone other than the author - but just as with PMs, admins can still read them in the DB... there are no other protections made in that respect, so the software doesn't enable but it doesn't proactively prevent it either)I wasn't really debating subselect vs join, the real performance is whether the table's able to be kept in memory or not.I guess it just never came up. (And re Kevin Smith, his earlier stuff is far funnier than his latest stuff, though his later stuff is meant to be less comedic, I guess.)This needs its own topic.Essentially you create groups as you see fit and you can share items to none, one or more groups.

1.	Whether it's approved from the view-unapproved-topics page, or from approving the first message directly, it doesn't matter which, both are updated.

That part we need to add, the only thing we can do in Wedge thus far is prevent signatures from being set in the first place with permissions.

My gut instinct tells me it should be made as a preference in the signatures page rather than trying to bolt it on as a regular signature - how many posts to have before displaying such signatures publicly.

And remember, this is *purely* done using the theme system - there are no new templates involved.

Dragging this back on topic a bit, I did some more work on fixing the styling up. Notably, I've altered the menu to be reminiscent of Core's menu - but not that similar.

The board index still needs work as does post display, but the message index looks good :)

So, do you show multiple badges on people? How would you want to configure multiple badges?

Because I was lazy :P I have no problem with using option instead of opt, just laziness on my part.