This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
4666
Archived fixes / Re: Fixed SMF bugs
« on February 29th, 2012, 11:24 PM »
I suppose I could do that, yes. Surprisingly enough that didn't actually occur to me >_<
4667
Archived fixes / SMF bug 4838 (Wrong HTTP-Header created)
« on February 29th, 2012, 11:11 PM »
Ref http://www.simplemachines.org/community/index.php?topic=411507.0
Regarding the use of reason phrases being translated, I have to say that the reporter is incorrect. Certainly as per HTTP 1.1, section 6.1.1 of the specification:Quote The example quoted in the thread is 404 Not Found - if the language in use were Pig Latin (for sake of argument), 404 Otnay Oundfay would be entirely appropriate to send because the browser doesn't care what the text is, only the number.
Regarding of SERVER_PROTOCOL, that's a much trickier question, but HTTP/1.0 is a valid response even to an HTTP/1.1 request given the situation.
Ultimately, I don't think anything needs to be done, but I'm documenting the state of play anyway.
Even in HTTP 1.0, as per 6.1.1 of that spec:Quote So yeah, no need to actually do anything.
Regarding the use of reason phrases being translated, I have to say that the reporter is incorrect. Certainly as per HTTP 1.1, section 6.1.1 of the specification:
The individual values of the numeric status codes defined for HTTP/1.1, and an example set of corresponding Reason-Phrase's, are presented below. The reason phrases listed here are only recommendations -- they MAY be replaced by local equivalents without affecting the protocol.
Regarding of SERVER_PROTOCOL, that's a much trickier question, but HTTP/1.0 is a valid response even to an HTTP/1.1 request given the situation.
Ultimately, I don't think anything needs to be done, but I'm documenting the state of play anyway.
Posted: February 29th, 2012, 01:04 PM
Even in HTTP 1.0, as per 6.1.1 of that spec:
The individual values of the numeric status codes defined for HTTP/1.0, and an example set of corresponding Reason-Phrase's, are presented below. The reason phrases listed here are only recommended -- they may be replaced by local equivalents without affecting the protocol.
4668
Archived fixes / Re: Fixed SMF bugs
« on February 29th, 2012, 11:07 PM »
And, bah, I should have posted this thread *first* because now half the threads would be messed up if I merged them here. Stupid, very stupid >_<
4669
Bug reports / Re: SMF bug 4714 (replace GIFs with PNGs)
« on February 29th, 2012, 08:45 PM »
There's still quite a few icons that aren't CSS driven, but also it would be nice to have some icons that aren't several years old, and are showing their age somewhat.
4670
Bug reports / Re: SMF bug 4714 (replace GIFs with PNGs)
« on February 29th, 2012, 07:50 PM »
It isn't as simple as that, unless you make everything CSS driven. You cannot always get GIFs to look as good as PNG can.
Where CSS is used, it doesn't matter but where CSS is not used, such as the editor icons as was, PNG looks so much better because of alpha transparency.
Where CSS is used, it doesn't matter but where CSS is not used, such as the editor icons as was, PNG looks so much better because of alpha transparency.
4671
Archived fixes / Re: Fixed SMF bugs
« on February 29th, 2012, 07:46 PM »
Eh I wouldn't worry, nothing here is *that serious* because if it was, I'd be hard at work fixing it, as opposed to sitting on my butt. It's simply that there's a lot of bugs that slipped through the net and this was the quickest way to record them so I didn't forget them.
4672
Features / Re: New revs
« on February 29th, 2012, 05:37 PM »
(1 file, 3KB)
Revision: 1409
Author: arantor
Date: 29 February 2012 16:36:40
Message:
! SMF bug: the manage attachments and avatars areas both define a series of numeric inputs using type 'text' which means non numeric variables can be stored in what are supposed to be numeric spaces. (ManageAttachments.php)
! Minor other improvements to manage attachments/avatars, such as setting min/max values on some of the ints, and removing guests from potentially having permission to have an avatar (even though of course they cannot have an avatar, they can theoretically receive permission in SMF!) (ManageAttachments.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Revision: 1409
Author: arantor
Date: 29 February 2012 16:36:40
Message:
! SMF bug: the manage attachments and avatars areas both define a series of numeric inputs using type 'text' which means non numeric variables can be stored in what are supposed to be numeric spaces. (ManageAttachments.php)
! Minor other improvements to manage attachments/avatars, such as setting min/max values on some of the ints, and removing guests from potentially having permission to have an avatar (even though of course they cannot have an avatar, they can theoretically receive permission in SMF!) (ManageAttachments.php)
----
Modified : /trunk/Sources/ManageAttachments.php
4673
Features / Some admin menu changes
« on February 29th, 2012, 05:17 PM »
So Nao suggested a change of the Configuration menu to:Quote I see a couple of issues with this... firstly, I did want to keep Mod Filters as a top level item, as I see it being part of a task-led mentality within the admin panel, but I can see the benefits of Moderation being a top level item too.
OK, here's a thought.
Move Pretty URLs to under Server (as a top level item), then look at moving the items in Features and Settings > General to other pages (creating new pages if necessary, e.g. Who's Online is virtually at enough items to warrant a small page of its own, especially if permissions is moved there too, and the page can be used for admin information purposes too)
That would get rid of Features and Settings entirely (which also suits me quite a bit). As far as Moderation goes, I'm inclined to push that in different ways, moving the warning system stuff under Members > Warnings (since I've talked about putting more options in there anyway)
After that, I'd probably put Filters under Forum somewhere as a top level item (with Add as a sub item in the menu) and Anti-Spam in Members too (again as a top level item, I figure people are going to want to get there in a hurry, and I do imagine there will be mods that will expand that section anyway should they choose to do so; they don't *have* to use the plugins area though it is of course encouraged)
Part of the problem is that most of the Forum stuff is forum specific configuration while what the Configuration area is for is really for 'not forum but *site wide* stuff', except that we don't have much that it is site wide without being quite specific to the forum areas of the installation - there's languages and themes, because they don't deal with the acts of posting etc. and the forum content.
More like... (When it comes to entry names.)
Configuration
Features and Settings
General
---------------
Pretty URLs
Moderation
Settings
---------------
Anti-Spam
Warnings
---------------
Filters
Add filter
(I'm also positive Pretty URLs configuration could still be moved somewhere else, so that Features and Settings could let go of the sub-menus.)
OK, here's a thought.
Move Pretty URLs to under Server (as a top level item), then look at moving the items in Features and Settings > General to other pages (creating new pages if necessary, e.g. Who's Online is virtually at enough items to warrant a small page of its own, especially if permissions is moved there too, and the page can be used for admin information purposes too)
That would get rid of Features and Settings entirely (which also suits me quite a bit). As far as Moderation goes, I'm inclined to push that in different ways, moving the warning system stuff under Members > Warnings (since I've talked about putting more options in there anyway)
After that, I'd probably put Filters under Forum somewhere as a top level item (with Add as a sub item in the menu) and Anti-Spam in Members too (again as a top level item, I figure people are going to want to get there in a hurry, and I do imagine there will be mods that will expand that section anyway should they choose to do so; they don't *have* to use the plugins area though it is of course encouraged)
Part of the problem is that most of the Forum stuff is forum specific configuration while what the Configuration area is for is really for 'not forum but *site wide* stuff', except that we don't have much that it is site wide without being quite specific to the forum areas of the installation - there's languages and themes, because they don't deal with the acts of posting etc. and the forum content.
4674
Archived fixes / Re: SMF bug 4677 (star images need to be renamed)
« on February 29th, 2012, 04:27 PM »
The star image is now properly called when creating new groups as of r1408, but the table has not been changed because there are a lot of places that will be affected - and honestly, I'm fine with the schema as is.
4675
Archived fixes / SMF bug 4794 (error warning in wrong place)
« on February 29th, 2012, 04:26 PM »
For consistency, warning boxes/success notifications should all be in a consistent place and consistently styled - above principle content in the default area (but under menu tabs/tab data) - which the stated places do not adhere to (search personal messages, search generall judging by this post)
Fixed in Wedge r1408.
Posted: February 29th, 2012, 02:33 PM
Fixed in Wedge r1408.
4676
Features / Re: New revs
« on February 29th, 2012, 04:26 PM »
(5 files, 2KB)
Revision: 1408
Author: arantor
Date: 29 February 2012 15:25:31
Message:
! Creating a new group put the wrong image into the table. (ManageMembergroups.php)
! Message index didn't handle drafts properly, due to old code from before I broke the template up. (MessageIndex.template.php)
! Fix SMF bug 4794, PM and search error boxes were in either the wrong place or using the wrong styling. (PersonalMessage.template.php, Search.template.php, sections.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/skins/sections.css
Revision: 1408
Author: arantor
Date: 29 February 2012 15:25:31
Message:
! Creating a new group put the wrong image into the table. (ManageMembergroups.php)
! Message index didn't handle drafts properly, due to old code from before I broke the template up. (MessageIndex.template.php)
! Fix SMF bug 4794, PM and search error boxes were in either the wrong place or using the wrong styling. (PersonalMessage.template.php, Search.template.php, sections.css)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/skins/sections.css
4677
Bug reports / Re: SMF bug 4552 (inconsistencies with memberlist - search)
« on February 29th, 2012, 03:54 PM »
It's not related as far as I know. I only pulled this list from the 50 last updated bug reports (bug 4880 looks like it's a touch older)
4678
Archived fixes / SMF bug 4959 (missing free_result calls)
« on February 29th, 2012, 03:14 PM »
While I think this is unnecessary fussing about a tiny amount, it doesn't hurt to put in such calls (and as my comment from ages ago in the related thread implies, it may have benefits that aren't immediately obvious)
Fixed in Wedge r1407.
Posted: February 29th, 2012, 01:48 PM
Fixed in Wedge r1407.
4679
Archived fixes / SMF bug 4882 (eAccelerator support should be removed)
« on February 29th, 2012, 03:13 PM »
Well, it should. I seem to recall looking at this before, but it should definitely be removed now there is absolutely no use for it, without the key/value cache, it has no benefits in the caching subsystem.
Fixed in Wedge r1407.
Posted: February 29th, 2012, 01:37 PM
Fixed in Wedge r1407.
4680
Features / Re: New revs
« on February 29th, 2012, 03:13 PM »
(10 files, 2KB)
Revision: 1407
Author: arantor
Date: 29 February 2012 14:12:32
Message:
! Fix SMF bug 4959 (missing free_result calls in ManageNews.php) (ManageNews.php)
! Fix SMF bug 4882 (remove eAccelerator support) (smfinfo.php, status.php, Load.php, ManageMaintenance.php, ManageServer.php, Subs-Admin.php, Subs-Cache.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/tools/status.php
Revision: 1407
Author: arantor
Date: 29 February 2012 14:12:32
Message:
! Fix SMF bug 4959 (missing free_result calls in ManageNews.php) (ManageNews.php)
! Fix SMF bug 4882 (remove eAccelerator support) (smfinfo.php, status.php, Load.php, ManageMaintenance.php, ManageServer.php, Subs-Admin.php, Subs-Cache.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/tools/status.php