Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
4636
Archived fixes / Re: SMF bug 4755 (registration disabled still shows links to register)
« on March 1st, 2012, 02:15 PM »
Well, it's not just the menu, there's all sorts of links that don't differentiate between enabled or not. But if there's nowhere to register, it should be fairly obvious (and if you go to action=register it does give you a message about it)
Thing is, I don't know where such a warning would really go otherwise...
Thing is, I don't know where such a warning would really go otherwise...
4637
Archived fixes / SMF bug 4755 (registration disabled still shows links to register)
« on March 1st, 2012, 02:01 PM »
There's quite a few places that the link is shown but of course, it's not really an option at that point.
4638
Archived fixes / SMF bug 4896 (paid subs, and search, can fail if a backup file is present)
« on March 1st, 2012, 01:55 PM »
These do detection based on matching the style of filename, but never detect for ~ endings. While this isn't really a problem for us, because we're not doing backups etc, I think it would be good practice to actually validate that it is a .php file and not anything else. It isn't harmful for what we're doing.
Fixed in Wedge r1413.
Posted: March 1st, 2012, 01:31 PM
Fixed in Wedge r1413.
4639
Archived fixes / SMF bug 4936 (disabling certain bbc in signatures accidentally stops others)
« on March 1st, 2012, 01:55 PM »
If i bbcode is disabled in signatures, img is as well due to the way string matching occurs.
And I even helped fix this one originally >_>
Fixed in Wedge r1413.
And I even helped fix this one originally >_>
Posted: March 1st, 2012, 01:38 PM
Fixed in Wedge r1413.
4640
Archived fixes / SMF bug 4902 (SSI does not issue a header including charset)
« on March 1st, 2012, 01:55 PM »
In our case, everything is UTF-8, so we don't even need to wait to know what the character set is, we can just issue the header directly from SSI.php - if a different header is required, user code can replace it, but it should default to UTF-8 with text/html as a MIME type (because that's, principally, what SSI.php pages do)
Fixed in Wedge r1413.
Posted: March 1st, 2012, 01:44 PM
Fixed in Wedge r1413.
4641
Features / Re: New revs
« on March 1st, 2012, 01:54 PM »
(5 files, 1KB)
Revision: 1413
Author: arantor
Date: 01 March 2012 12:54:10
Message:
! SMF bug 4936 (disabling certain bbc in signatures causes others to fail too) (Profile-Modify.php)
! SMF bug 4902 (SSI does not issue a header with charset) (SSI.php)
! SMF bug 4896 (~ backup files will break paid subs, search and in our case CAPTCHAs too) (ManagePaid.php, ManageSearch.php, Subs-Captcha.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Captcha.php
Revision: 1413
Author: arantor
Date: 01 March 2012 12:54:10
Message:
! SMF bug 4936 (disabling certain bbc in signatures causes others to fail too) (Profile-Modify.php)
! SMF bug 4902 (SSI does not issue a header with charset) (SSI.php)
! SMF bug 4896 (~ backup files will break paid subs, search and in our case CAPTCHAs too) (ManagePaid.php, ManageSearch.php, Subs-Captcha.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs-Captcha.php
4642
Bug reports / SMF bug 4279 (attachment size check can timeout with big attachment folders)
« on March 1st, 2012, 01:51 PM »
This isn't really an issue in Media (which is restricted to 1500 files per album anyway IIRC), but it can be in the attachments setup itself. Should really use the attachments table, which records the size, to do the check.
Something more to bear in mind when Media handles attachments (in the future)
Something more to bear in mind when Media handles attachments (in the future)
4643
Archived fixes / Re: Fixed SMF bugs
« on March 1st, 2012, 01:36 PM »
Well, rhythm/rate can be used interchangeably here ;)
I'm going through page 2 of their bugs now, and just as before, some don't apply to us due to obsolete features, some already got fixed in passing for other reasons and the rest... >_< But no worries, we'll get through everything in due course! Slow and steady wins the race, as they say.
I'm going through page 2 of their bugs now, and just as before, some don't apply to us due to obsolete features, some already got fixed in passing for other reasons and the rest... >_< But no worries, we'll get through everything in due course! Slow and steady wins the race, as they say.
4644
Archived fixes / Re: Fixed SMF bugs
« on March 1st, 2012, 01:13 PM »You'll reach 9k posts by tomorrow at this rhythm, BTW
I'm still groggy from my evening. Totally unable to deal with coding. And it really, really doesn't happen to me often...
4645
Bug reports / SMF bug 3009 (duplicate meta information)
« on March 1st, 2012, 12:12 PM »
On paginated topics in particular, the title is duplicated each page, as is the meta description. While the latter is separately fixable, the title really does need to be updated.
At the very least, we should consider 'Title - Page 2' for pages > 1.
Wedge r1412 adds support for the pagination to be indicated in the page title (but nowhere else)
At the very least, we should consider 'Title - Page 2' for pages > 1.
Posted: February 29th, 2012, 01:41 PM
Wedge r1412 adds support for the pagination to be indicated in the page title (but nowhere else)
4646
Archived fixes / SMF bug 4388 (sort members pending deletion by last login, not registered date)
« on March 1st, 2012, 12:12 PM »
In the approve deletion screen, members are listed by registration date (like they are for approving new accounts), but we should rework that to order by last login, as stated it is likely to be more useful to decide whether to approve the deletion or not.
Fixed in Wedge r1412.
Posted: February 29th, 2012, 01:52 PM
Fixed in Wedge r1412.
4647
Features / Re: New revs
« on March 1st, 2012, 12:12 PM »
(4 files, 7KB)
Revision: 1412
Author: arantor
Date: 01 March 2012 11:11:29
Message:
! Partial fix for SMF bug 3009 (duplicate title/meta info) - there are now page numbers appended to the page title on the first invocation of template_page_index; since it is called prior to the body_above template, as it is also used in certain ways to clean up incoming data, we don't have to mess around with much work to do this. Not the cleanest it could be, mind. (index.template.php, index language file)
! SMF bug 4388: when displaying the list of approvals, show the last login column for pending-deletion members, and date registered for all other cases. (ManageMembers.php, ManageMembers language file)
! Related to the above, the tabs in the manage members area were using old code, now brought up to date and working correctly. (ManageMembers.php)
----
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Revision: 1412
Author: arantor
Date: 01 March 2012 11:11:29
Message:
! Partial fix for SMF bug 3009 (duplicate title/meta info) - there are now page numbers appended to the page title on the first invocation of template_page_index; since it is called prior to the body_above template, as it is also used in certain ways to clean up incoming data, we don't have to mess around with much work to do this. Not the cleanest it could be, mind. (index.template.php, index language file)
! SMF bug 4388: when displaying the list of approvals, show the last login column for pending-deletion members, and date registered for all other cases. (ManageMembers.php, ManageMembers language file)
! Related to the above, the tabs in the manage members area were using old code, now brought up to date and working correctly. (ManageMembers.php)
----
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Modified : /trunk/Themes/default/languages/index.english.php
4648
Archived fixes / Re: SMF bug (untracked?) Flood time limits are enforced for admins
« on March 1st, 2012, 11:41 AM »
That was where I was going ;) Note that if you bump up the limit to - say - 10 seconds, it does so for everyone, but honestly, I'm inclined to think that if you're limiting everyone like that (including yourself) and you make it too high, you're going to annoy yourself enough to put it back ;)
4649
Archived fixes / Re: SMF bug (untracked?) Flood time limits are enforced for admins
« on March 1st, 2012, 11:25 AM »
Well, it's not as if it's a lot of code, theory says it should be no more than half a dozen lines of code... so it should be doable as an option, but I am wondering if it is needed. The default is 2 seconds between posts, it's only because I was spamming a thread for other test purposes that I even noticed.
4650
Archived fixes / [Won't fix] SMF bug: Flood time limits are enforced for admins
« on March 1st, 2012, 10:35 AM »
I'm not sure whether I'd classify this as a real bug or not, maybe it's desirable? Anyhow, the flood time limit (e.g. 'posts must be x seconds apart') is applied even for admins.
The only thing I would say in its defence is that in the event the admin's account is compromised, it does provide *some* limiting factor. But if the account is compromised, there's more that could be damaged or screwed up in its stead anyway...
:edit: Updated title.
The only thing I would say in its defence is that in the event the admin's account is compromised, it does provide *some* limiting factor. But if the account is compromised, there's more that could be damaged or screwed up in its stead anyway...
:edit: Updated title.