Wedge

No, they won't upgrade yet. There are still hosts running 5.2 which is a few years old as it is.

To a degree, this is why SMF always suggests use of repair_settings.php to fix everything.

As far as the attachment pruning, I seem to recall 0 being ignored as it falls foul of empty(), though it is a little unlikely to want to prune everything. I'm not sure it is a bug as a result. But I can look into it.

To clarify: preparsecode will do some operations to any bbcode to sanitise it (like strip 'html' bbcode from non admins), but it will also do expansions on things like /me and reformat certain URL type bbcodes to use full URLs.

This is a particularly tricky situation - because while a signature may be shorter than the limit, by the time it's preparsed it will may well go over the limit - and it may prevent subsequent saves to the signature too (if for example a URL is expanded, and it goes from limit - 1 to over the limit, you won't be able to save that signature even unchanged), and that's before we get into the realms of dealing with the line breaks becoming br tags.

What we might have to do is move the preparsecode before the length test, but proceed to flatten line breaks to a single character for the purposes of fairness.

Yes, that is what it is ultimately about, however at the time (and now, really), I figured it was only about stopping those characters rather than \b, though \b should work just fine.

And actually, theoretically, there could be a bbcode that contains a character that matches \b... it would be ugly of course but not impossible.

Fixed in Wedge r1414.

(16 files, 5KB)

Revision: 1414
Author: arantor
Date: 01 March 2012 14:53:19
Message:
! SMF bug 4836 (linktree_inline legacy items) (install.sql, Display.php, MoveTopic.php, Post.php, Themes language file)

! SMF bug 4755 (registration disabled but links still shown) (SSI.php, index.template.php, Login.template.php, index and Login language files)

! SMF bug 4742 (forum stats disabled but still accessible) (Stats.php, Errors language file)

! Minor improvement to maintenance manage-members template. (ManageMaintenance.template.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/InfoCenter.template.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql

But now at least there isn't a registration button, nor is there the 'Please login or register' message (it's now just 'Please login' for registration disabled)