Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
4606
Bug reports / SMF bug 4860: $_SESSION['login_url'] misbehaves, especially from SSI
« on March 2nd, 2012, 12:51 PM »
I've noticed this on and off since 2.0 RC1.2 but never spent enough time to examine why it happened. Need to spend more time on this one, because there's no reason for it to misbehave.
And oddly enough I cannot cause it to misbehave. It works exactly as I would expect it to.
All I've done for testing is to create the following file:
Code: [Select]
And that worked exactly as expected, storing the login_url properly. Thing is, I can find no flaws in the chain of events that would ever cause it to be dropped. (Not even in SMF.)
Posted: March 2nd, 2012, 10:48 AM
And oddly enough I cannot cause it to misbehave. It works exactly as I would expect it to.
All I've done for testing is to create the following file:
<?php
require('SSI.php');
ssi_login('....?action=profile'); // obviously using the real URL
?>And that worked exactly as expected, storing the login_url properly. Thing is, I can find no flaws in the chain of events that would ever cause it to be dropped. (Not even in SMF.)
4607
Archived fixes / SMF bug 4904 - external avatar URLs dropping %20 from the URL
« on March 2nd, 2012, 12:13 PM »
At least the replacement needs to be altered to prevent this, but it is worth spending a moment to explore whether rawurlencode is worth applying here or not (possibly not)
I've patched this in r1417, but I haven't done rawurlencode on it yet.
I was about to mark this one as done then I suddenly had a thought, and bad mojo happens if it contains fun characters like ', like an uncaught exception if it has to go do a web lookup.
Actually, I was wrong, the exception wasn't occurring because of the fun characters (they simply get htmlspecialchars'd somewhere as far as I can tell, no idea why that is right now), but because the URL I'd supplied caused a redirect which threw an exception. So I beefed up exception handling, and made things fall back cleaner to a 'safe' state.
Posted: March 2nd, 2012, 10:34 AM
I've patched this in r1417, but I haven't done rawurlencode on it yet.
I was about to mark this one as done then I suddenly had a thought, and bad mojo happens if it contains fun characters like ', like an uncaught exception if it has to go do a web lookup.
Posted: March 2nd, 2012, 11:46 AM
Actually, I was wrong, the exception wasn't occurring because of the fun characters (they simply get htmlspecialchars'd somewhere as far as I can tell, no idea why that is right now), but because the URL I'd supplied caused a redirect which threw an exception. So I beefed up exception handling, and made things fall back cleaner to a 'safe' state.
4608
Features / Re: New revs
« on March 2nd, 2012, 12:10 PM »
(3 files, 2KB)
Revision: 1418
Author: arantor
Date: 02 March 2012 11:09:59
Message:
! Improved attachment handling if the supplied URL is not valid for one reason or another. (Class-WebGet.php, Profile-Modify.php, Subs.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs.php
Revision: 1418
Author: arantor
Date: 02 March 2012 11:09:59
Message:
! Improved attachment handling if the supplied URL is not valid for one reason or another. (Class-WebGet.php, Profile-Modify.php, Subs.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Subs.php
4609
Archived fixes / SMF bug 4783 (incorrect language string in paid subs area)
« on March 2nd, 2012, 11:46 AM »
Easy fix this one.
Though, curiously, I appear to have broken other things in the paid subs area, so I'll fix that at the same time.
Fixed in r1417.
Though, curiously, I appear to have broken other things in the paid subs area, so I'll fix that at the same time.
Posted: March 2nd, 2012, 11:07 AM
Fixed in r1417.
4610
Archived fixes / SMF bug 4840 (disabling search engine tracking can break who's online)
« on March 2nd, 2012, 11:44 AM »
Curious error, though probably not very common to occur.
Fixed in Wedge r1417. Oddly enough it was a very simple fix, not even as complex as the one suggested in the bug report (no need to mess around unsetting session, just test session is set and that the relevant $show_method is also set. In our case it's even the very same isset call.
Posted: March 2nd, 2012, 11:09 AM
Fixed in Wedge r1417. Oddly enough it was a very simple fix, not even as complex as the one suggested in the bug report (no need to mess around unsetting session, just test session is set and that the relevant $show_method is also set. In our case it's even the very same isset call.
4611
Features / Re: New revs
« on March 2nd, 2012, 11:43 AM »
(6 modified, 3KB)
Revision: 1417
Author: arantor
Date: 02 March 2012 10:42:30
Message:
! SMF bug 4783 (wrong language string in the paid subs area) (ManagePaid.php)
! SMF bug 4904 (dropping %20 from avatar URLs) (Profile-Modify.php)
! SMF bug 4840 (disabling search engine tracking could break who's online) (Who.php)
! Fixed length subs could not be saved properly due to two form items having the same name (and overriding one another) (ManagePaid.php, ManagePaid.template.php)
! Minor profile layout bug when an error is thrown (Profile.template.php)
! Wrong header type used in who's online (Who.template.php)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
Revision: 1417
Author: arantor
Date: 02 March 2012 10:42:30
Message:
! SMF bug 4783 (wrong language string in the paid subs area) (ManagePaid.php)
! SMF bug 4904 (dropping %20 from avatar URLs) (Profile-Modify.php)
! SMF bug 4840 (disabling search engine tracking could break who's online) (Who.php)
! Fixed length subs could not be saved properly due to two form items having the same name (and overriding one another) (ManagePaid.php, ManagePaid.template.php)
! Minor profile layout bug when an error is thrown (Profile.template.php)
! Wrong header type used in who's online (Who.template.php)
----
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
4612
Bug reports / SMF bug 4779 (moderator notes UI breaks after entering a note)
« on March 2nd, 2012, 11:02 AM »
Still happens, though less drastically - the textbox+button is pushed down under the content, overflow causes it to be scrollable but it leaves the textbox+button scrolled out of view as per screenshot.
Also note the moderator box is shorter than the container next to it.
Also note the moderator box is shorter than the container next to it.
4613
Bug reports / SMF bug 4952 (compressed files not always being inflated properly)
« on March 2nd, 2012, 10:57 AM »
This is potentially irrelevant, as it depends on 1) keeping any of the current unpacking code features (theme install, plugin install)[1] and 2) keeping the implementation as it is and not replacing it with Zip_Archive or similar.
| 1. | I've been toying with the idea of forcing such things to be done by FTP anyway rather than getting into the quagmire of permissions etc. |
4614
Bug reports / SMF bug 4954 (poll options can get mixed up when > 127 options)
« on March 2nd, 2012, 10:53 AM »
This is curious.
I could understand > 255 failing because the choice is stored as an unsigned tinyint, but I have no idea why it gets out of step for 128-255.
I could understand > 255 failing because the choice is stored as an unsigned tinyint, but I have no idea why it gets out of step for 128-255.
4615
Bug reports / SMF bug 4897: url/iurl auto link doesn't necessarily work as expected for sigs
« on March 2nd, 2012, 10:51 AM »
This one is somewhere in the murky ground between 'not a bug'/'by design' and 'not expected behaviour'.
The summary is that if you disable auto linking/url/iurl in the master bbcode options (under post options) but enable them in signatures, they still won't be parsed because the master list is disabled.
The design says that the list of sig bbc is simply what is *permitted* in a sig, not what will be parsed, but that's not necessarily either the most desirable behaviour nor the expected behaviour, and what would be ideal is to be able to switch between the two lists as needed. I don't think it'll be a *huge* performance hit since it can be done once per parse_bbc call rather than in the scary loops.
The summary is that if you disable auto linking/url/iurl in the master bbcode options (under post options) but enable them in signatures, they still won't be parsed because the master list is disabled.
The design says that the list of sig bbc is simply what is *permitted* in a sig, not what will be parsed, but that's not necessarily either the most desirable behaviour nor the expected behaviour, and what would be ideal is to be able to switch between the two lists as needed. I don't think it'll be a *huge* performance hit since it can be done once per parse_bbc call rather than in the scary loops.
4616
Archived fixes / SMF bug 4763 - menu hook doesn't work properly when caching level >= 2
« on March 2nd, 2012, 10:46 AM »
There are two separate issues being discussed but they're heavily related.
Firstly, the items in the menu are cached - including the consequences of calling a hook. Which means on caching level 2, weird things can happen where plugin menu items won't necessarily be displayed (or worse, they'll continue to be displayed even when deactivated)
Secondly, determining the active menu item is potentially inaccurate because of the above.
I'm sort of wondering what the point of caching it is, though. It's very straightforward as it stands, and in fact the caching can screw things up given the gallery unread count.
Perhaps it would simply be better not to cache it at all.
Firstly, the items in the menu are cached - including the consequences of calling a hook. Which means on caching level 2, weird things can happen where plugin menu items won't necessarily be displayed (or worse, they'll continue to be displayed even when deactivated)
Secondly, determining the active menu item is potentially inaccurate because of the above.
I'm sort of wondering what the point of caching it is, though. It's very straightforward as it stands, and in fact the caching can screw things up given the gallery unread count.
Perhaps it would simply be better not to cache it at all.
4617
Archived fixes / Re: Fixed SMF bugs
« on March 2nd, 2012, 10:38 AM »I've never really used that one. Don't even know if it works with Wedge actually...
Also, max width and max height for attachment thumbnails are set to 400 in your code... Any reason for that? Even here, the max width is much higher than that. I changed it locally to 1280x1024 which is probably good enough for maximum thumbnail dimensions...
Looking at this site, I don't think any thumbnail size is set (that's what 0 is for) but image attachments are capped at 640 wide, which means no thumbnail is generated.
Speaking of which, how about setting 'int' to have a 'min' of 0 by default? You've already set it to 0 pretty much everywhere, really...
4618
Features: Forward thinking / Re: Removing deprecated code
« on March 1st, 2012, 11:21 PM »
Not that we use them much, but late static binding's quite a draw, better support for closures too, and the garbage collector's smarter when it comes to cyclic references (which helps deal with memory leaks)
On a smaller note, 5.3 also brought mysqlnd as a replacement under the hood for the old libmysqlclient connector, which aside from solving a messy licensing issue is actually faster and cleaner.
On a smaller note, 5.3 also brought mysqlnd as a replacement under the hood for the old libmysqlclient connector, which aside from solving a messy licensing issue is actually faster and cleaner.
4619
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on March 1st, 2012, 11:18 PM »
That particular page is proper admin settings, which I don't have.[1] Besides, there is something quite *nice* about having limits to work within, brings out the optimiser in me.
The best solution, really, to this problem says to me that a rethink of "what the aim of sig bbc options is there for" might be necessary.
What purpose is it trying to solve?
Well, it's trying to solve signature abuse with mashups of horrendous markup.
What purpose does the signature length have?
It prevents people from having obscenely large signatures.
In that respect, the setup is mostly fine as it is, that it's not the intent that's at fault, but the execution. But there's a side effect to the signature length - it also limits how many links and so on.
Do we want to limit the number of links that can be in a signature? Or number of images?
Could be interesting but it's also a can of worms because that implies things like per-group settings. (Though, having regular members/moderators/admins as divisions seems quite sane to me. But even then I can imagine sites wanting to give out 'extra links' as a premium member perk)
Would/should we get rid of bbc choices?
I'm inclined to leave it alone, for one reason: it does prevent people making lists and tables in signatures if the admin so chooses, which can be good from a formatting point of view.
The best solution, really, to this problem says to me that a rethink of "what the aim of sig bbc options is there for" might be necessary.
What purpose is it trying to solve?
Well, it's trying to solve signature abuse with mashups of horrendous markup.
What purpose does the signature length have?
It prevents people from having obscenely large signatures.
In that respect, the setup is mostly fine as it is, that it's not the intent that's at fault, but the execution. But there's a side effect to the signature length - it also limits how many links and so on.
Do we want to limit the number of links that can be in a signature? Or number of images?
Could be interesting but it's also a can of worms because that implies things like per-group settings. (Though, having regular members/moderators/admins as divisions seems quite sane to me. But even then I can imagine sites wanting to give out 'extra links' as a premium member perk)
Would/should we get rid of bbc choices?
I'm inclined to leave it alone, for one reason: it does prevent people making lists and tables in signatures if the admin so chooses, which can be good from a formatting point of view.
| 1. | And before anyone gets confused why I don't have full admin access, it's simply because I don't need full admin to do what I do, and I'm a *huge* fan of not having more permissions than I actually need. |
4620
Features: Forward thinking / Re: Removing deprecated code
« on March 1st, 2012, 11:02 PM »
Decent mixin support is more than long overdue in PHP (though depending on what you're doing it can be very fragile and break in unexpected ways), though it has of course been possible to implement in various interesting ways.
Short arrays? *shrug* I have to say I'm just not that 'gimme RIGHT NOW' about 5.4, whereas 5.3 brought stuff that was immediately useful.
Short arrays? *shrug* I have to say I'm just not that 'gimme RIGHT NOW' about 5.4, whereas 5.3 brought stuff that was immediately useful.