Wedge

That's part of the problem, separately, that it uses the count of items there as the id of the next item to insert (as opposed to tracking what the next item would really be), which is how they get messed up in the first place.

It sort of is auto-inc and sort of isn't... >_<

(17 modified, 2KB)

Revision: 1425
Author: arantor
Date: 04 March 2012 02:12:26
Message:
! SMF bug 4442 (name="submit" used in forms which can break onsubmit functionality) A lot of these can actually be pruned, a few left require *something*, so those use name="save" instead. Nothing seems to be broken as a result of this change. (all files)
! Unclosed form tag. (ManageMedia.template.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageMedia.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/other/tools/repair_settings.php

All the 'cancel' link on an AJAX notification does is hide the 'Loading...' notification.

While we could theoretically just change the text to say 'close', I'd rather we either removed it entirely or we actually made it cancel. That shouldn't be too problematic, since we should be able to call .abort() on the object being used to handle the XHR itself (AIUI, jQuery > 1.5 exposes all methods from the XHR)

All we'd actually need to do is have it so that when we show the notification, we pass something to it by which we can call the abort... assuming we do that. If we don't, it gets a bit trickier to handle. Mind you... if we have two concurrent AJAX requests for whatever reason and both trigger 'Loading', it's impossible to know which would actually be cancelled.

Hmmm. Maybe it should just be renamed (or simply remove the hide button since having it really doesn't achieve anything useful)

Bumpity. Inclined to simply remove the hide button, by the way, unless anyone has any burning issues with wanting to actually attempt to cancel the AJAX request?

(1 file, 1KB)

Revision: 1424
Author: arantor
Date: 04 March 2012 01:12:06
Message:
! The full request URI was only being evaluated for 'is it a 404 image' in the event that pretty URLs was enabled, failing that it would never evaluate the URI properly, so the 404-handler never kicked to log missing images. This is early enough in the process that it occurs before the log write occurs, which is awesome. Also, no need to update the online log with a 404 error. (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php

Yup. If you have a poll with 3 options, they use ids 0 through 2. Even if you remove something, the next id will be 3.

Well... it depends how you define 'dynamic' entries. More than one button is already variable depending on state, e.g. the login and register buttons.

As far as the admin menu goes, simple expansions that only add their own page and nothing more, they're already sort of cached and don't need to load any files, they're in $settings.

I have thought about doing something similar for the main menu too, so that simple menu buttons (nothing that is *too* dynamic) from plugins can be handled much the same, leading to files not being loaded just to make a tiny change to the array.

For more complex cases, caching is probably useless anyway and will convolute things more than it'll help.

It's not even as simple as that potentially. Remember that you get regional codes too, en_GB vs en_US for example.You only need to do it once at the start of installation remember.