Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
4561
Features / Re: New revs
« on March 4th, 2012, 06:33 PM »
(4 modified, 2KB)
Revision: 1427
Author: arantor
Date: 04 March 2012 17:33:17
Message:
! SMF bug 4757: allow deleting spider stats as well as logs. (ManageSearch.template.php, ManageSearch.template.php)
! Clean up of a language string. (Search.english.php)
! Other areas of manage-search-engines were not properly accessible. (ManageSearchEngines.php)
! Do not show spurious linktree entries when on the ACP front page. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/languages/Search.english.php
Revision: 1427
Author: arantor
Date: 04 March 2012 17:33:17
Message:
! SMF bug 4757: allow deleting spider stats as well as logs. (ManageSearch.template.php, ManageSearch.template.php)
! Clean up of a language string. (Search.english.php)
! Other areas of manage-search-engines were not properly accessible. (ManageSearchEngines.php)
! Do not show spurious linktree entries when on the ACP front page. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/languages/Search.english.php
4562
Features / Re: Board access
« on March 4th, 2012, 06:25 PM »
Oh, crap, I also need to fix Detailed Reports > Boards.
4563
Features / Re: Some admin menu changes
« on March 4th, 2012, 04:43 PM »
Here's a (bad) mockup of the idea I had for doing this.
Thoughts?
The idea is to point you in the directions of stuff you're likely to want to change up front, rather than anything else.
Thoughts?
The idea is to point you in the directions of stuff you're likely to want to change up front, rather than anything else.
4564
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 03:39 PM »
Well, you'd only have to attach it in two places - in the master getXmlDocument and sendXmlDocument handlers, everything else should be using those from what I remember (instead of raw jQuery $.ajax) and then everything works :)
4565
Features / Re: Some admin menu changes
« on March 4th, 2012, 03:38 PM »
But what?
You see, the odds are quite strongly in favour of setting up different things depending on the forum's use.
Mind you, I have an idea about that, that's quite a bit separate to what you're suggesting but should achieve the same result.
You see, the odds are quite strongly in favour of setting up different things depending on the forum's use.
Mind you, I have an idea about that, that's quite a bit separate to what you're suggesting but should achieve the same result.
4566
Features / Re: Some admin menu changes
« on March 4th, 2012, 03:34 PM »
Oh, sure, but what do you set up first on a site?
4567
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 03:34 PM »
Displaying a nice message to the user would solve that part. Then we could remove the button (leaving the spinner in for a nice look? Or simply removing it entirely, either works)
4568
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 03:28 PM »
I haven't tried it in Wedge with jQuery but certainly in SMF, if the response returned to getXMLDocument or sendXMLDocument was invalid, it would hit an error and end processing before it got to close the box.
There's no actual error handling attached, no warning to the user, the only things that are visible are the lingering box and the fact that what they asked for may not have been done.
There's no actual error handling attached, no warning to the user, the only things that are visible are the lingering box and the fact that what they asked for may not have been done.
4569
Archived fixes / SMF bug 4817 (can't register if no agreement and COPPA age set)
« on March 4th, 2012, 03:20 PM »
The underlying problem is that if there is no agreement, there's no confirmation that the user is over COPPA age.
As I see it there are two choices, either disallow using COPPA when there's no agreement, or provide a substitute page that does do the 'I confirm I am over x years of age' test.
Fixed in r1426.
As I see it there are two choices, either disallow using COPPA when there's no agreement, or provide a substitute page that does do the 'I confirm I am over x years of age' test.
Posted: March 2nd, 2012, 11:11 AM
Fixed in r1426.
4570
Features / Re: New revs
« on March 4th, 2012, 03:20 PM »
(6 modified, 3KB)
Revision: 1426
Author: arantor
Date: 04 March 2012 14:19:26
Message:
! SMF bug 4817 (unable to register if COPPA is enabled but no agreement is used) (all files)
! A little clean-up where some error strings were moved from Login to Errors because they're errors. (Register.php, Login + Errors language files)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
Revision: 1426
Author: arantor
Date: 04 March 2012 14:19:26
Message:
! SMF bug 4817 (unable to register if COPPA is enabled but no agreement is used) (all files)
! A little clean-up where some error strings were moved from Login to Errors because they're errors. (Register.php, Login + Errors language files)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Login.english.php
Modified : /trunk/Themes/default/languages/Login.french.php
4571
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 02:44 PM »
Which still takes us back to the original problem: you're just closing the notification, you're not closing the AJAX request, which seems like a waste to me.
More than that, most of the time it breaks, it's not breaking because of the connection/page being slow to serve but that the response returned is invalid, so really having it cancel the request isn't that useful in most cases, and IMO neither is closing the notification. What we should be doing is error handling it instead.
More than that, most of the time it breaks, it's not breaking because of the connection/page being slow to serve but that the response returned is invalid, so really having it cancel the request isn't that useful in most cases, and IMO neither is closing the notification. What we should be doing is error handling it instead.
4572
Features / Re: Some admin menu changes
« on March 4th, 2012, 02:42 PM »
I'm slightly wary of having a page of 'what one might want to set on first setup' because it seems like it'd be different in every case, and I'm eager to not clutter the page more than is necessary - that's why I didn't commit the 'favourites' thing I tried out, because I found it didn't really add anything that useful to it (even if it were at individual subpages, it doesn't add anything *that* useful)
4573
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 02:39 PM »These people are the reason SMF added the button in the first place.
In any case, if the AJAX is taking that long to perform a lookup, odds are they should be coming to us for help anyway because something is obviously wrong...
4575
Archived fixes / Re: SMF bug 4962 (pressing cancel on the AJAX notification doesn't cancel it)
« on March 4th, 2012, 02:13 PM »
Wedge uses its own spinner image (not SMF's one), and something I never noticed before... somewhere along the change, the spinner itself is actually the cancel button, there's no separate cancel button any more.
This to me says 'remove', but more than that, the number of people who post on sm.org about issues with this do not realise there is a close button on it because it just 'hangs' there for them.
This to me says 'remove', but more than that, the number of people who post on sm.org about issues with this do not realise there is a close button on it because it just 'hangs' there for them.