This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
4441
Bug reports / Re: Possible incorrect behaviour in fatal error handling?
« on March 11th, 2012, 01:13 PM »
I will at some point, but it probably won't be today.
4442
Off-topic / Re: IT'S OVER 9000!
« on March 11th, 2012, 01:04 PM »
Actually, no, it's the second.
4443
Other software / [live627's rants] Re: These trees are [not] simple
« on March 11th, 2012, 01:06 AM »
At a glance, getBoardTree looks reasonably sane?
4444
Features / Re: Home button
« on March 11th, 2012, 01:05 AM »
Well, I was lazy and mindful of a few things. The way it's implemented is that there is the original Home menu and an extra site_home item before it. In the event that the home URL is empty, the site_home item is show = false, and the normal menu is the 'home' item (caption determined the same way). This has the side benefit that all the usual action detection/highlighting the right item works as expected.
In the event that the home URL is populated, this extra menu is show = true, the caption of the regular menu item is also changed, but in all other respects, it's business as usual.
Since the icon is set in CSS, it's keyed off .m_home (which would make the other keyed off .m_site_home)... if we wanted to have the "home button" have the house icon when the extra button is off, but have another icon when not, we'd need to alter the key itself of the menu, so that we can use different CSS for it.
Which would ultimately mean either unsetting and re-inserting a new array item, which isn't the cheapest thing in the world, or we bastardise the menu thusly:
Code: [Select]
And I'm not even sure that's legal syntax, even if it is, it's ugly. But that's the only ways to do it.
In the event that the home URL is populated, this extra menu is show = true, the caption of the regular menu item is also changed, but in all other respects, it's business as usual.
Since the icon is set in CSS, it's keyed off .m_home (which would make the other keyed off .m_site_home)... if we wanted to have the "home button" have the house icon when the extra button is off, but have another icon when not, we'd need to alter the key itself of the menu, so that we can use different CSS for it.
Which would ultimately mean either unsetting and re-inserting a new array item, which isn't the cheapest thing in the world, or we bastardise the menu thusly:
'site_home' => array(...),
(empty($settings['home_url']) ? 'home' : 'community') => array(...),And I'm not even sure that's legal syntax, even if it is, it's ugly. But that's the only ways to do it.
4445
Off-topic / Re: IT'S OVER 9000!
« on March 10th, 2012, 11:43 PM »
It made me feel like something in my life hasn't been a waste, you know? I feel like a lot of the last 10 years has been for me right now. Shallow? Perhaps, but it made me feel good if only for a passing moment.
4447
Features / Re: Poll mode
« on March 10th, 2012, 10:42 PM »I thought that having a 0/1 choice only in a key was going to hurt performance..? Like t.approved?
In terms of indexing, we never query based on 'has poll/has no poll' so it doesn't need to be added to any of the indexes on the topics table.
The MySQL documentation tends to contradict itself on this.
In our case, VARCHAR(255) means 255 characters but that it will probably need a 2 byte length in UTF-8 because 129 Japanese characters, for example, will overflow 255 bytes in physical length.
This is ultimately where the performance penalty of using UTF-8 comes in, where you're expressly not using a single byte character set where you don't have to worry about byte length vs character length.
Plenty that I could think of when seeing the list, really...
4448
Off-topic / Re: IT'S OVER 9000!
« on March 10th, 2012, 07:49 PM »
I doubt it, I'm not exactly lithe or known for agility or dexterity, I'm a wisdom/intelligence/constitution kinda guy.
4449
Off-topic / IT'S OVER 9000!
« on March 10th, 2012, 01:51 PM »
MY POST COUNT :D
That is all. Have a good day.
That is all. Have a good day.
4450
Bug reports / Re: SMF bug 4779 (moderator notes UI breaks after entering a note)
« on March 10th, 2012, 01:50 PM »
Do we actually need the moderator notes?
Would an overhaul of the moderation center be a better use of time?
Would an overhaul of the moderation center be a better use of time?
4451
Bug reports / Re: SMF bug 4905 (signature length verified before preparsecode)
« on March 10th, 2012, 01:50 PM »
There's an interesting suggestion been made, that the preparsing essentially should happen twice.
What I'm thinking it might be simpler to do is perform the expansions that would normally occur, then do validation on length, so not quite full preparsing. Mind you, it does depend a lot on the comments about, about what signatures 'need'.
What I'm thinking it might be simpler to do is perform the expansions that would normally occur, then do validation on length, so not quite full preparsing. Mind you, it does depend a lot on the comments about, about what signatures 'need'.
4452
Features / Re: Intrigued by a vB feature
« on March 10th, 2012, 01:30 PM »
Bump for justice.
Should we have more AJAX stuff? What would people like to see? (I'm sensing people are going to point to the flow in XenForo at this point, though honestly it doesn't 'flow' much better than SMF/Wedge to me)
Should we have more AJAX stuff? What would people like to see? (I'm sensing people are going to point to the flow in XenForo at this point, though honestly it doesn't 'flow' much better than SMF/Wedge to me)
4453
Features / Re: Requiring JS in the admin panel
« on March 10th, 2012, 01:27 PM »
OK, I'll add this in a bit (hopefully later today depending on how things work out). My plan of action is to do as I did in SimpleDesk, create a new template block with the <noscript> message (and an icon, just for the sake of nicety) and inject it into the skeleton above all the content.
4454
Features / Re: Home button
« on March 10th, 2012, 01:26 PM »
So, if the house icon stays with the forum menu, what should the icon for the overall site (Home) button be?
4455
The Pub / Re: Logo Madness
« on March 10th, 2012, 01:24 PM »Okay, haven't spoken Spanish since 1987 or so. Sue me!
(Heck, even if it's a comment on the difference between the logo in badges and the logo in signatures, because yes they're slightly different on the left, that would be useful.)