Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
4246
Archived fixes / [Fixed] Re: Displaying incorrect topic views
« on March 19th, 2012, 12:56 PM »
Yeah, took me a minute of staring at it thinking "WTF is wrong with you?" but it does make sense in the end :)
4247
Archived fixes / [Fixed] Re: Displaying incorrect topic views
« on March 19th, 2012, 12:52 PM »
Or, more accurately, the removal of comma_format.

In the template it goes through number_context, to get the right string. What was happening is that it was seeing 1 500 or whatever, recasting it to int and getting 1 out of it. Though, curiously, it was getting the _n string. Anyhow, number_context does its own comma formatting anyway.
4248
Archived fixes / [Bug?] Re: Layout problem with long titles
« on March 19th, 2012, 12:46 PM »
Quote
Yeah, but I tend to take it personally... Not consciously, but I know my stress level is akin to what I would feel if I felt bad after locking everyone out of the site for 20 minutes... (Oh, maybe that's because that just happened :P)
These things happen, and on a site that's known to be running alpha software, it's somewhere between allowed and expected. We know full well we've only just deployed Wedge and that we saw many, many things we weren't expecting. That's cool, because it gives us the opportunity to test things in a way we never would have locally, and we've seen bugs emerge out of it that we can fix, so that we get a better result at the end of the day.

To be brutally honest, I actually think it's gone better than I expected it to go, but that just goes to show how strong the work that everyone who's contributed has put in, be it in code, or the importer, or just with their thoughts and suggestions.
Quote
I'm confident with that. I'm just a little upset that we had way more bugs out in the open than we originally expected. Heck, I thought Wedge was really bug-free at this point... :^^;:
Part of me is disappointed, because I thought so too, but the practical part of me (which is larger) was well aware that things hadn't been battle hardened or testing under pressure and that things were going to go wrong. At least they're going wrong here where we can evaluate them properly.
Quote
Should I put this board out of the Pub...? Perhaps?
It's cool where it is for now. We can always reorganise it later.
Quote
I know that the pub prefix is really for 'public', as opposed to our private area, but I don't think we're gonna keep everyone to the pub prefix forever..?
I still sense we're going to have private areas in the future too, if only to discuss things like security matters that shouldn't be discussed publicly, and if I'm really honest, I like having a bit of space where we can open ideas quietly to close friends without broadcasting plans openly. It's not that I don't trust people, it's that I've noticed that stuff in the less public areas has a higher signal:noise ratio and tends to have more specific feedback about changes and suggestions.
4249
Archived fixes / Preparsing adds url bbc where it shouldn't
« on March 19th, 2012, 12:32 PM »
Multiple cases now we've seen preparsing (especially on edits, but sometimes on first posting) perform hard conversion of bare URLs to [url]link[/url], especially when it occurs inside img tags, breaking the tag.

I've seen this on and off for a while but I thought I'd fixed it a bit back - but apparently not.
4250
Archived fixes / [Bug?] Re: Layout problem with long titles
« on March 19th, 2012, 12:19 PM »
Quote
Please give me about a week to fix *everything* as best as I can.
There's no hurry :)

It's more a case of people reporting stuff that's broken, as they see it. You and I both know it'll all get sorted out in the end, it's just going to take a little bit of time to make that all happen - but it will get sorted out. The trick is to not let it get on top of us, which is why I'm looking to organise this board - so that we can assess what's done vs what hasn't been done yet, so that we can focus our time on what needs doing.

Yes, there's a lot to do - but we'll get there :)
4251
Archived fixes / [Bug?] Re: Layout problem with long titles
« on March 19th, 2012, 11:23 AM »
Out of interest, what browser are you using?

The title itself is defined as using text-overflow, so that on browsers which support it (like Chrome), it will be auto-truncated and have ... added at the end automatically.
Posted: March 19th, 2012, 11:14 AM

Hmm, I have a feeling that it will require .postheader h5 to also gain a max-width declaration as certain browsers don't apply text-overflow without it (IE, I'm looking at you)
Posted: March 19th, 2012, 11:15 AM

Eh, ignore me, you said it was Chromium.

And that does show it requires a max-width to be defined - because while it's performing the truncation, it's performing it based on a bigger width than it actually has to play with (as you can see, it's truncated - but still overflowing)
4252
Archived fixes / [Bug] Re: Displaying incorrect topic views
« on March 19th, 2012, 11:20 AM »
:)

This should be applied when the next rollout of patches occurs, as it's applied as rev 1484.
4253
Features / Re: New revs
« on March 19th, 2012, 11:20 AM »
(1 file, apparently so small a change, TSVN reckoned it was 0KB)

Revision: 1484
Author: arantor
Date: 19 March 2012 10:19:44
Message:
! Replies/views count could get misformatted in the message index. (MessageIndex.php)
----
Modified : /trunk/Sources/MessageIndex.php
4254
Archived fixes / [Bug] Re: Displaying incorrect topic views
« on March 19th, 2012, 10:58 AM »
OK, I've fixed this locally and will push it into the repository on my next commit (since I want to fix a few other things first)
4255
Archived fixes / [Bug?] Re: Layout problem with long titles
« on March 19th, 2012, 10:55 AM »
Hmm, yeah, I see what you mean.

I'd noticed the (new) sometimes got cropped on very long titles but this is a bit different. Title definitely needs to learn to wrap :)
4256
We're the same, some of the changes were made months and months ago ;)
4257
Archived fixes / [Bug] Re: Displaying incorrect topic views
« on March 19th, 2012, 10:46 AM »
OK, that's... weird, because if you look in the topic itself it has the right number. Thanks for reporting it, I'll look into it.
4258
Yes, we are aware of this.

Pretty URLs breaks report to moderator, issue warning was broken but fixed by me this morning - but I don't currently have FTP access, and I want to leave the message here for debugging purposes, in case it's specific to the pretty URL in this topic.

It's also interesting to note that the *only* defence we have currently is my custom CAPTCHA, and this is still the first spam post since the move 3 days ago, we're not even using custom questions here at the present time.
Posted: March 19th, 2012, 10:44 AM

@Dragooon, it's also the little ! icon under the user's name.
4259
Features / Re: New revs
« on March 19th, 2012, 10:10 AM »
(1 file, 1KB)

Revision: 1483
Author: arantor
Date: 19 March 2012 09:09:38
Message:
! Warning template was using old JavaScript code, with some incorrect styling to boot. (Profile.template.php)
----
Modified : /trunk/Themes/default/Profile.template.php
4260
Archived fixes / [Bug] Re: PM gets multiplied
« on March 18th, 2012, 11:19 PM »
I've never had any problems with post drafts, it was only PM drafts that were being sent instead of being saved. Hopefully that should no longer be a problem :)