Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
3616
Archived fixes / Re: custom.js detection throws errors
« on April 25th, 2012, 11:27 PM »
Yup, here it will simply contain '1561' so it can be easily put into the footer and updated quickly. But it won't be in the mainline code by the time we get to pushing out proper Wedge builds.
I might go away and write a plugin to handle it here, actually.
I might go away and write a plugin to handle it here, actually.
3617
Archived fixes / Re: custom.js detection throws errors
« on April 25th, 2012, 11:18 PM »
That was documented a bit back, and since the number of people who have source access is small, we don't tend to worry about explaining it - it's mostly for this site only so that updating the SVN rev in the footer is quick and easy. Me? I just created rev.txt and put 'SVN' in it to avoid any problems, heh.
custom.js is a bit different, though, because it's something that will generally be handled, not a one-off like rev.txt is.
custom.js is a bit different, though, because it's something that will generally be handled, not a one-off like rev.txt is.
3618
Archived fixes / custom.js detection throws errors
« on April 25th, 2012, 11:13 PM »file_get_contents(C:\wamp\www\wedge/Themes/default/scripts/custom.js) [<a href='function.file-get-contents'>function.file-get-contents</a>]: failed to open stream: No such file or directory
3619
Archived fixes / (SMF bug) Admin registering a user, email does not send a link to the forum
« on April 25th, 2012, 10:38 PM »
It's not something I think you'd encounter that often but a user that I look after just reported this to me in SMF and I see no reason why we would have touched this thus far.
If you register a user from the admin panel, it will email them with the username and password but it actually won't email them a link to the forum >_<
And because of how the templates are set up, well, it's a bit more complex. I'm going to document the SMF code fix here because that's what has to be done first, but then we can fix it in Wedge just after since the code should be virtually if not actually identical.
We need to create somewhere we can actually inject the $scripturl into. Themes/default/languages/EmailTemplates.english.php:
Code: [Select]
Replace with:
Code: [Select]
The line's a bit crap but I deliberately did not want to leave it as the closing element on the line, for all the fun and games the trailing . would leave.
Other thoughts:
After finding loadEmailTemplate, I discovered that {SCRIPTURL} is a replacement that's already handled natively there, though I have to admit I didn't think it was, and started digging into where the replacements were defined in Subs-Members.php for that email. Though I have to say, loadEmailTemplate is in a funny place and it makes me wonder about doing other things with restructuring internal facilities, perhaps like moving all the email functions into one place and invoking that when needed rather than this other slightly weird hierarchy of things needed. (Subs-Post.php, primarily, for all the email related stuff, even sending PMs)
If you register a user from the admin panel, it will email them with the username and password but it actually won't email them a link to the forum >_<
And because of how the templates are set up, well, it's a bit more complex. I'm going to document the SMF code fix here because that's what has to be done first, but then we can fix it in Wedge just after since the code should be virtually if not actually identical.
We need to create somewhere we can actually inject the $scripturl into. Themes/default/languages/EmailTemplates.english.php:
'admin_register_immediate' => array(
'subject' => 'Welcome to {FORUMNAME}',
'body' => 'Thank you for registering at {FORUMNAME}. Your username is {USERNAME} and your password is {PASSWORD}.
{REGARDS}',
),Replace with:
'admin_register_immediate' => array(
'subject' => 'Welcome to {FORUMNAME}',
'body' => 'Thank you for registering at {FORUMNAME}. Your username is {USERNAME} and your password is {PASSWORD}.
You can reach {FORUMNAME} by visiting {SCRIPTURL} in your browser.
{REGARDS}',
),The line's a bit crap but I deliberately did not want to leave it as the closing element on the line, for all the fun and games the trailing . would leave.
Other thoughts:
After finding loadEmailTemplate, I discovered that {SCRIPTURL} is a replacement that's already handled natively there, though I have to admit I didn't think it was, and started digging into where the replacements were defined in Subs-Members.php for that email. Though I have to say, loadEmailTemplate is in a funny place and it makes me wonder about doing other things with restructuring internal facilities, perhaps like moving all the email functions into one place and invoking that when needed rather than this other slightly weird hierarchy of things needed. (Subs-Post.php, primarily, for all the email related stuff, even sending PMs)
3620
The Pub / Re: Database Backup, Restore and Repair
« on April 25th, 2012, 08:49 PM »
Ah, well, the WP export basically pushes out an XML file that contains the content of posts. It's not a full DB export, doesn't necessarily hold all meta data for posts, doesn't necessarily hold all the related information like post owners on multi-author blogs, which to me doesn't seem that useful.
3621
Archived fixes / Drafts being saved is not shown in QR
« on April 25th, 2012, 08:38 PM »
I now have 53 pages of drafts (at 15 per page!) that have been saved where the AJAX call is being made to save a draft but the response is not properly being handled, so not only does the 'remove draft' button not appear, but the draft is also not purged on posting because the id is never injected into the form.
3622
Test board / Re: Characters in CP-1252 that don't work, apparently
« on April 25th, 2012, 08:35 PM »
Apparently it's an SMF bug.
Also of note is that the fourth column (the second instance of characters) were all entities before I posted, so entities are not treated as literals but converted to entities. This has all sorts of interesting consequences.
Also of note is that the fourth column (the second instance of characters) were all entities before I posted, so entities are not treated as literals but converted to entities. This has all sorts of interesting consequences.
3623
Features / Re: Board Icons
« on April 25th, 2012, 08:34 PM »
A lot of people like to change those icons, even though it removes the meaning of new/no new posts in the process. Other people like to have separate icons next to the new/no new icons.Quote It confused me, to be honest, because I thought it was some JS-is-broken bug, it wasn't until Aaron commented on it that I realised it was intentional (and the moderation checkbox is still in the old place, which detaches it from having any obvious meaning.Quote I think it would actually be better since it's not actually as cluttered as it could have been before.Quote Saving space is important there, so moving quote/modify is fine, but I think using the action bar would be good :)Quote That's more a problem with short, or chunky posts that don't have a lot of paragraph breaks.Quote Interesting, I didn't know about that.
Speaking of icons -- what do you think of today's rewrites for the action bar? I renamed .moderatorbar to .actionbar (because really, what was the semantic point of showing .modified inside that? I got so much confused by it, I'd actually declared .moderatorbar in index.member.css...!), and moved the action menu there. I changed the global opacity to make it less striking, and I think the result is quite good. More importantly, this (finally) fixes the header bar which was always a bit too crowded with icon + title + reply number + date + actions + action menu + moderation checkbox...
- Eats a little more vertical space for guests, or any post that hasn't been modified and that the user has no control over -- i.e. post has no 'last modified' date or Quick Edit button. It's no big deal, and I think FluxBB already has a bar at the bottom and nobody complained about that. IIRC Nightwish also brought a bottom bar to his Eos theme redesign...
- Mobile mode -- should I reset it or leave it as is? I think I'll reset it so that it uses the action bar... The main point is that in order to save space, I moved the Quote and Modify buttons to the action menu in mobile mode, even though these menus are a (tiny bit) harder to navigate in mobile mode than desktop mode.
- The post can feel a bit 'trapped' between the header and action bars... I added some generous extra vertical padding to help. Should be fine.
Ah, and before I go... Remember the ugly dollarfix thing in SMF/Wedge? That's in topic.js... Well, I understood what it was all about. It's actually NOT AN IE BUG, contrary to what the comment says. I was misled by this. In fact, when applying a regex replacement in JS, "$" is a meta-character and any proper "$" needs to be escaped to "$$" before it can be used as a replacement string...
3624
Features / Re: New revs - Public comments
« on April 25th, 2012, 07:46 PM »
Hmm, I thought it was a bug originally >_> I guess I'm not yet adjusted to it, and I'm not entirely sure I like it yet, but maybe it'll grow on me. Especially since the checkbox for it is kept separate now from that menu making it even more weird for me. :/
3625
The Pub / Re: Database Backup, Restore and Repair
« on April 25th, 2012, 07:45 PM »
Whatever you do, you're going to get into issues when trying to fudge around those limits. They're not really changeable.
Have you ever seen the output of WP's export? It really isn't actually that useful, IMO, such that I ended up eschewing it entirely, heh, just as I have with SMF's export.
Have you ever seen the output of WP's export? It really isn't actually that useful, IMO, such that I ended up eschewing it entirely, heh, just as I have with SMF's export.
3626
Test board / Characters in CP-1252 that don't work, apparently
« on April 25th, 2012, 07:33 PM »
80 € U+20AC € Euro reserved control
82 ‚ U+201A ‚ Low-"9" opening quotation mark Break Permitted Here
83 ƒ U+0192 ƒ1 or ƒ Florin/script f/folder No Break Here
84 „ U+201E „ Low-"99" opening quotation mark Index
85 … U+2026 … Ellipsis Next Line
86 † U+2020 † Single dagger Start of Selected Area
87 ‡ U+2021 ‡ Double dagger End of Selected Area
88 ˆ U+02C6 ˆ Circumflex ^ accent (combining?) Character Tabulation Set
89 ‰ U+2030 ‰ o/oo per mille Character Tabulation with Justification
8A Š U+0160 Š1 or Š S + caron accent Line Tabulation Set
8B ‹ U+2039 ‹ Single left angle quote < (guillemet) Partial Line Down
8C ΠU+0152 ΠOE ligature Partial Line Up
8E Ž U+017D Ž2 or Ž Z + caron accent Single Shift Two
91 ‘ U+2018 ‘ "6" opening quotation mark Private Use One
92 ’ U+2019 ’ "9" closing quotation mark/apostrophe Private Use Two
93 “ U+201C “ "66" opening quotation mark Set Transmit State
94 ” U+201D ” "99" closing quotation mark Cancel Character
95 • U+2022 • Solid bullet Message Waiting
96 – U+2013 – En-dash Start of Guarded Area
97 — U+2014 — Em-dash End of Guarded Area
98 ˜ U+02DC ˜ Tilde ~ accent (combining?) Start of String
99 ™ U+2122 ™ Trademark TM reserved control
9A š U+0161 š1 or š s + caron accent Single Character Introducer
9B › U+203A › Single right angle quote > (guillemet) Control Sequence Introducer
9C œ U+0153 œ oe ligature String Terminator
9E ž U+017E ž2 or & #382; z + caron accent Privacy Message
9F Ÿ U+0178 Ÿ Y + diaeresis/umlaute accent Application Program Command
82 ‚ U+201A ‚ Low-"9" opening quotation mark Break Permitted Here
83 ƒ U+0192 ƒ1 or ƒ Florin/script f/folder No Break Here
84 „ U+201E „ Low-"99" opening quotation mark Index
85 … U+2026 … Ellipsis Next Line
86 † U+2020 † Single dagger Start of Selected Area
87 ‡ U+2021 ‡ Double dagger End of Selected Area
88 ˆ U+02C6 ˆ Circumflex ^ accent (combining?) Character Tabulation Set
89 ‰ U+2030 ‰ o/oo per mille Character Tabulation with Justification
8A Š U+0160 Š1 or Š S + caron accent Line Tabulation Set
8B ‹ U+2039 ‹ Single left angle quote < (guillemet) Partial Line Down
8C ΠU+0152 ΠOE ligature Partial Line Up
8E Ž U+017D Ž2 or Ž Z + caron accent Single Shift Two
91 ‘ U+2018 ‘ "6" opening quotation mark Private Use One
92 ’ U+2019 ’ "9" closing quotation mark/apostrophe Private Use Two
93 “ U+201C “ "66" opening quotation mark Set Transmit State
94 ” U+201D ” "99" closing quotation mark Cancel Character
95 • U+2022 • Solid bullet Message Waiting
96 – U+2013 – En-dash Start of Guarded Area
97 — U+2014 — Em-dash End of Guarded Area
98 ˜ U+02DC ˜ Tilde ~ accent (combining?) Start of String
99 ™ U+2122 ™ Trademark TM reserved control
9A š U+0161 š1 or š s + caron accent Single Character Introducer
9B › U+203A › Single right angle quote > (guillemet) Control Sequence Introducer
9C œ U+0153 œ oe ligature String Terminator
9E ž U+017E ž2 or & #382; z + caron accent Privacy Message
9F Ÿ U+0178 Ÿ Y + diaeresis/umlaute accent Application Program Command
3627
Features / Re: Board Icons
« on April 25th, 2012, 07:30 PM »
Interesting idea, though I'm very keen not to implement certain things like that as regular uploads in the ACP because of security concerns, at least if it goes anywhere outside the attachments or media folders.
(I have a huge problem with dealing with the permissions aspects, since I don't want to have it where files etc. are writable generally just because of the problems it will inevitably cause. I have a solution in mind for the plugin system and infrequently changed things like that but not for a general thing like boards, especially if we allow for boards to be created by users rather than admins.)
(I have a huge problem with dealing with the permissions aspects, since I don't want to have it where files etc. are writable generally just because of the problems it will inevitably cause. I have a solution in mind for the plugin system and infrequently changed things like that but not for a general thing like boards, especially if we allow for boards to be created by users rather than admins.)
3628
The Pub / Re: Number of 'online users'
« on April 25th, 2012, 07:05 PM »
There isn't at present but I suppose it could be; since you need to be signed in, and they need to be signed in, between them it's fairly trivial to do. It will probably be more useful than seeing what guests are online, actually ;)
3629
The Pub / Re: Number of 'online users'
« on April 25th, 2012, 06:58 PM »
Yup, I actually mentioned that one, since the same log is used there too, and it would end up being limited to online users only.
The problem with it being an aftermarket plugin is that it is core functionality in Wedge with cookie handling and I suspect it would be a mess to make a plugin out of. But it's certainly feasible, I guess. You're right that people will want that, even though they're chasing something that's inaccurate and unhelpful (IMO)
I'm not intentionally copying you, but I find it interesting that we've looked at the same things - though with slightly different reasons behind it.
The problem with it being an aftermarket plugin is that it is core functionality in Wedge with cookie handling and I suspect it would be a mess to make a plugin out of. But it's certainly feasible, I guess. You're right that people will want that, even though they're chasing something that's inaccurate and unhelpful (IMO)
I'm not intentionally copying you, but I find it interesting that we've looked at the same things - though with slightly different reasons behind it.
3630
The Pub / Re: The Cookie Law (in the UK at least)
« on April 25th, 2012, 06:45 PM »
It's not even a communist attitude. It's actually more of a fascist approach where the state dictates your life.
What I will say, as I said to a colleague of mine last week: I cannot and will not defend the likes of SOPA or PIPA, I cannot do so with a whole heart, and there is nothing well meaning or well intentioned in those laws.
This law, however badly implemented, at least has one argument in its defence: even though it is written by lawmakers who don't understand how the internet works, it is written with the intention of protecting one's privacy and enshrining that into law that privacy is not an entitlement or right conferred upon the higher-ups but mandated into law that all have the right and expectation of privacy in an increasingly online world. I disagree with many aspects of implementation but I can fully stand up and justify its intent.
What I will say, as I said to a colleague of mine last week: I cannot and will not defend the likes of SOPA or PIPA, I cannot do so with a whole heart, and there is nothing well meaning or well intentioned in those laws.
This law, however badly implemented, at least has one argument in its defence: even though it is written by lawmakers who don't understand how the internet works, it is written with the intention of protecting one's privacy and enshrining that into law that privacy is not an entitlement or right conferred upon the higher-ups but mandated into law that all have the right and expectation of privacy in an increasingly online world. I disagree with many aspects of implementation but I can fully stand up and justify its intent.