Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
3541
Archived fixes / Re: SMF bug 4913 (convert fopen/fwrite to file_put_contents)
« on April 27th, 2012, 10:14 PM »
I did switch over the file cache today while I thought about it because it will solve the problems attached to using fwrite, making it more robust. The rest... *shrug* They're typically not cases for conversion, but I'll leave this open for now in case I can be bothered to go look.
3542
Features / Re: New revs
« on April 27th, 2012, 10:12 PM »
(5 files, 14KB)
Revision: 1566
Author: arantor
Date: 27 April 2012 21:10:10
Message:
! Convert file cache to use file_put_contents instead of fwrite. It's something I meant to do ages ago but forgot about, but it should solve the cases where the file was only being partially written to the 8KB boundary. (SMF have also implemented it, though we both did it independently, I think) (Subs-Cache.php)
! There's now a timezone selector on the registration page too. It isn't pretty, it does no magic detection of timezone so it defaults to American Samoa time but at least we're on the way to solving things. Also, the bug in the profile page should be fixed where it was showing the wrong saved value. (Profile-Modify.php, Register.php, Register.template.php, Login language file)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
@ To answer the point about the file cache, the reason it was breaking at the 8KB boundary is because of the way fwrite caps at 8KB under certain circumstances but it isn't a problem because it's rare that more than 8KB is cached at once. However, we can use file_put_contents instead these days which is a bit faster and has no such issues.
Revision: 1566
Author: arantor
Date: 27 April 2012 21:10:10
Message:
! Convert file cache to use file_put_contents instead of fwrite. It's something I meant to do ages ago but forgot about, but it should solve the cases where the file was only being partially written to the 8KB boundary. (SMF have also implemented it, though we both did it independently, I think) (Subs-Cache.php)
! There's now a timezone selector on the registration page too. It isn't pretty, it does no magic detection of timezone so it defaults to American Samoa time but at least we're on the way to solving things. Also, the bug in the profile page should be fixed where it was showing the wrong saved value. (Profile-Modify.php, Register.php, Register.template.php, Login language file)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/languages/Login.english.php
@ To answer the point about the file cache, the reason it was breaking at the 8KB boundary is because of the way fwrite caps at 8KB under certain circumstances but it isn't a problem because it's rare that more than 8KB is cached at once. However, we can use file_put_contents instead these days which is a bit faster and has no such issues.
3543
Archived fixes / Re: Drafts being saved is not shown in QR
« on April 27th, 2012, 09:21 PM »
>_> I get confused so easily these days.
3544
Archived fixes / Re: Drafts being saved is not shown in QR
« on April 27th, 2012, 09:11 PM »
I forgot about addQMark :/ It would certainly be cleaner to use that than an inline ternary.
3545
Archived fixes / Re: Drafts being saved is not shown in QR
« on April 27th, 2012, 08:58 PM »
There aren't many places we do that in JS, actually from what I can remember. Hmm, a generic function could be used, I guess.
3546
Archived fixes / Re: In passing...
« on April 27th, 2012, 07:46 PM »
Moving this to fixed since it's not really a valid bug.
3547
Archived fixes / [Bug] Re: Unable to reply a post
« on April 27th, 2012, 07:45 PM »
Anyway, this bug seems to be solved?
The Tapatalk stuff... that's not actually a Tapatalk bug AFAIK but bots doing bad things.
The Tapatalk stuff... that's not actually a Tapatalk bug AFAIK but bots doing bad things.
3548
Bug reports / Re: Pretty URL remarks
« on April 27th, 2012, 07:22 PM »
It's not a simple x is faster than y argument, either. If you have stuff in the DB that's being called frequently, assuming you don't have a stupid DB layout and bad queries, there's a reasonable chance that you might be able to get some of that stuff out of the query cache, and if the table isn't too huge, you might even get it entirely into memory anyway, and RAM is faster than HD for things like that ;)
3549
Archived fixes / Re: Drafts being saved is not shown in QR
« on April 27th, 2012, 06:51 PM »
Yes it does. It takes the URL that the form would be submitted to anyway and pokes ;xml onto the end. I'll get it to check for ? first before it does that.
I think this should have been fixed in r1565.
Posted: April 27th, 2012, 06:34 PM
I think this should have been fixed in r1565.
3550
Archived fixes / Re: Error when posting a large image...
« on April 27th, 2012, 06:50 PM »
The original error is fixed in r1565, though the other stuff is not relevant at this debate.
3551
Archived fixes / Re: (SMF bug) Admin registering a user, email does not send a link to the forum
« on April 27th, 2012, 06:49 PM »
Committed in r1565.
3552
Features / Re: New revs
« on April 27th, 2012, 06:49 PM »
(5 files, 2KB)
Revision: 1565
Author: arantor
Date: 27 April 2012 17:48:31
Message:
! No need to check for GD when doing certain types of image work. (Subs-Graphics.php)
! Auto-removed topics do not need to go to recycling. (Subs-Scheduled.php)
! Minor formatting bug with a line break not being added when it should. (MoveTopic.template.php)
! Admin registration of users should notify the user of the relevant URL as well. (EmailTemplates.english.php)
! Drafts code made an assumption about the URL that wouldn't be true with latest PURLs code. (post.js)
----
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/scripts/post.js
Revision: 1565
Author: arantor
Date: 27 April 2012 17:48:31
Message:
! No need to check for GD when doing certain types of image work. (Subs-Graphics.php)
! Auto-removed topics do not need to go to recycling. (Subs-Scheduled.php)
! Minor formatting bug with a line break not being added when it should. (MoveTopic.template.php)
! Admin registration of users should notify the user of the relevant URL as well. (EmailTemplates.english.php)
! Drafts code made an assumption about the URL that wouldn't be true with latest PURLs code. (post.js)
----
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/scripts/post.js
3553
Archived fixes / Re: Drafts being saved is not shown in QR
« on April 27th, 2012, 06:20 PM »
Well, it's working entirely as expected locally, but here there's a problem causing it to break. The POST is made to wedge.org/pub/bugs/do/post2/;xml with all the proper form data, and there's a 302 header pushed back (though the proper behind-the-scenes occurs) and it redirects to the full URL behind the scenes.
It then doesn't return the correct data and creates errors as a result - there have been 6 attempts while writing this post and all went wrong and all caused JS errors in response.
It then doesn't return the correct data and creates errors as a result - there have been 6 attempts while writing this post and all went wrong and all caused JS errors in response.
3554
Archived fixes / Re: Buffer hook never called
« on April 27th, 2012, 06:13 PM »
Since this is fixed, moving it to fixed bugs.
3555
Features / Re: Moving topics, you can now send a PM
« on April 27th, 2012, 05:59 PM »
I actually didn't implement it with floating boards in mind, it was mostly to support the changes to how board access was evaluated.