Wedge

1) I think the behaviour needs to be predictable and documentable but that's all it needs to be.

2) Plugins will just splice themselves into the normal menus, and/or splice themselves into the template layers as given. Provided display_main is still called and there's some way for a plugin to know that it's being called via infinite scroll vs not by infinite scroll... hell, could even provide two hooks - one that will be run for each post a la display_main and one that is only run for the first place (for things like topic_solved to splice its information into the page, that's not needed every iteration of page load, only the 'master' load for a topic)

3) That sounds like a huge and drastic change :(

9 files, 18KB

Revision: 2159
Author: arantor
Date: 07 June 2013 21:21:01
Message:
! weget is going to need to support other methods in future. (Class-WebGet.php)

! Some refactoring fun of the search API ready for other search backends to be added in due course. (Load.php, ManageSearch.php, RemoveTopic.php, Search2.php, SearchAPI-Custom.php, SearchAPI-Standard.php, Subs-Post.php, ManageSearch.template.php)
----
Modified : /trunk/Sources/Class-WebGet.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Standard.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/ManageSearch.template.php

Firstly, yes, there is some removed stuff - things like 'the choice over quick moderation being icons/checkboxes/off' (it's just checkboxes). But it's stuff that we didn't want, didn't feel comfortable with and removed it because it made sense to us to remove it. I have no problem defending any decision we've made and the basis on which it was made.

Secondly, we're talking about a guy who describes himself as a redneck.

Thirdly, I have no idea why it bothers me as much as it does. I don't like people talking smack about me behind my back, but has popped up here occasionally to say how good things are looking. I'm like Mal Reynolds, if I'm going to shoot you, you'll be awake, armed and facing me.

Fourth, I'm annoyed because I vouched for him and gave him beta access. I'm not normally a bad judge of character. But this time I was and it annoys me.

-- a former beta tester, yesterday. So, let's put the record straight. A year ago, I compiled this list. Let's see what's in there now. Interestingly it's been a year to the day since that previous post.

Added
Auto embedding
Gallery
Posting and PM drafts
Flexible skin support using LESS syntax, including vendor prefix abstraction (and changed default theme, of course)
bbc/WYSIWYG editor in the quick reply area
Thoughts system
Likes
Per topic feeds
Bad Behaviour integrated by default
IPv6 support
Template macros such as <we:cat>
JavaScript and CSS files are minified by default, and JS files are automatically deferred to late in the script for extra smoothness
Merge double posts
User and action menus in posts
Automatic quote splitting
Spoiler, footnotes, more bbc
Gravatar support
Using a board as a blog
A revised plugin manager that supports web based uploading WITHOUT CHANGING FILE PERMISSIONS AT ALL
Moderation filter system that allows admins to define rules for content management (e.g. moderation on a post automatically for containing rude words)
Q&A that supports multiple languages and multiple answers per question
Responsive sidebar
Displaying of multiple badges per user in the poster information and drag 'n' drop to configure what order they are shown in
Ability to use colour, bold, italic, underline and arbitrary CSS for all user names based on their primary group
Notifications system
Ability to edit registration agreement from the admin panel without requiring file write access, and also forcing users to re-accept it (and either locking them out the forum or simply barring them from posting until they accept it)
Ability to search and edit all language files, including plugins, from the admin panel, including showing both the master and current values
Ability to edit email templates from the admin panel
Ability to see who voted in a poll with proper privacy controls
Display reported posts in the user's profile
Rewritten ban system, including IPv6 support, ability to handle GMail type emails (user+tag@domain.com, user.name = username and similar constructions)
Rewritten warning system, including selective punishments per warning including but not limited to removal of signature, removal of avatar, posts being altered, moderation, bans
Ability to 'soft ban' a user, similar to Annoy User
Ability to send individual items out of the mail queue
Mass move topics is now more selective than just 'everything in a board', you can pick boards to move from, as well as other criteria
Merge two user accounts together
Moderation centre shown on the board index as if it were a real category (but it isn't a real category, it just looks like one)
Centralised popup system even for general prompts and OK/cancel notifications, which is styleable (unlike standard browser ones)
Custom fields now have proper privacy controls, are drag 'n' drop to rearrange the order and can optionally be shown on the memberlist too
Pinned topics can be drag 'n' drop rearranged
Group access can not only be given to boards, it can also be revoked (unlike SMF)
Board access is also split between seeing it and entering it, including the option to add a custom message to users who can see a board but not access its content
The SMF 'member options' area is replaced with one that doesn't have 'per theme' hassle and is actually quicker to use to set what you want
Proper timezone support for users (set timezone on registration, not a number of hours offset... even daylight savings works perfectly)
News items are also drag 'n' drop for reordering, show the bbc editor interface and also have privacy options attached now
Better internationalisation support in general
Logins can be username/email, username only, email only
Customised selectbox that shows images and other HTML (useful for selecting icons)
Search removed from the main menu and made in to a sexy popup
Use of HTML5 inputs wherever possible
phpinfo() shown in the admin panel
Your buddies/contact list is shown in the PM area with a nice clicky interface
Admins can now set which boards can be ignored by users
When splitting a topic, the new topic can be in a different board
When issuing a redirection, you can also set the redirection topic to actually redirect you automatically (and if it's to a board you can't see, a nicer error is shown to you)
Topic privacy
Topics have a good meta description now

This doesn't include the various and numerous, SMF bug fixes or the various underlying changes required to make any of it work.

Currently being added
Infinite scroll in topics
Proper Sphinx and ElasticSearch support

Changed
Default theme
Admin front page
Completely new CAPTCHA even down to including a new font (and replacing all the old SMF fonts)
Better page navigation
Revamped theme layer system
Some code rewritten to use better OOP
PMs automatically save to outbox, there's no option for it, nor is it something you can disable
Improved newsletter interface

Removed
Non UTF-8 support
PostgreSQL/SQLite
PHP below 5.2
move, glow, shadow bbc
SMF's buggy package manager
Support for really bad hosts like 000webhost
Spell checker
Fulltext searching (custom indexes are almost always better, if Sphinx/ES aren't an option)
"Simple" permissions
Calendar - now in a plugin


There are probably other things I've forgotten, too. But of course, it's just SMF with a few new features, right? RIGHT?!?! And it's not like we're adding new features or anything.

Of course it's not. I don't know why I'm letting myself get annoyed. I find it amusing that the person who makes such comments 1) does so in a place where he KNOWS I won't normally see them and can't defend myself or Wedge (someone considerately informed me via PM), 2) came here only a few days ago to ask for my help with his project, after all the shite I had with him a bit back and seemed *surprised* that I wasn't interested in helping them and 3) tells me off for things before doing them himself

Mind you, said person is talking about his own forum software in Python and Django which will obviously be better than anything else out there. Assuming he ever finishes any of it. This is after both his own PHP based software, and his subsequent SMF fork, have already fallen by the wayside.

Until you have people doing crazy stuff like iframes around the forum. Or most embed code going forward (not just YouTube)I was kind of hoping you were building it via the msg skeleton so it could serve arbitrary slices of topics...If you're pulling the full page and manipulating it there and then, surely you can just run any other JS at that point in time?

I dunno, bit pissed off and a bit frazzled from the search crap right now :(

Yeah, the nesting thing is a security thing to limit people pulling in things they shouldn't. The only way really is not to nest iframes. Or indeed not use iframes if at all possible :/

Surely the secondary load (page 2 or whatever) knows it's loaded via AJAX... so it just needs to include the code for calling the menu for the items in question... the menu constructor plus main data (what buttons are available) will already be loaded so it's just a case of submitting the extra menu data and some glue, right?

Should be fixed in r2158. If you'll notice, it's not that the link is not coloured, it is actually pointing to the wrong page entirely. (And because it's the wrong link, it gets the wrong colouring.)

What's happening is that it was pulling the parent thought's owner as the child thought's owner id and building the link off that even though it has the right name to work off (because *that* join is correct)