Show Posts
This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Messages - Arantor
2911
The Pub / Re: Print Page
« on August 20th, 2012, 11:33 PM »
I wouldn't bother with the CSS print page in core to be honest. It's just one more thing to bug test on.
2912
(5 files, 2KB)
Revision: 1666
Author: arantor
Date: 20 August 2012 21:58:28
Message:
! Updated BB implementation for 2.2.8 (or at least the bits I actually want) (Security.php)
! Don't limit the size of the mail queue items. It's possible that announcements/notifications could be larger than a text. (install.sql, Subs-Post.php)
! The subject should also be quote-protected in the split page area too. (Split.php)
! Merge topics dropdown was using old code. (Merge.template.php)
! Merge topics might also use the same dropdown style as other dropdowns, using optgroups for categories. (Merge.template.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Merge.template.php
Modified : /trunk/other/install.sql
Revision: 1666
Author: arantor
Date: 20 August 2012 21:58:28
Message:
! Updated BB implementation for 2.2.8 (or at least the bits I actually want) (Security.php)
! Don't limit the size of the mail queue items. It's possible that announcements/notifications could be larger than a text. (install.sql, Subs-Post.php)
! The subject should also be quote-protected in the split page area too. (Split.php)
! Merge topics dropdown was using old code. (Merge.template.php)
! Merge topics might also use the same dropdown style as other dropdowns, using optgroups for categories. (Merge.template.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Split.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Merge.template.php
Modified : /trunk/other/install.sql
2913
The Pub / Re: Print Page
« on August 20th, 2012, 10:55 PM »
I've never used print-page to print anything, I have used it a few times to save archive copies of a thread for surreptitiously sending to people.
2914
The Pub / Re: RSS feeds (Was: Some admin options required)
« on August 20th, 2012, 09:17 PM »
Perhaps we could hide RSS feeds for boards that are not visible to guests?
Seems to me that would likely be the most logical thing, given that most readers can't deal with the cookies attached to the browser.
Seems to me that would likely be the most logical thing, given that most readers can't deal with the cookies attached to the browser.
2915
Archived fixes / Re: Logging password errors
« on August 20th, 2012, 09:15 PM »
This is finished now, yes?
2916
(9 files, 4KB)
Revision: 1665
Author: arantor
Date: 20 August 2012 20:11:13
Message:
! [SMF bug] XSS vulnerability in moderation log (thanks Anonchair) (Modlog.php)
! Since we're no longer escaping quotes in topic subjects to save space, we do at least need to do it in the topic view, mostly for the benefit of quick reply where there are quotes in the subject. (Display.php)
! Very primitive/limited page in admin for configuring likes. It is the plan to add other stuff, like thoughts, into the same page. It allows for enabling/disabling likes and limiting people from liking their own posts. (install.sql, Admin.php, Display.php, Like.php, ManageSettings.php, Display.template.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
Revision: 1665
Author: arantor
Date: 20 August 2012 20:11:13
Message:
! [SMF bug] XSS vulnerability in moderation log (thanks Anonchair) (Modlog.php)
! Since we're no longer escaping quotes in topic subjects to save space, we do at least need to do it in the topic view, mostly for the benefit of quick reply where there are quotes in the subject. (Display.php)
! Very primitive/limited page in admin for configuring likes. It is the plan to add other stuff, like thoughts, into the same page. It allows for enabling/disabling likes and limiting people from liking their own posts. (install.sql, Admin.php, Display.php, Like.php, ManageSettings.php, Display.template.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
2917
The Pub / Re: Print Page
« on August 20th, 2012, 04:16 PM »
It's a bit technical given how the printpage stuff works - it's actually embedded directly into the page, not even as a CSS file! (If/when I make it a plugin, I'll rewrite it to use a CSS file anyway)
I still think you're missing the point with chasing the printable CSS version, though. While you could certainly fix a number of the aspects of layout with a printable stylesheet (most notably, hiding the sidebar, de-floating anything else, hiding most of the user side panel, the options and menus, quick reply), you still won't have the ability to have the entire thread in one place, something not permitted in the main code (it used to be an option but IIRC I removed it), plus links still won't be printed, just their link text.
I think at best you'll get something that looks respectable, but will still be a poor imitation of what is really needed.
The big question: do we need it in the core? My gut feeling is actually no.
I still think you're missing the point with chasing the printable CSS version, though. While you could certainly fix a number of the aspects of layout with a printable stylesheet (most notably, hiding the sidebar, de-floating anything else, hiding most of the user side panel, the options and menus, quick reply), you still won't have the ability to have the entire thread in one place, something not permitted in the main code (it used to be an option but IIRC I removed it), plus links still won't be printed, just their link text.
I think at best you'll get something that looks respectable, but will still be a poor imitation of what is really needed.
The big question: do we need it in the core? My gut feeling is actually no.
2918
The Pub / Re: Print Page
« on August 20th, 2012, 03:07 PM »
This is partly why I want to make it a plugin because I'd actually remove all the extra crap from the parser which would allow some sanity.
Let me explain my beef with this. parse_bbc accepts 4 parameters: the message to parse, whether smileys are enabled, a cache id, and a list of specific tags to parse. (This last one is primarily used for signatures, where you only allow certain bbc in signatures.)
Seems logical, right? Yeah... I thought that, until I realised that the 'are smileys allowed' parameter isn't really a boolean. It has three valid values - true, false, and 'print'. As you can imagine that's not the way to go about things.
Let me explain my beef with this. parse_bbc accepts 4 parameters: the message to parse, whether smileys are enabled, a cache id, and a list of specific tags to parse. (This last one is primarily used for signatures, where you only allow certain bbc in signatures.)
Seems logical, right? Yeah... I thought that, until I realised that the 'are smileys allowed' parameter isn't really a boolean. It has three valid values - true, false, and 'print'. As you can imagine that's not the way to go about things.
2919
The Pub / Re: Print Page
« on August 20th, 2012, 03:01 PM »
There's quite a bit more involved than simply using a different stylesheet.
Print page versions have the entire thread on them, not paginated. There are also several changes to the way bbcode is handled, certain tags get disabled, certain other tags have their behaviour modified to suit printing, for example the color bbc is silently disabled, links are changed so that the URL is present.
None of this stuff can be done in CSS.
Print page versions have the entire thread on them, not paginated. There are also several changes to the way bbcode is handled, certain tags get disabled, certain other tags have their behaviour modified to suit printing, for example the color bbc is silently disabled, links are changed so that the URL is present.
None of this stuff can be done in CSS.
2920
The Pub / Re: Print Page
« on August 20th, 2012, 02:45 PM »But I think that Google & co know better when it comes to a topic page - especially with the 'next' and 'previous' (prev?) meta keywords in it to indicate that it's a multi-page topic.
But guests are also entitled to viewing printpage if they're not bots...
OTOH, one of the good points of printpage is that it gets you more chances to have multiple keywords stuffed in it.
Also note that there are cases where you can screw things up because of the way print page works. For example, try to get the print page of the Aeva topic on SMF, it's likely going to fail hard when it runs out of memory.
The main display staggers it - it pulls one post, processes it, displays it. Print page gets *everything* in one go and then hands it all to the template. For larger topics, doubly so on low-memory configurations, it's going to go splat.
2921
The Pub / Re: Getting ready for an alpha release...
« on August 20th, 2012, 02:37 PM »
It's a patch, not the full install.sql file. You're only seeing the differences between what's in the SVN trunk and what Nao's suggesting, which means you're seeing a tiny tiny tiny fraction of it.
2922
The Pub / Print Page
« on August 20th, 2012, 05:25 AM »
I've thought about Print Page recently and have some mixed feelings about it.
Specifically, three things occur to me.
1) It could be a plugin rather than a core feature. The savings for the bulk of forums would be quite significant since robots do often follow nofollow links, they just don't carry link juice through. So removing it entirely would actually save quite a bit of bandwidth in the long run.
2) If it's not made a plugin, it could have permissions attached, e.g. default to be not visible to guests.
3) If it does remain core and doesn't have permissions attached, it at least needs to indicate noindex in the page itself, since right now they still do get indexed.
Also, making it a plugin would mean one less stupid thing that is going to appear in 'how do I configure my htaccess for bestest SEO for my forums' threads.
Thoughts?
Specifically, three things occur to me.
1) It could be a plugin rather than a core feature. The savings for the bulk of forums would be quite significant since robots do often follow nofollow links, they just don't carry link juice through. So removing it entirely would actually save quite a bit of bandwidth in the long run.
2) If it's not made a plugin, it could have permissions attached, e.g. default to be not visible to guests.
3) If it does remain core and doesn't have permissions attached, it at least needs to indicate noindex in the page itself, since right now they still do get indexed.
Also, making it a plugin would mean one less stupid thing that is going to appear in 'how do I configure my htaccess for bestest SEO for my forums' threads.
Thoughts?
2923
Other software / Re: More thoughts on SMF 2.1
« on August 19th, 2012, 10:40 PM »
Go ask on simplemachines.org.
Though, if you have to ask, the odds are you probably shouldn't be using it anyway for the simple reason is that it is not considered stable enough even to have a public alpha.
Though, if you have to ask, the odds are you probably shouldn't be using it anyway for the simple reason is that it is not considered stable enough even to have a public alpha.
2924
The Pub / Re: Getting ready for an alpha release...
« on August 19th, 2012, 02:13 AM »
Oh, that reminds me, I need to remove the ban system as it stands so people don't get any funny ideas about using it because it'll be completely fucked up.
2925
The Pub / Re: Getting ready for an alpha release...
« on August 18th, 2012, 08:40 PM »
OK, let's recap something.
smallint ranges from -32768 to 32767 (0 to 65535 when unsigned)
mediumint has a range of +/- 8 million (16m when unsigned)
int has a range of +/- 2 billion (4 billion when unsigned)
You cannot assign that many groups to users, because if you have that many, the additional_groups will overflow IIRC as it only has so much space.
And, also, I'm still not comfortable expanding ids just for the sake of it - it WILL have a performance penalty on indexes on larger forums.
I can see the use for millions of groups - user created contact lists. (Though the group column MUST remain signed in most places e.g. with permissions, where permissions are required to apply to guests which are group -1. I can't consider the need for literally billions of groups, though even with a signed mediumint, that's still a column running into the millions, which I can imagine could be the case.)
smallint ranges from -32768 to 32767 (0 to 65535 when unsigned)
mediumint has a range of +/- 8 million (16m when unsigned)
int has a range of +/- 2 billion (4 billion when unsigned)
You cannot assign that many groups to users, because if you have that many, the additional_groups will overflow IIRC as it only has so much space.
And, also, I'm still not comfortable expanding ids just for the sake of it - it WILL have a performance penalty on indexes on larger forums.
I can see the use for millions of groups - user created contact lists. (Though the group column MUST remain signed in most places e.g. with permissions, where permissions are required to apply to guests which are group -1. I can't consider the need for literally billions of groups, though even with a signed mediumint, that's still a column running into the millions, which I can imagine could be the case.)