Wedge

I like it a lot, but in my head I keep hearing this voice from this... "BECAUSE I'M BATMAN!" from it. The blue part... because it's Batman.

@ is for directives like @media - it seems very odd to me to overload that. It sort of threw me when I first encountered LESS on its own when experimenting with Bootstrap, to have everything prefixed with @ throughout the entire source.

Either it needs to be be consistently with @ or consistently without to let @ be left alone as it was for @media type stuff. Unless you have a different symbol in mind that can be consistently used everywhere?

The board index.What you end up doing is an INNER JOIN to something else. OK, let's figure out what that would actually give you. Something simple like the last 5 topics in all the boards we can see. (Expanding it to actually encompass this above)

SELECT t.id_topic, b.name
FROM {db_prefix}topics AS t
INNER JOIN {db_prefix}boards AS b ON (b.id_board IN (1,2,3,4,5,6))
WHERE t.approved = 1 AND b.id_board = t.id_board
ORDER BY t.id_topic DESCAs opposed to
SELECT t.id_topic, b.name
FROM {db_prefix}topics AS t
INNER JOIN {db_prefix}boards AS b ON (b.id_board = t.id_board)
WHERE b.id_board IN (1,2,3,4,5,6) AND t.approved = 1
ORDER BY t.id_topic DESCThis is not a perfect example, performance it's mostly a push because the join doesn't actually benefit you in any way whatsoever. The ONLY way that join will ever be a benefit (and the context in which I actually meant that comment) is if you're not doing it this way.

The bottleneck in these queries is not the method of parsing or injection. It's the fact you're still doing what amounts to WHERE id_board = 1 OR id_board = 2 OR id_board = 3 etc. It doesn't matter a pair of fetid dingo's kidneys that it's been rewritten to the JOIN because it still has to be evaluated as that to actually perform the join.

When I referred to JOINs being faster, they are faster when you're dealing with tables, rather than injected variables like that. Hell, even a join to a subquery might be slightly faster if evaluating the selection criteria there.No, it gets more complicated. Plugin authors cannot rely on {query_see_board} actually joining {db_prefix}boards AS b, because it wouldn't for admin users. Which means you either have to force that extra join for admin users (as opposed to bypassing it entirely for performance), or you have to join the table manually yourself to get things like the board names.

Which means that to reliably get board names you'd actually have to do this:
SELECT t.id_topic, b2.name
FROM {db_prefix}topics AS t
INNER JOIN {db_prefix}boards AS b ON (b.id_board IN (1,2,3,4,5,6))      <------- this is the query_see_board line
INNER JOIN {db_prefix}boards AS b2 ON (b.id_board = t.id_board)
WHERE t.approved = 1 AND b.id_board = t.id_board
ORDER BY t.id_topic DESC

And then it starts to hurt, doing two joins to the same table instead of doing the correct WHERE clause.Like everything it's relative to context. Certain cases will outperform others.

There were a good many things missing from it IIRC, that was one of the smaller things that just wasn't doable. :(It will get done this time. I'm just currently rewriting the quick moderation code that should make it hookable properly.

(3 files, 4KB)

Revision: 1686
Author: arantor
Date: 07 September 2012 02:30:13
Message:
! There are certain permissions that guests and regular members should never have. (ManageMembergroups.php)

! Clean up the dropdown for quick moderation, now it's accessible through the main message index hook (can't yet extend behaviour, just the displayed dropdown), and saves a bit of code on the side. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Themes/default/MessageIndex.template.php

Quick second preview before I go to bed. It's ugly, but you get the idea where this is going :)

OK, let's say hypothetically, that soft-delete hides the post into a single barely-one-line-high message in place of the actual content, simply to say 'This post was deleted by a moderator', and that for those who can see it, there's an additional link 'To view this message, click here'.

We're only consuming a small amount of space on the screen but we're providing context.

For example, consider the following thread:

Post 1: <says something interesting>
Post 2: <blatant insult>
Post 3: The post above me is rubbish.

Now delete post 2. In the classic context you're left with:

Post 1: <says something interesting>
Post 3: The post above me is rubbish.

Which artificially distorts the meaning behind it, though unintentionally. Perhaps there's education that Post 3's author should be more specific, but whatever, it's caused more than one row that I've seen on sm.org, let alone elsewhere.

Under what I'm suggesting you'd have:

Post 1: <says something interesting>
 -- this post has been deleted by a moderator --
Post 3: The post above me is rubbish.

Now, no context is lost. It's quite clear to everyone who can see the thread what happened. No misunderstanding is made based on anything.

If you really did want to delete it, there should be a permadelete option but in almost every case I've encountered, moderators can all only soft-delete and only admins can permadelete, so in most cases nothing changes.

The only counter argument that remains as I see it is the fact you have a potential case of 'soft-soft-delete', for which you can then manufacture an argument of 'but I need a soft-soft-soft-delete' ad nauseum. I'm not convinced there needs to be an extra state, nor am I yet convinced that the ability to unapprove a post is required.

If you want to take it out of circulation, soft-delete it, that's what it's there for. You can put it back later if you need to, or you can spirit it away with the caveats of lost context above, but it should be more obvious in this situation.

In which case, wouldn't you use the report function (or some slightly different analogue, maybe rename it as 'discuss with moderators') to discuss it?

Or even just soft-delete and be done with it and then deal with it that way?