Show Posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - Arantor
2731
Features / Re: New revs
« on September 30th, 2012, 04:21 AM »
(11 files, 3KB)

Revision: 1722
Author: arantor
Date: 30 September 2012 03:19:31
Message:
! Stupid boardsAllowedTo bug. (Security.php)

! The this-user-is-being-ignored text should have the right cursor. (index.member.css)

! Crude hack for the installer to prevent it trying to cache during installation. (install.php, Subs.php)

! Remove base_theme support, as far as I know nothing is broken. (JSOption.php, Load.php, ManageServer.php, Profile-Modify.php, ScheduledTasks.php, Subs-Members.php, Themes.php)
----
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/other/install.php

I'm open to suggestions about improving the installer hack stuff, by the way.
2732
Features / Re: New revs - Public comments
« on September 30th, 2012, 04:00 AM »
OK, so I've hacked together something that works for the time being.

So, the contents of my <head> is thus:

Code: [Select]
<head>
<link rel="stylesheet" href="http://localhost/wedge/css/member-chrome22-1348934260.css">
<!-- Powered by Wedge, © Wedgeward - http://wedge.org -->
<title>Localhost Wedge - Home</title>
<link rel="shortcut icon" href="http://localhost/wedge/favicon.ico" type="image/vnd.microsoft.icon">
<link rel="canonical" href="http://localhost/wedge/index.php">
<link rel="search" href="http://localhost/wedge/index.php?action=search">
<link rel="alternate" type="application/atom+xml" title="Localhost Wedge - Latest Posts Feed" href="http://localhost/wedge/index.php?action=feed">
<meta name="generator" content="Wedge">
<script src="http://ajax.googleapis.com/ajax/libs/jquery/1.5.2/jquery.min.js"></script>
<script src="http://localhost/wedge/js/script-1348943198.js"></script>
</head>

Uncaught TypeError: Object [object Object] has no method 'sb'
2733
Features / Re: New revs - Public comments
« on September 30th, 2012, 03:31 AM »
Install is currently completely broken, due to language caching - because it's trying to call updateSettings on the first pass, which of course it can't do because it doesn't have DB settings of any kind.

Guess I *really* need to set up caching now. That is, once I rebuild my installation >_<
2734
The Pub / Re: Language editing inside Wedge
« on September 29th, 2012, 11:25 PM »
Hell yes.

Let me explain the problem. As it stands right now, there are 3 separate places where a theme could load its language files from: current theme, base_theme (if current theme depends on another theme), default theme.

Trouble is, when a theme declares itself to be dependent on a base theme, it only stores the folder for it, not the actual id. Well, I need the actual id to be able to make this work. I could go through and hack in support so that any given theme also tracks the id of the theme on which it is based.
Quote
So, basically, I think these would be the wrong reasons for removing support.
Well... it's not a good reason but it's not a bad one either, as such.

1) It is fully undocumented.
2) I don't know anyone that used it for certain. It's possible Bloc used it but if he did, he's the only one that ever did. Everyone else just included their own templates and whatnot.
3) I'm not even sure it actually works properly in SMF, let alone Wedge.
2735
Off-topic / Re: Doctor Who
« on September 29th, 2012, 08:36 PM »
* Arantor is not at home and can't watch it until tonight :^^;:
2736
The Pub / Re: Print Page
« on September 29th, 2012, 08:35 PM »
Been thinking about this again. One of the features I want to offer in relation to the warning system would benefit if print page were removed, though it's entirely possible to do without touching print page at all. I just think it'd be cleaner to remove print page, I'm also thinking about cleaning up parse_bbc to have two paramaters - the message and an array of options to be passed inwards.
2737
The Pub / Re: Language editing inside Wedge
« on September 29th, 2012, 07:29 PM »
*nods* Now I understand.

Getting back to the above, it would be drastically simpler to implement if base_theme were removed. It isn't a facility that is heavily used so I see no reason not to do that (and it would make all language loading slightly faster), are there any objections to removing it?
2738
The Pub / Re: Language editing inside Wedge
« on September 29th, 2012, 03:01 PM »
Quote
When I say 'test for file changes', I obviously say 'call filemdate on the file and compare it with $latest_date'... Should I re-explain everything again..?? :-/
This brings me back to the ACP. If you update it in the ACP, it clears the cache, job is done, I continue to fail to understand why checking the dates is relevant.

Install a new language pack, nothing changes - it just becomes a new set of cached files. Change the default language, clear the cache. Update the installation, clear the cache (good practice in any situation)

I still do not understand why there is a need to check every single page load, because there is NOT a need to do this, nor is there a need to keep track of which files are changed. As long as the language editor flushes the cache, the job is done automatically.

This also means you don't have to worry about language files for plugins because if you clean out the cache while you're doing it, they're automatically taken care of. We can implement a facility to clear the relevant bits of the cache by checking files, if necessary, but that's *still* preferable to tracking and over complicating things.

I do not see this being a problem for plugin authors, which is why I've been writing plugins to make sure of this.
2739
The Pub / Re: Language editing inside Wedge
« on September 29th, 2012, 12:53 AM »
Quote
- The code doesn't (yet???) support (or care for) other themes. I figure you'll want to add support yourself :)
Well, this is sort of why I brought the issue up. Multiple theme support is tricky because by definition you need to be able to override what's in the default theme. loadLanguage does this just fine, loadPluginLanguage doesn't care (by design).
Quote
Supposedly, when we do loadLanguage, we can first test for file changes
If at any point we are testing for file changes of the language files, the whole exercise becomes a waste of time. The whole point is to NEVER change the actual language files, which is why I'm so adamant that if the files do get changed, we should NOT lift a finger to help it along, under ANY circumstances.

Unless you're testing for changes of the resultant JS in some fashion but even then it's all down to things being in the DB or not, nothing more.
2740
Plugins / Re: Extending the moderation filter actions when posting
« on September 27th, 2012, 12:09 PM »
Well, that's the beauty of it, you can configure it in all sorts of fun ways - /solved is the canonical example but not required to be that.
2741
Plugins / Re: Extending the moderation filter actions when posting
« on September 27th, 2012, 02:35 AM »
Random question: would it be useful to extend Topic Solved with this to prove it all works?
2742
Features / Re: New revs - Public comments
« on September 26th, 2012, 09:35 PM »
I haven't done it yet, had other things to do like eat...
2743
Features / Re: New revs - Public comments
« on September 26th, 2012, 08:05 PM »
Well, I'll do a fresh install and see what happens (which will check both issues at once)
2744
Features / Re: New revs - Public comments
« on September 26th, 2012, 06:03 PM »
Quote
I've never had such any problem...?!
What's in your HTML head?
Well, it's a fresh install, but I'll take a proper look later.
Quote
What about this one btw..?
I'm not honestly that bothered what it replaces, provided that from a fresh install it installs without having to manually hack the Settings file...
2745
Features / Re: New revs
« on September 26th, 2012, 04:26 AM »
(3 files, 2KB)

Revision: 1718
Author: arantor
Date: 26 September 2012 03:25:18
Message:
! Bodged together the 'is this recurring' checkbox back on to the paid subs confirmation screen. It's about as inelegant as before but at least it works now. (Subscriptions-PayPal.php, Profile-Actions.php, ManagePaid.template.php)

! Amended the PayPal URL to be secure. No reason for it not to be. (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Themes/default/ManagePaid.template.php

@ The changes to the subs modules today still mean it's broken for recurring. It's just slightly less broken in other ways now.